You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/04 23:23:12 UTC
[GitHub] [incubator-superset] nytai opened a new pull request #10800: feat: database delete warning
nytai opened a new pull request #10800:
URL: https://github.com/apache/incubator-superset/pull/10800
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
- api endpoint to fetch charts and dashboards related to a database
- warning modal to display message regarding potential effects of deleting a database
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
<img width="3008" alt="Screen Shot 2020-09-04 at 4 21 39 PM" src="https://user-images.githubusercontent.com/10255196/92290895-cab6bf00-eeca-11ea-8503-b4d385e80af1.png">
<img width="3005" alt="Screen Shot 2020-09-04 at 4 21 22 PM" src="https://user-images.githubusercontent.com/10255196/92290903-d73b1780-eeca-11ea-8513-be1e1c27f706.png">
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
- CI, py and js test, 👀
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai merged pull request #10800: feat: database delete warning
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #10800:
URL: https://github.com/apache/incubator-superset/pull/10800
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] benceorlai commented on pull request #10800: feat: database delete warning
Posted by GitBox <gi...@apache.org>.
benceorlai commented on pull request #10800:
URL: https://github.com/apache/incubator-superset/pull/10800#issuecomment-735493550
Roadmap: https://github.com/apache-superset/superset-roadmap/issues/55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org