[GitHub] [tomcat] michael-o commented on a diff in pull request #666: Performance improvements for ImplicitObjectELResolver

["michael-o (via GitHub)" <gi...@apache.org>]

michael-o commented on code in PR #666:
URL: https://github.com/apache/tomcat/pull/666#discussion_r1318844150


##########
java/javax/servlet/jsp/el/ImplicitObjectELResolver.java:
##########
@@ -44,31 +44,32 @@
  * @since JSP 2.1
  */
 public class ImplicitObjectELResolver extends ELResolver {
+    private enum Scope {
+        APPLICATION_SCOPE, COOKIE, HEADER, HEADER_VALUES, INIT_PARAM, PAGE_CONTEXT, PAGE_SCOPE, PARAM, PARAM_VALUES,
+        REQUEST_SCOPE, SESSION_SCOPE;

Review Comment:
   Aren't the `_SCOPE` suffixes redundant?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org