You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2017/10/04 09:11:48 UTC
[GitHub] zeppelin pull request #2606: [ZEPPELIN-2970] Enhance Authentication decrypti...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2606
[ZEPPELIN-2970] Enhance Authentication decrypting key generation
### What is this PR for?
Overview : The random number generator implemented by nextInt() cannot withstand a cryptographic attack.
In the file IdHashes.java similar issues were on line numbers 74
Comments : Use of SecureRandom is recommended
### What type of PR is it?
[Refactoring]
### What is the Jira issue?
* [https://issues.apache.org/jira/browse/ZEPPELIN-2970](https://issues.apache.org/jira/browse/ZEPPELIN-2970)
### How should this be tested?
CI should be green
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2970
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2606.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2606
----
commit 6c6e90d31c54ff6dc98ad23f8c86ba33926168d0
Author: Prabhjyot Singh <pr...@gmail.com>
Date: 2017-10-04T09:10:34Z
use SecureRandom instead of Random
----
---
[GitHub] zeppelin issue #2606: [ZEPPELIN-2970] Enhance Authentication decrypting key ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2606
LGTM
---
[GitHub] zeppelin issue #2606: [ZEPPELIN-2970] Enhance Authentication decrypting key ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2606
@felixcheung yes there were four more, have updated those as well.
---
[GitHub] zeppelin issue #2606: [ZEPPELIN-2970] Enhance Authentication decrypting key ...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2606
Thanks for the review will merge this if no more discussion.
CI fails for Job #470.2 with following exception; which is unrelated
```
1) Search block e2e Test correct count of selections
[INFO] [31m- [39m[31mFailed: No element found using locator: By(xpath, //div[@class="new-paragraph" and @ng-click="insertNew('below');"])[39m
[INFO]
[INFO] 2) Search block e2e Test correct matches count number
[INFO] [31m- [39m[31mFailed: No element found using locator: By(xpath, //div[@class="new-paragraph" and @ng-click="insertNew('below');"])[39m
[INFO]
[INFO] 3) Search block e2e Test counter increase and decrease correctly
[INFO] [31m- [39m[31mFailed: No element found using locator: By(xpath, //div[@class="new-paragraph" and @ng-click="insertNew('below');"])[39m
[INFO]
[INFO] 4) Search block e2e Test matches count changes correctly after replace
[INFO] [31m- [39m[31mFailed: No element found using locator: By(xpath, //div[@class="new-paragraph" and @ng-click="insertNew('below');"])[39m
[INFO]
[INFO] 5) Search block e2e Test replace all works correctly
[INFO] [31m- [39m[31mFailed: No element found using locator: By(xpath, //div[@class="new-paragraph" and @ng-click="insertNew('below');"])[39m
```
---
[GitHub] zeppelin pull request #2606: [ZEPPELIN-2970] Enhance Authentication decrypti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2606
---