You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/05/06 06:29:29 UTC
[GitHub] [echarts] plainheart opened a new pull request #14872: chore: enhance the script compatibility in Windows and fix some lint errors.
plainheart opened a new pull request #14872:
URL: https://github.com/apache/echarts/pull/14872
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [x] others
### What does this PR do?
<!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
1) Remove `./node_modules/.bin/` from `script` definition, it will find dependencies from `node_modules` when running script.
- This can solve an issue in Windows that scripts can't run for Windows can't recognize `./`.
2) Remove some unused imports and code according to the lint result.
### Fixed issues
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14872: chore: enhance the script compatibility in Windows and fix some lint errors.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14872:
URL: https://github.com/apache/echarts/pull/14872#issuecomment-833313101
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #14872: chore: enhance the script compatibility in Windows and fix some lint errors.
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14872:
URL: https://github.com/apache/echarts/pull/14872#issuecomment-833263538
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on a change in pull request #14872: chore: enhance the script compatibility in Windows and fix some lint errors.
Posted by GitBox <gi...@apache.org>.
pissang commented on a change in pull request #14872:
URL: https://github.com/apache/echarts/pull/14872#discussion_r627144921
##########
File path: package.json
##########
@@ -57,10 +57,10 @@
"test:dts": "node build/testDts.js",
"mktest": "node test/build/mktest.js",
"mktest:help": "node test/build/mktest.js -h",
- "checktype": "./node_modules/.bin/tsc --noEmit",
- "lint": "./node_modules/.bin/eslint src/**/*.ts extension-src/**/*.ts",
- "lint:fix": "./node_modules/.bin/eslint --fix src/**/*.ts extension-src/**/*.ts",
- "lint:dist": "echo 'It might take a while. Please wait ...' && ./node_modules/.bin/jshint --config .jshintrc-dist dist/echarts.js"
+ "checktype": "tsc --noEmit",
+ "lint": "eslint src/**/*.ts extension-src/**/*.ts",
+ "lint:fix": "eslint --fix src/**/*.ts extension-src/**/*.ts",
Review comment:
Is it better to use `npx eslint`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] plainheart commented on a change in pull request #14872: chore: enhance the script compatibility in Windows and fix some lint errors.
Posted by GitBox <gi...@apache.org>.
plainheart commented on a change in pull request #14872:
URL: https://github.com/apache/echarts/pull/14872#discussion_r627161510
##########
File path: package.json
##########
@@ -57,10 +57,10 @@
"test:dts": "node build/testDts.js",
"mktest": "node test/build/mktest.js",
"mktest:help": "node test/build/mktest.js -h",
- "checktype": "./node_modules/.bin/tsc --noEmit",
- "lint": "./node_modules/.bin/eslint src/**/*.ts extension-src/**/*.ts",
- "lint:fix": "./node_modules/.bin/eslint --fix src/**/*.ts extension-src/**/*.ts",
- "lint:dist": "echo 'It might take a while. Please wait ...' && ./node_modules/.bin/jshint --config .jshintrc-dist dist/echarts.js"
+ "checktype": "tsc --noEmit",
+ "lint": "eslint src/**/*.ts extension-src/**/*.ts",
+ "lint:fix": "eslint --fix src/**/*.ts extension-src/**/*.ts",
Review comment:
I think it would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #14872: chore: enhance the script compatibility in Windows and fix some lint errors.
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14872:
URL: https://github.com/apache/echarts/pull/14872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org