[GitHub] [hive] abstractdog commented on pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF

[GitBox <gi...@apache.org>]

abstractdog commented on pull request #2242:
URL: https://github.com/apache/hive/pull/2242#issuecomment-838819612


   the change makes sense to me, could you confirm that this use-case is covered by a q.test?
   I was looking for qtests, I found similar ones but only with struct type (StructColumnVector, which doesn’t inherit MultiValuedColumnVector)
   e.g.:
   schema_evol_text_vecrow_part_all_complex.q
   I think q.test for this use should have the following properties:
   1. use text format file for reading
   2. force vector/row serde deserialize:
   ```
   SET hive.vectorized.use.vectorized.input.format=false;
   SET hive.vectorized.use.vector.serde.deserialize=true;
   SET hive.vectorized.use.row.serde.deserialize=true;
   ```
   3. use map/list type
   4. work on small batches or a large amount of rows <1024 (to force batch reuse = reuse of deserializerBatch)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org