[GitHub] [incubator-tvm] hlu1 commented on issue #5301: [NDArray] Set NDArray::Container.shape_ in NDArray::FromDLPack

[GitBox <gi...@apache.org>]

hlu1 commented on issue #5301: [NDArray] Set NDArray::Container.shape_ in NDArray::FromDLPack
URL: https://github.com/apache/incubator-tvm/pull/5301#issuecomment-611907106
 
 
   I'm referring to the case that DLManagedTensor.dl_tensor.shape which is an int64_t* could be pointing to an array that's allocated in the stack and not on the heap. People are usually pretty careful to make sure the data is allocated on the heap and properly deleted in the deleter, but forget to do the same for the shape info.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services