Re: svn commit: r1140899 - /apr/apr/trunk/crypto/apr_crypto_openssl.c

[Rainer Jung <ra...@kippdata.de>]

On 29.06.2011 01:15, rjung@apache.org wrote:
> Author: rjung
> Date: Tue Jun 28 23:15:58 2011
> New Revision: 1140899
> 
> URL: http://svn.apache.org/viewvc?rev=1140899&view=rev
> Log:
> Remove unused variable.
> 
> Modified:
>     apr/apr/trunk/crypto/apr_crypto_openssl.c
> 
> Modified: apr/apr/trunk/crypto/apr_crypto_openssl.c
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/crypto/apr_crypto_openssl.c?rev=1140899&r1=1140898&r2=1140899&view=diff
> ==============================================================================
> --- apr/apr/trunk/crypto/apr_crypto_openssl.c (original)
> +++ apr/apr/trunk/crypto/apr_crypto_openssl.c Tue Jun 28 23:15:58 2011
> @@ -98,7 +98,6 @@ static apr_status_t crypto_shutdown(void
>  }
>  
>  static apr_status_t crypto_shutdown_helper(void *data) {
> -    apr_pool_t *pool = (apr_pool_t *) data;
>      return crypto_shutdown();
>  }

Note that I removed the unsed variable to prevent a compiler warning.

The code in 1.4.x and 1.5.x is different: it passes the pool along to
crypto_shutdown() which then doesn't use it. I guess we want the code to
be consistent, but I'm not sure, which way to prefer - pass the pool
to crypto_shutdown and ignore there (1.4, 1.5), or already dropp it in
crypto_shutdown_helper (trunk).

Regards,

Rainer

Re: svn commit: r1140899 - /apr/apr/trunk/crypto/apr_crypto_openssl.c

[Graham Leggett <mi...@sharp.fm>]

On 29 Jun 2011, at 2:12 AM, Rainer Jung wrote:

> Note that I removed the unsed variable to prevent a compiler warning.
>
> The code in 1.4.x and 1.5.x is different: it passes the pool along to
> crypto_shutdown() which then doesn't use it. I guess we want the  
> code to
> be consistent, but I'm not sure, which way to prefer - pass the pool
> to crypto_shutdown and ignore there (1.4, 1.5), or already dropp it in
> crypto_shutdown_helper (trunk).

apr-trunk, v1.5.x and v1.4.x should all be the same, and if they're  
not it's an oversight.

Regards,
Graham
--