You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/15 15:33:52 UTC
[GitHub] [incubator-devlake] Startrekzky commented on a diff in pull request #2506: fix: fill in core.SubTaskMeta.DomainTypes
Startrekzky commented on code in PR #2506:
URL: https://github.com/apache/incubator-devlake/pull/2506#discussion_r922272871
##########
plugins/gitextractor/tasks/git_repo_collector.go:
##########
@@ -98,18 +98,21 @@ var CollectGitCommitMeta = core.SubTaskMeta{
EntryPoint: CollectGitCommits,
EnabledByDefault: true,
Description: "collect git commits into Domain Layer Tables",
+ DomainTypes: []string{core.DOMAIN_TYPE_CODE, core.DOMAIN_TYPE_CROSS},
Review Comment:
Why does it have 2 domains?
##########
plugins/gitee/tasks/commit_extractor.go:
##########
@@ -30,6 +30,7 @@ var ExtractCommitsMeta = core.SubTaskMeta{
EntryPoint: ExtractApiCommits,
EnabledByDefault: true,
Description: "Extract raw commit data into tool layer table GiteeCommit,GiteeAccount and GiteeRepoCommit",
+ DomainTypes: []string{core.DOMAIN_TYPE_CODE, core.DOMAIN_TYPE_CROSS},
Review Comment:
Why it has 2 domains?
##########
plugins/jira/tasks/issue_changelog_convertor.go:
##########
@@ -38,7 +38,7 @@ var ConvertIssueChangelogsMeta = core.SubTaskMeta{
EntryPoint: ConvertIssueChangelogs,
EnabledByDefault: true,
Description: "convert Jira Issue change logs",
- DomainTypes: []string{core.DOMAIN_TYPE_TICKET},
+ DomainTypes: []string{core.DOMAIN_TYPE_TICKET, core.DOMAIN_TYPE_CROSS},
Review Comment:
why add cross?
##########
plugins/jira/tasks/issue_changelog_collector.go:
##########
@@ -40,7 +40,7 @@ var CollectIssueChangelogsMeta = core.SubTaskMeta{
EntryPoint: CollectIssueChangelogs,
EnabledByDefault: true,
Description: "collect Jira Issue change logs",
- DomainTypes: []string{core.DOMAIN_TYPE_TICKET},
+ DomainTypes: []string{core.DOMAIN_TYPE_TICKET, core.DOMAIN_TYPE_CROSS},
Review Comment:
why add `cross`?
##########
plugins/tapd/tasks/worklog_collector.go:
##########
@@ -87,4 +87,5 @@ var CollectWorklogMeta = core.SubTaskMeta{
EntryPoint: CollectWorklogs,
EnabledByDefault: true,
Description: "collect Tapd worklogs",
+ DomainTypes: []string{core.DOMAIN_TYPE_CROSS},
Review Comment:
ticket?
##########
plugins/tapd/tasks/task_custom_fields_collector.go:
##########
@@ -65,4 +65,5 @@ var CollectTaskCustomFieldsMeta = core.SubTaskMeta{
EntryPoint: CollectTaskCustomFields,
EnabledByDefault: true,
Description: "collect Tapd TaskCustomFields",
+ DomainTypes: []string{core.DOMAIN_TYPE_CROSS},
Review Comment:
ticket?
##########
plugins/tapd/tasks/worklog_converter.go:
##########
@@ -91,4 +91,5 @@ var ConvertWorklogMeta = core.SubTaskMeta{
EntryPoint: ConvertWorklog,
EnabledByDefault: true,
Description: "convert Tapd Worklog",
+ DomainTypes: []string{core.DOMAIN_TYPE_CROSS},
Review Comment:
ticket?
##########
plugins/github/tasks/comment_collector.go:
##########
@@ -130,5 +130,5 @@ var CollectApiCommentsMeta = core.SubTaskMeta{
EntryPoint: CollectApiComments,
EnabledByDefault: true,
Description: "Collect comments data from Github api",
- DomainTypes: []string{core.DOMAIN_TYPE_CODE, core.DOMAIN_TYPE_TICKET},
+ DomainTypes: []string{core.DOMAIN_TYPE_CODE_REVIEW, core.DOMAIN_TYPE_TICKET},
Review Comment:
Is this the collector for issue comments or PR comments?
##########
plugins/jira/tasks/issue_extractor.go:
##########
@@ -36,7 +36,7 @@ var ExtractIssuesMeta = core.SubTaskMeta{
EntryPoint: ExtractIssues,
EnabledByDefault: true,
Description: "extract Jira issues",
- DomainTypes: []string{core.DOMAIN_TYPE_TICKET},
+ DomainTypes: []string{core.DOMAIN_TYPE_TICKET, core.DOMAIN_TYPE_CROSS},
Review Comment:
why add cross?
##########
plugins/github/tasks/pr_review_extractor.go:
##########
@@ -31,7 +31,7 @@ var ExtractApiPullRequestReviewersMeta = core.SubTaskMeta{
EntryPoint: ExtractApiPullRequestReviewers,
EnabledByDefault: true,
Description: "Extract raw PullRequestReviewers data into tool layer table github_reviewers",
- DomainTypes: []string{core.DOMAIN_TYPE_CODE},
+ DomainTypes: []string{core.DOMAIN_TYPE_CROSS},
Review Comment:
code review?
##########
plugins/github/tasks/pr_review_collector.go:
##########
@@ -41,7 +41,7 @@ var CollectApiPullRequestReviewsMeta = core.SubTaskMeta{
EntryPoint: CollectApiPullRequestReviews,
EnabledByDefault: true,
Description: "Collect PullRequestReviews data from Github api",
- DomainTypes: []string{core.DOMAIN_TYPE_CODE},
+ DomainTypes: []string{core.DOMAIN_TYPE_CROSS},
Review Comment:
code review?
##########
plugins/jira/tasks/issue_changelog_extractor.go:
##########
@@ -33,7 +33,7 @@ var ExtractIssueChangelogsMeta = core.SubTaskMeta{
EntryPoint: ExtractIssueChangelogs,
EnabledByDefault: true,
Description: "extract Jira Issue change logs",
- DomainTypes: []string{core.DOMAIN_TYPE_TICKET},
+ DomainTypes: []string{core.DOMAIN_TYPE_TICKET, core.DOMAIN_TYPE_CROSS},
Review Comment:
why add cross?
##########
plugins/tapd/tasks/task_label_convertor.go:
##########
@@ -33,6 +33,7 @@ var ConvertTaskLabelsMeta = core.SubTaskMeta{
EntryPoint: ConvertTaskLabels,
EnabledByDefault: true,
Description: "Convert tool layer table tapd_issue_labels into domain layer table issue_labels",
+ DomainTypes: []string{core.DOMAIN_TYPE_CROSS},
Review Comment:
ticket?
##########
plugins/tapd/tasks/task_extractor.go:
##########
@@ -35,6 +35,7 @@ var ExtractTaskMeta = core.SubTaskMeta{
EntryPoint: ExtractTasks,
EnabledByDefault: true,
Description: "Extract raw workspace data into tool layer table _tool_tapd_iterations",
+ DomainTypes: []string{core.DOMAIN_TYPE_CROSS},
Review Comment:
ticket?
##########
plugins/jira/tasks/issue_collector.go:
##########
@@ -46,7 +46,7 @@ var CollectIssuesMeta = core.SubTaskMeta{
EntryPoint: CollectIssues,
EnabledByDefault: true,
Description: "collect Jira issues",
- DomainTypes: []string{core.DOMAIN_TYPE_TICKET},
+ DomainTypes: []string{core.DOMAIN_TYPE_TICKET, core.DOMAIN_TYPE_CROSS},
Review Comment:
why add cross?
##########
plugins/tapd/tasks/task_custom_fields_extractor.go:
##########
@@ -32,6 +32,7 @@ var ExtractTaskCustomFieldsMeta = core.SubTaskMeta{
EntryPoint: ExtractTaskCustomFields,
EnabledByDefault: true,
Description: "Extract raw company data into tool layer table _tool_tapd_task_custom_fields",
+ DomainTypes: []string{core.DOMAIN_TYPE_CROSS},
Review Comment:
ticket?
##########
plugins/tapd/tasks/worklog_extractor.go:
##########
@@ -32,6 +32,7 @@ var ExtractWorklogMeta = core.SubTaskMeta{
EntryPoint: ExtractWorklogs,
EnabledByDefault: true,
Description: "Extract raw workspace data into tool layer table _tool_tapd_iterations",
+ DomainTypes: []string{core.DOMAIN_TYPE_CROSS},
Review Comment:
ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org