You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by vesense <gi...@git.apache.org> on 2015/11/06 05:58:30 UTC
[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/865
[STORM-1185] replace nimbus.host with nimbus.seeds
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm patch-8
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/865.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #865
----
commit c804139e86010f7a845af8a0d1713d7efbe7f699
Author: Xin Wang <be...@163.com>
Date: 2015-11-06T03:31:32Z
replace nimbus.host with nimbus.seeds
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/865#issuecomment-155223539
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/865#discussion_r44159502
--- Diff: conf/storm.yaml.example ---
@@ -19,7 +19,7 @@
# - "server1"
# - "server2"
#
-# nimbus.host: "nimbus"
+# nimbus.seeds: ["localhost"]
--- End diff --
since for Storm HA there can be multiple nimbus hosts, shouldn't we provide an example like with storm.zookeeper.servers that includes multiple hosts? Like
nimbus.seeds: ["host1", "host2", "host3"]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...
Posted by jerrypeng <gi...@git.apache.org>.
Github user jerrypeng commented on the pull request:
https://github.com/apache/storm/pull/865#issuecomment-154914534
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/865#issuecomment-154458498
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/865
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/865#issuecomment-154819795
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/865#issuecomment-154420118
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/865#discussion_r44204593
--- Diff: conf/storm.yaml.example ---
@@ -19,7 +19,7 @@
# - "server1"
# - "server2"
#
-# nimbus.host: "nimbus"
+# nimbus.seeds: ["localhost"]
--- End diff --
Good catch. Updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1185] replace nimbus.host with nimbus.s...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/storm/pull/865#discussion_r44204822
--- Diff: conf/storm.yaml.example ---
@@ -19,7 +19,7 @@
# - "server1"
# - "server2"
#
-# nimbus.host: "nimbus"
+# nimbus.seeds: ["localhost"]
--- End diff --
Can you instead use values that will be valid in a single node setup? With current values anyone running storm locally will be forced to update this value.
nimbus.seeds:["localhost","127.0.0.1"]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---