You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@s2graph.apache.org by "Hwansung Yu (JIRA)" <ji...@apache.org> on 2018/08/29 01:04:00 UTC

[jira] [Created] (S2GRAPH-237) Refactor unused variable on AnnoyIndexBuildSink class

Hwansung Yu created S2GRAPH-237:
-----------------------------------

             Summary: Refactor unused variable on AnnoyIndexBuildSink class
                 Key: S2GRAPH-237
                 URL: https://issues.apache.org/jira/browse/S2GRAPH-237
             Project: S2Graph
          Issue Type: Bug
            Reporter: Hwansung Yu
            Assignee: Hwansung Yu



{code:java}
val df = repartition(preprocess(inputDF), inputDF.sparkSession.sparkContext.defaultParallelism)

if (inputDF.isStreaming) throw new IllegalStateException("AnnoyIndexBuildSink can not be run as streaming.")
else {
      ALSModelProcess.buildAnnoyIndex(conf, inputDF)
}
{code}

In "write" method of AnnoyIndexBuildSink class, variable "df" is never used.
So, repartition does not working .
I think that second parameter of buildAnnoyIndex shoule be "df", not "inputDF".





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)