[jira] [Commented] (HADOOP-12604) Exception may be swallowed in KMSClientProvider

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083607#comment-15083607 ] 

Hudson commented on HADOOP-12604:
---------------------------------

FAILURE: Integrated in Hadoop-trunk-Commit #9050 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9050/])
HADOOP-12604. Exception may be swallowed in KMSClientProvider. (Yongjun (yzhang: rev 28bd138018bea6fc9c3bfb94c7a4143420f02ced)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java
* hadoop-common-project/hadoop-common/CHANGES.txt


> Exception may be swallowed in KMSClientProvider
> -----------------------------------------------
>
>                 Key: HADOOP-12604
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12604
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: kms
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>              Labels: supportability
>         Attachments: HADOOP-12604.001.patch, HADOOP-12604.002.patch
>
>
> In KMSClientProvider# createConnection
> {code}
>       try {
>         is = conn.getInputStream();
>         ret = mapper.readValue(is, klass);
>       } catch (IOException ex) {
>         if (is != null) {
>           is.close(); <== close may throw exception
>         }
>         throw ex;
>       } finally {
>         if (is != null) {
>           is.close();
>         }
>       }
>     }
> {code}
> {{ex}} may be swallowed when {{close}} highlighted in the code throws exception.  Thanks [~qwertymaniac] for pointing this out.
> BTW, I think we should be able to consolidate the two {{is.close()}} in the above code, so we don't close the same stream twice. The one in the {{finally block}} may be called after an exception is thrown or not, and it may throw exception too, we need to be careful not to swallow exception here too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)