svn commit: r1511639 - /subversion/trunk/tools/dist/backport.pl

[da...@apache.org]

Author: danielsh
Date: Thu Aug  8 09:13:28 2013
New Revision: 1511639

URL: http://svn.apache.org/r1511639
Log:
* tools/dist/backport.pl
  ($AVAILID): Avoid leaving an unclosed filehandle USERNAME, since that
    leads to confusing tracebacks in warn/die calls (seen in warn-based
    printf debugging).

Modified:
    subversion/trunk/tools/dist/backport.pl

Modified: subversion/trunk/tools/dist/backport.pl
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dist/backport.pl?rev=1511639&r1=1511638&r2=1511639&view=diff
==============================================================================
--- subversion/trunk/tools/dist/backport.pl (original)
+++ subversion/trunk/tools/dist/backport.pl Thu Aug  8 09:13:28 2013
@@ -59,9 +59,8 @@ my ($AVAILID) = $ENV{AVAILID} // do {
 } // do {
   local $/; # slurp mode
   my $filename = Digest->new("MD5")->add($SVN_A_O_REALM)->hexdigest;
-  open(USERNAME, '<', "$ENV{HOME}/.subversion/auth/svn.simple/$filename")
-  and
-  <USERNAME> =~ /K 8\nusername\nV \d+\n(.*)/ and $1 or undef
+  `cat $ENV{HOME}/.subversion/auth/svn.simple/$filename`
+  =~ /K 8\nusername\nV \d+\n(.*)/ and $1 or undef
 }
 // warn "Username for commits (of votes/merges) not found";