You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/02/21 17:55:33 UTC
[GitHub] flink pull request #3382: [FLINK-3695] [gelly] ValueArray types
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3382
[FLINK-3695] [gelly] ValueArray types
Provide compact and efficiently serializable and comparable array implementations for Flink mutable Value types and Java primitives.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 3695_valuearray_types
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3382.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3382
----
commit aac1f8f2d2ca0e7eba4ab52fba94db62e9c3ef41
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-02-21T16:40:22Z
[FLINK-3695] [gelly] ValueArray types
Provide compact and efficiently serializable and comparable array
implementations for Flink mutable Value types and Java primitives.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3382: [FLINK-3695] [gelly] ValueArray types
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3382
@vasia, if you are available to review, I think the easiest way to do so is to first review the classes for `LongValue` then compare the diff for `IntValue` and `StringValue`. I think we are forced to duplicate code as the value types to keep the method calls monomorphic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3382: [FLINK-3695] [gelly] ValueArray types
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan closed the pull request at:
https://github.com/apache/flink/pull/3382
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3382: [FLINK-3695] [gelly] ValueArray types
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3382
Failing test is unrelated. Merging this after offline discussion with @vasia ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---