[GitHub] [flink] Airblader commented on a change in pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

[GitBox <gi...@apache.org>]

Airblader commented on a change in pull request #18413:
URL: https://github.com/apache/flink/pull/18413#discussion_r788439553



##########
File path: flink-runtime-web/web-dashboard/src/app/share/customize/job-badge/job-badge.component.spec.ts
##########
@@ -22,10 +22,8 @@ import { JobBadgeComponent } from './job-badge.component';
 
 describe('A job badge', () => {
   it('displays the state', async () => {
-    await render(JobBadgeComponent, {
-      componentProperties: {
-        state: 'RUNNING'
-      }
+    await render(`<flink-job-badge [state]="'RUNNING'"></flink-job-badge>`, {

Review comment:
       Why is this change necessary? From reading the changelog, it seems that only the `template` key was removed, but we're not using that. The examples on the website still use the same syntax as we did before.

##########
File path: flink-runtime-web/README.md
##########
@@ -70,6 +70,19 @@ Install *node.js* via:
 brew install node
 ```
 
+### Important Note
+
+Once the runtime web's dependencies are updated, please remove the `node_modules` folder manually
+and run the command:
+
+```bash
+cd flink-runtime-web/web-dashboard
+npm install
+```
+
+to install all the up-to-date dependencies **before trying to build the flink-runtime-web through
+Maven**. Otherwise, you may encounter a failure of `npm ci --cache-max=0 --no-save` task while building.

Review comment:
       Why does that happen? Does `mvn clean` at least remove `node_modules`? If not we should maybe open a JIRA issue for that. Either way, can you please separate this README change into its own commit since it's unrelated to Angular 13?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org