You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/02 19:11:17 UTC
[GitHub] [arrow-rs] yordan-pavlov opened a new pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
yordan-pavlov opened a new pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130
# Which issue does this PR close?
Closes #1111.
# Rationale for this change
As explained in #1111 `RleDecoder` as used in `VariableLenDictionaryDecoder` as part of the implementation of `ArrowArrayReader`, incorrectly returns more keys than are actually available while at the same time, when the page contains NULLs `VariableLenDictionaryDecoder` is also requesting more keys than available because `num_values` is inclusive of NULLs. This then results in incorrectly decoding a dictionary-encoded page which also contains NULLs and returning more values than necessary.
# What changes are included in this PR?
This PR contains:
* a fix where the actual number of values (excluding NULLs) is calculated from def levels (if present) and is used (instead of `num_values` from the data page) when creating the value decoder, so that it knows how many values are actually available. This is then used in existing code in `VariableLenDictionaryDecoder` to limit how many keys are requested from the nested `RleDecoder`.
* a new test `test_arrow_array_reader_dict_enc_string` for `ArrowArrayReader`
* a new test `test_complex_array_reader_dict_enc_string` for `ArrayReader`
# Are there any user-facing changes?
No
@alamb @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#discussion_r777685941
##########
File path: parquet/src/arrow/arrow_array_reader.rs
##########
@@ -420,6 +456,24 @@ impl<'a, C: ArrayConverter + 'a> ArrowArrayReader<'a, C> {
}
}
+ fn count_def_level_values(
+ column_desc: &ColumnDescriptor,
+ level_decoder: crate::encodings::levels::LevelDecoder,
+ num_values: usize,
+ ) -> Result<usize> {
+ let mut def_level_decoder = LevelValueDecoder::new(level_decoder);
+ let def_level_array =
Review comment:
does this mean an entirely new array of definition levels is created for each column? Might this result in a non trivial amount of extra runtime overhead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#issuecomment-1003762887
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1130](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8fc05da) into [master](https://codecov.io/gh/apache/arrow-rs/commit/37b843bc42a3f18c47dcf076dc5d929cb4a54ec1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37b843b) will **increase** coverage by `0.04%`.
> The diff coverage is `95.38%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
+ Coverage 82.33% 82.38% +0.04%
==========================================
Files 169 169
Lines 49773 50242 +469
==========================================
+ Hits 40981 41390 +409
- Misses 8792 8852 +60
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/arrow/arrow\_array\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfYXJyYXlfcmVhZGVyLnJz) | `79.36% <92.03%> (+1.49%)` | :arrow_up: |
| [parquet/src/arrow/array\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyYXlfcmVhZGVyLnJz) | `78.26% <100.00%> (+1.60%)` | :arrow_up: |
| [arrow/src/csv/reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2Nzdi9yZWFkZXIucnM=) | `88.10% <0.00%> (-2.48%)` | :arrow_down: |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `66.38% <0.00%> (-0.43%)` | :arrow_down: |
| [arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jb21wYXJpc29uLnJz) | `89.75% <0.00%> (-0.35%)` | :arrow_down: |
| [arrow/src/array/array\_union.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X3VuaW9uLnJz) | `90.76% <0.00%> (-0.22%)` | :arrow_down: |
| [arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIucnM=) | `86.49% <0.00%> (-0.05%)` | :arrow_down: |
| [arrow/src/datatypes/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9tb2QucnM=) | `100.00% <0.00%> (ø)` | |
| [arrow/src/compute/kernels/cast.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jYXN0LnJz) | `95.07% <0.00%> (+<0.01%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [37b843b...8fc05da](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a change in pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
tustvold commented on a change in pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#discussion_r778421557
##########
File path: parquet/src/arrow/arrow_array_reader.rs
##########
@@ -398,19 +416,37 @@ impl<'a, C: ArrayConverter + 'a> ArrowArrayReader<'a, C> {
offset,
def_levels_byte_len,
);
+ let value_count = Self::count_def_level_values(
Review comment:
You might be able to do `num_values - num_nulls` here as the DataPageV2 has this information. Unfortunately very few implementations in practice seem to produce such pages, and tbh I'm not entirely sure if num_nulls is what I think it is...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#issuecomment-1004333242
FWIW I tested with datafusion on the case where we initially observed this issue and this patch fixes the issue: https://github.com/apache/arrow-datafusion/issues/1441#issuecomment-1004332824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#issuecomment-1004071113
Thank you @yordan-pavlov -- I plan to review / test this patch later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] yordan-pavlov commented on pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
yordan-pavlov commented on pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#issuecomment-1004345771
> Also, I wonder if there are ay benchmark results to demonstrate the performance change related to this PR?
@alamb there is a small (3% to 8% in my benchmark run) negative impact to performance from this change, see here: https://github.com/apache/arrow-rs/issues/1111#issuecomment-1003718555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a change in pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
tustvold commented on a change in pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#discussion_r778421557
##########
File path: parquet/src/arrow/arrow_array_reader.rs
##########
@@ -398,19 +416,37 @@ impl<'a, C: ArrayConverter + 'a> ArrowArrayReader<'a, C> {
offset,
def_levels_byte_len,
);
+ let value_count = Self::count_def_level_values(
Review comment:
You might be able to do `num_values - num_nulls` here as the DataPageV2 has this information. Unfortunately very few implementations in practice seem to produce such pages...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
tustvold commented on pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#issuecomment-1004710388
Thank you for this :tada:. I will take a look today if I have time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#discussion_r778014042
##########
File path: parquet/src/arrow/arrow_array_reader.rs
##########
@@ -420,6 +456,24 @@ impl<'a, C: ArrayConverter + 'a> ArrowArrayReader<'a, C> {
}
}
+ fn count_def_level_values(
+ column_desc: &ColumnDescriptor,
+ level_decoder: crate::encodings::levels::LevelDecoder,
+ num_values: usize,
+ ) -> Result<usize> {
+ let mut def_level_decoder = LevelValueDecoder::new(level_decoder);
+ let def_level_array =
Review comment:
makes sense -- thank you for running the numbers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] yordan-pavlov commented on a change in pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
yordan-pavlov commented on a change in pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#discussion_r777699023
##########
File path: parquet/src/arrow/arrow_array_reader.rs
##########
@@ -420,6 +456,24 @@ impl<'a, C: ArrayConverter + 'a> ArrowArrayReader<'a, C> {
}
}
+ fn count_def_level_values(
+ column_desc: &ColumnDescriptor,
+ level_decoder: crate::encodings::levels::LevelDecoder,
+ num_values: usize,
+ ) -> Result<usize> {
+ let mut def_level_decoder = LevelValueDecoder::new(level_decoder);
+ let def_level_array =
Review comment:
Yes - def levels are decoded a second time for this fix and an i16 array and a boolean array are created to count the non-null values, but they only live for a very short time and the negative effect on performance is surprisingly small (3% to 8% in my benchmark run) see here: https://github.com/apache/arrow-rs/issues/1111#issuecomment-1003718555 ; even after this change the `ArrowArrayReader` is still often several times faster for decoding strings compared to the old `ArrayReader`, this hasn't changed much.
It's probably possible to make this more efficient, but it would require more thinking and more time for a bigger change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] yordan-pavlov removed a comment on pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
yordan-pavlov removed a comment on pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#issuecomment-1004345771
> Also, I wonder if there are ay benchmark results to demonstrate the performance change related to this PR?
@alamb there is a small (3% to 8% in my benchmark run) negative impact to performance from this change, see here: https://github.com/apache/arrow-rs/issues/1111#issuecomment-1003718555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#issuecomment-1003762887
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1130](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a78fe15) into [master](https://codecov.io/gh/apache/arrow-rs/commit/37b843bc42a3f18c47dcf076dc5d929cb4a54ec1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37b843b) will **increase** coverage by `0.04%`.
> The diff coverage is `94.55%`.
[](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
+ Coverage 82.33% 82.38% +0.04%
==========================================
Files 169 169
Lines 49773 50247 +474
==========================================
+ Hits 40981 41395 +414
- Misses 8792 8852 +60
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/arrow/arrow\_array\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyb3dfYXJyYXlfcmVhZGVyLnJz) | `79.24% <90.83%> (+1.37%)` | :arrow_up: |
| [parquet/src/arrow/array\_reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvYXJyYXlfcmVhZGVyLnJz) | `78.26% <100.00%> (+1.60%)` | :arrow_up: |
| [arrow/src/csv/reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2Nzdi9yZWFkZXIucnM=) | `88.10% <0.00%> (-2.48%)` | :arrow_down: |
| [arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jb21wYXJpc29uLnJz) | `89.75% <0.00%> (-0.35%)` | :arrow_down: |
| [arrow/src/array/array\_union.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2FycmF5X3VuaW9uLnJz) | `90.76% <0.00%> (-0.22%)` | :arrow_down: |
| [arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIucnM=) | `86.49% <0.00%> (-0.05%)` | :arrow_down: |
| [arrow/src/datatypes/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9tb2QucnM=) | `100.00% <0.00%> (ø)` | |
| [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `66.80% <0.00%> (ø)` | |
| [arrow/src/compute/kernels/cast.rs](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jYXN0LnJz) | `95.07% <0.00%> (+<0.01%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/arrow-rs/pull/1130/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [37b843b...a78fe15](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1130: Fix reading of dictionary encoded pages with null values (#1111)
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#issuecomment-1006033515
Thanks again @yordan-pavlov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org