You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/02/20 15:45:42 UTC

[GitHub] [camel] jameshilliard opened a new pull request #5106: Mark NatsEndpoint as supporting MultipleConsumers.

jameshilliard opened a new pull request #5106:
URL: https://github.com/apache/camel/pull/5106


   Mark `NatsEndpoint` as supporting `MultipleConsumers`.
       
   Per nats documentation:
   NATS implements a publish-subscribe message distribution model for one-to-many communication.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] oscerd merged pull request #5106: Mark NatsEndpoint as supporting MultipleConsumers.

Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #5106:
URL: https://github.com/apache/camel/pull/5106


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] oscerd commented on pull request #5106: Mark NatsEndpoint as supporting MultipleConsumers.

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #5106:
URL: https://github.com/apache/camel/pull/5106#issuecomment-782712169


   Ah yeah, the NatsConsumer is using the executorService, so this is correct. My fault Sorry. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel] jameshilliard commented on pull request #5106: Mark NatsEndpoint as supporting MultipleConsumers.

Posted by GitBox <gi...@apache.org>.
jameshilliard commented on pull request #5106:
URL: https://github.com/apache/camel/pull/5106#issuecomment-782710401


   > This is not obvious and it doesn't depend from Nats, but from camel.
   
   Isn't it effectively a matter of whether or not it is safe to make multiple subscriptions from the same topic here:
   https://github.com/apache/camel/blob/166d1e6fc4a4f0d188b4b7fdbe4a2d4c1f83f35d/components/camel-nats/src/main/java/org/apache/camel/component/nats/NatsConsumer.java#L136
   
   Or is there something else that needs to be changed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org