[jira] Resolved: (PLUTO-151) New class hierarchy to implement portlet request and response, and resolve the dispatching parameters problem.

["ZHENG Zhong (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/PLUTO-151?page=all ]
     
ZHENG Zhong resolved PLUTO-151:
-------------------------------

    Resolution: Fixed

Done.

> New class hierarchy to implement portlet request and response, and resolve the dispatching parameters problem.
> --------------------------------------------------------------------------------------------------------------
>
>          Key: PLUTO-151
>          URL: http://issues.apache.org/jira/browse/PLUTO-151
>      Project: Pluto
>         Type: Improvement
>   Components: portlet container
>     Versions: 1.1.0-alpha1
>     Reporter: @deprecated ZHENG Zhong
>     Assignee: ZHENG Zhong
>      Fix For: 1.1.0
>  Attachments: pluto-container-core-modif.zip, svndiff-container-core.zip
>
> I made some changes in the org.apache.pluto.core and org.apache.pluto.core.impl packages to implement the new hierarchy and resolve the PortletRequestDispatcher problem (I think this problem may be resolved in a better way). Here is a summary of all the changes I made:
> InternalActionRequest and InternalRenderRequest both extends interface InternalPortletRequest. Methods setIncluded() and isIncluded() are moved to InternalRenderRequest. New method setAppendedParams() is added (request parameters are only appended when we do a dispatching, like the included flag, so i think it will be better to put the included methods and the appended parameters method together).
> PortletRequestImpl is updated to remove all included-related methods. It does no longer check the included flag (because it does no longer have that flag). RenderRequestImpl is updated to implement the setIncluded() , isIncluded() and addAppendedParams() methods. It also checks the included flag to behave differently by overwriting its parent's method (like getContentType(), getContentLength() , getParameterMap(), etc.)
> The same thing also happens to InternalPortletResponse, InternalActionResponse, InternalRenderResponse, PortletResponseImpl, ActionResponseImpl and RenderResponseImpl.
> PortletRequestDispatcherImpl is updated. Now it does not need to create IncludedRenderRequestImpl any more (that class may be deleted since all its functionalities are integrated in the RenderRequestImpl class). Instead, it uses the InternalRenderRequest interface and add appended parameters to it.
> For the InternalPortletRequest interface, methods getPortletContainer() and getHttpServletRequest() do not need to be declared. They will never be called.
> Some other changes include:
> In class PortletRequestImpl, method getWindow() is removed since it is a duplicate method of getInternalPortletWindow().
> Added some javadocs, and some @see tags.
> I rebuilt Pluto with all the changes above, and then tested all the testsuite. They all work well (except the last test in the left portlet. It fails just because resource bundle is not defined in portlet.xml for it.)
> Regards
> ZHENG Zhong

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira