[GitHub] [superset] eric-briscoe commented on a diff in pull request #20809: feat: Create Chart onClick Functionality

[GitBox <gi...@apache.org>]

eric-briscoe commented on code in PR #20809:
URL: https://github.com/apache/superset/pull/20809#discussion_r926913431


##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -213,6 +219,28 @@ export default class ResultSet extends React.PureComponent<
     }
   }
 
+  async createExploreResultsOnClick() {
+    const { results } = this.props.query;
+    // There is currently redux / state issue where sometimes a query will have serverId

Review Comment:
   This comment is probably no longer relevant - did you encounter this issue at all in this workflow?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org