You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/08/02 09:11:43 UTC
[GitHub] flink pull request #4458: [FLINK-7348] [checkstyle] Allow redundant modifier...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4458
[FLINK-7348] [checkstyle] Allow redundant modifiers on methods / reve…
## What is the purpose of the change
Modify checkstyle rules to allow redundant modifiers, specifically to allow final methods in final classes to ensure they remain final even if the class is made non-final as a means of optimization.
## Brief change log
- exclude `METHOD_DEF` from `RedundantModifier` checkstyle module
- revert removals of final modifier on methods made due to this rule
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7348
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4458.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4458
----
commit 9bd4b6647c527e57169f69185527dd56c178f3aa
Author: zentol <ch...@apache.org>
Date: 2017-08-02T09:08:20Z
[FLINK-7348] [checkstyle] Allow redundant modifiers on methods / revert removal of final modifier
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4458: [FLINK-7348] [checkstyle] Allow redundant modifiers on me...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4458
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4458: [FLINK-7348] [checkstyle] Allow redundant modifiers on me...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4458
We can't do it just for final modifiers unfortunately. We _could_ look into creating a custom checkstyle rule based on `https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/checks/modifier/RedundantModifierCheck.java` with minor modifications.
This should be rather straight-forward.
That said, i think that it is unlikely that these modifiers would be removed by some auto-formatting, so they will neither clutter up diffs nor cause any functional problems (because well, they're _redundant_ after all). We could just keep them...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4458: [FLINK-7348] [checkstyle] Allow redundant modifier...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4458: [FLINK-7348] [checkstyle] Allow redundant modifiers on me...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4458
Thanks for picking this up quickly.
I assume there is no way to make this only about `final` modifiers?
We could also approach this by doing selective exclusions of classes (like the Memory Segments) where the rule fires, but we want to retain the identifiers. There should not be too many, final methods in final classes are a very selective thing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---