You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/10/20 12:47:22 UTC

Review Request 26920: Slider app's Quick Links combobox contains repetitive items

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26920/
-----------------------------------------------------------

Review request for Ambari, Andriy Babiichuk, Aleksandr Kovalenko, and Andrii Tkach.


Bugs: AMBARI-7853
    https://issues.apache.org/jira/browse/AMBARI-7853


Repository: ambari


Description
-------

Steps:
# Create Slider view and go to it.
# Add some apps (were used HBASE).
# Stop and destroy some (not all apps).
# Go to leaving app and open Quick Links combobox.

Result: Quick Links combobox contains repetitive items 


Diffs
-----

  contrib/views/slider/src/main/resources/ui/app/controllers/slider_app_controller.js 15792ef 
  contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_app_controller_test.js c022d24 

Diff: https://reviews.apache.org/r/26920/diff/


Testing
-------

Tests completed in 7140 milliseconds.
124 assertions of 124 passed, 0 failed.


Thanks,

Oleg Nechiporenko


Re: Review Request 26920: Slider app's Quick Links combobox contains repetitive items

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26920/#review57312
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Жов. 20, 2014, 10:47 до полудня, Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26920/
> -----------------------------------------------------------
> 
> (Updated Жов. 20, 2014, 10:47 до полудня)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Aleksandr Kovalenko, and Andrii Tkach.
> 
> 
> Bugs: AMBARI-7853
>     https://issues.apache.org/jira/browse/AMBARI-7853
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Steps:
> # Create Slider view and go to it.
> # Add some apps (were used HBASE).
> # Stop and destroy some (not all apps).
> # Go to leaving app and open Quick Links combobox.
> 
> Result: Quick Links combobox contains repetitive items 
> 
> 
> Diffs
> -----
> 
>   contrib/views/slider/src/main/resources/ui/app/controllers/slider_app_controller.js 15792ef 
>   contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_app_controller_test.js c022d24 
> 
> Diff: https://reviews.apache.org/r/26920/diff/
> 
> 
> Testing
> -------
> 
> Tests completed in 7140 milliseconds.
> 124 assertions of 124 passed, 0 failed.
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>


Re: Review Request 26920: Slider app's Quick Links combobox contains repetitive items

Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26920/#review57311
-----------------------------------------------------------

Ship it!


Ship It!

- Andriy Babiichuk


On Окт. 20, 2014, 10:47 д.п., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26920/
> -----------------------------------------------------------
> 
> (Updated Окт. 20, 2014, 10:47 д.п.)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Aleksandr Kovalenko, and Andrii Tkach.
> 
> 
> Bugs: AMBARI-7853
>     https://issues.apache.org/jira/browse/AMBARI-7853
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Steps:
> # Create Slider view and go to it.
> # Add some apps (were used HBASE).
> # Stop and destroy some (not all apps).
> # Go to leaving app and open Quick Links combobox.
> 
> Result: Quick Links combobox contains repetitive items 
> 
> 
> Diffs
> -----
> 
>   contrib/views/slider/src/main/resources/ui/app/controllers/slider_app_controller.js 15792ef 
>   contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_app_controller_test.js c022d24 
> 
> Diff: https://reviews.apache.org/r/26920/diff/
> 
> 
> Testing
> -------
> 
> Tests completed in 7140 milliseconds.
> 124 assertions of 124 passed, 0 failed.
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>