You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "maulin-vasavada (via GitHub)" <gi...@apache.org> on 2023/03/16 21:00:38 UTC

[GitHub] [cassandra] maulin-vasavada opened a new pull request, #2225: CASSANDRA-18124 Make keystore_password nullable

maulin-vasavada opened a new pull request, #2225:
URL: https://github.com/apache/cassandra/pull/2225

   Thanks for sending a pull request! Here are some tips if you're new here:
    
    * Ensure you have added or run the [appropriate tests](https://cassandra.apache.org/_/development/testing.html) for your PR.
    * Be sure to keep the PR description updated to reflect all changes.
    * Write your PR title to summarize what this PR proposes.
    * If possible, provide a concise example to reproduce the issue for a faster review.
    * Read our [contributor guidelines](https://cassandra.apache.org/_/development/index.html)
    * If you're making a documentation change, see our [guide to documentation contribution](https://cassandra.apache.org/_/development/documentation.html)
    
   Commit messages should follow the following format:
   
   ```
   <One sentence description, usually Jira title or CHANGES.txt summary>
   
   <Optional lengthier description (context on patch)>
   
   patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####
   
   Co-authored-by: Name1 <email1>
   Co-authored-by: Name2 <email2>
   
   ```
   
   The [Cassandra Jira](https://issues.apache.org/jira/projects/CASSANDRA/issues/)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] maulin-vasavada commented on pull request #2225: CASSANDRA-18124 Make keystore_password nullable

Posted by "maulin-vasavada (via GitHub)" <gi...@apache.org>.
maulin-vasavada commented on PR #2225:
URL: https://github.com/apache/cassandra/pull/2225#issuecomment-1489129584

   Will close this PR and raise another one with formatting fixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] rtib commented on pull request #2225: CASSANDRA-18124 Make keystore_password nullable

Posted by "rtib (via GitHub)" <gi...@apache.org>.
rtib commented on PR #2225:
URL: https://github.com/apache/cassandra/pull/2225#issuecomment-1480724258

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2225: CASSANDRA-18124 Make keystore_password nullable

Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2225:
URL: https://github.com/apache/cassandra/pull/2225#discussion_r1146948662


##########
examples/ssl-factory/src/org/apache/cassandra/security/KubernetesSecretsPEMSslContextFactory.java:
##########
@@ -181,4 +183,4 @@ protected TrustManagerFactory buildTrustManagerFactory() throws SSLException
         String PRIVATE_KEY_PASSWORD_ENV_VAR = "PRIVATE_KEY_PASSWORD_ENV_VAR";
         String TRUSTED_CERTIFICATE_ENV_VAR = "TRUSTED_CERTIFICATE_ENV_VAR";
     }
-}
+}

Review Comment:
   can you please check your settings and change this? this happens in every class you touched.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2225: CASSANDRA-18124 Make keystore_password nullable

Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2225:
URL: https://github.com/apache/cassandra/pull/2225#discussion_r1146947937


##########
examples/ssl-factory/src/org/apache/cassandra/security/KubernetesSecretsPEMSslContextFactory.java:
##########
@@ -135,12 +137,12 @@ public KubernetesSecretsPEMSslContextFactory(Map<String, Object> parameters)
         super(parameters);
 
         pemEncodedKey = getValueFromEnv(getString(PEMConfigKey.PRIVATE_KEY_ENV_VAR, DEFAULT_PRIVATE_KEY_ENV_VAR_NAME),
-                                        DEFAULT_PRIVATE_KEY);

Review Comment:
   there are all these instances of changed formatting, can we return it back as it was? it happens in the below class too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] maulin-vasavada commented on a diff in pull request #2225: CASSANDRA-18124 Make keystore_password nullable

Posted by "maulin-vasavada (via GitHub)" <gi...@apache.org>.
maulin-vasavada commented on code in PR #2225:
URL: https://github.com/apache/cassandra/pull/2225#discussion_r1146968989


##########
examples/ssl-factory/src/org/apache/cassandra/security/KubernetesSecretsPEMSslContextFactory.java:
##########
@@ -135,12 +137,12 @@ public KubernetesSecretsPEMSslContextFactory(Map<String, Object> parameters)
         super(parameters);
 
         pemEncodedKey = getValueFromEnv(getString(PEMConfigKey.PRIVATE_KEY_ENV_VAR, DEFAULT_PRIVATE_KEY_ENV_VAR_NAME),
-                                        DEFAULT_PRIVATE_KEY);

Review Comment:
   ack. I seem to have the settings issue again. Let me see. I did run ant generate-idea-files before I started to make changes. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] smiklosovic commented on a diff in pull request #2225: CASSANDRA-18124 Make keystore_password nullable

Posted by "smiklosovic (via GitHub)" <gi...@apache.org>.
smiklosovic commented on code in PR #2225:
URL: https://github.com/apache/cassandra/pull/2225#discussion_r1146947937


##########
examples/ssl-factory/src/org/apache/cassandra/security/KubernetesSecretsPEMSslContextFactory.java:
##########
@@ -135,12 +137,12 @@ public KubernetesSecretsPEMSslContextFactory(Map<String, Object> parameters)
         super(parameters);
 
         pemEncodedKey = getValueFromEnv(getString(PEMConfigKey.PRIVATE_KEY_ENV_VAR, DEFAULT_PRIVATE_KEY_ENV_VAR_NAME),
-                                        DEFAULT_PRIVATE_KEY);

Review Comment:
   @maulin-vasavada  there are all these instances of changed formatting, can we return it back as it was? it happens in the below class too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org

[GitHub] [cassandra] maulin-vasavada closed pull request #2225: CASSANDRA-18124 Make keystore_password nullable

Posted by "maulin-vasavada (via GitHub)" <gi...@apache.org>.
maulin-vasavada closed pull request #2225: CASSANDRA-18124 Make keystore_password nullable
URL: https://github.com/apache/cassandra/pull/2225


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org