[GitHub] [hbase] virajjasani commented on a change in pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #2846:
URL: https://github.com/apache/hbase/pull/2846#discussion_r552405945



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1233,9 +1233,8 @@ public void moveServers(Set<Address> servers, String targetGroupName) throws IOE
       Address firstServer = servers.iterator().next();
       RSGroupInfo srcGrp = getRSGroupOfServer(firstServer);
       if (srcGrp == null) {
-        // Be careful. This exception message is tested for in TestRSGroupsBase...
-        throw new ConstraintException("Source RSGroup for server " + firstServer
-            + " does not exist.");
+        // Be careful. This exception message is tested for in TestRSGroupAdmin2...
+        throw new ConstraintException("Server " + firstServer + " does not exist or offline.");

Review comment:
       How about
   ```
   "Server " + firstServer + " is either offline or it does not exist."
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org