You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Stefan Seifert (JIRA)" <ji...@apache.org> on 2009/02/28 19:58:12 UTC
[jira] Created: (SLING-876) maven-sling-plugin ignores targetPath
on resource path checking
maven-sling-plugin ignores targetPath on resource path checking
---------------------------------------------------------------
Key: SLING-876
URL: https://issues.apache.org/jira/browse/SLING-876
Project: Sling
Issue Type: Bug
Components: Maven Plugins
Affects Versions: Maven Sling Plugin 2.0.2, Maven Sling Plugin 2.0.4
Reporter: Stefan Seifert
Fix For: Maven Sling Plugin 2.0.4
Attachments: targetpath-patch.patch
the sling plugins configures and checks initial content path mappings in method AbstractBundleInstallMojo.configure.
this does work fine with maven default mapping.
but if the project pom defines a special resource mapping with target path like this:
<resources>
<!-- copy webapp resources to SLING-INF/content/apps/${project.name} -->
<resource>
<directory>src/main/webapp</directory>
<targetPath>SLING-INF/content/apps/${project.name}</targetPath>
<filtering>false</filtering>
</resource>
</resources>
this does not work any longer, because the target path is ignored and the wrong path is checked.
the patch attached solves the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SLING-876) maven-sling-plugin ignores targetPath
on resource path checking
Posted by "Stefan Seifert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Seifert updated SLING-876:
---------------------------------
Attachment: targetpath-patch.patch
> maven-sling-plugin ignores targetPath on resource path checking
> ---------------------------------------------------------------
>
> Key: SLING-876
> URL: https://issues.apache.org/jira/browse/SLING-876
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins
> Affects Versions: Maven Sling Plugin 2.0.2, Maven Sling Plugin 2.0.4
> Reporter: Stefan Seifert
> Fix For: Maven Sling Plugin 2.0.4
>
> Attachments: targetpath-patch.patch
>
>
> the sling plugins configures and checks initial content path mappings in method AbstractBundleInstallMojo.configure.
> this does work fine with maven default mapping.
> but if the project pom defines a special resource mapping with target path like this:
> <resources>
> <!-- copy webapp resources to SLING-INF/content/apps/${project.name} -->
> <resource>
> <directory>src/main/webapp</directory>
> <targetPath>SLING-INF/content/apps/${project.name}</targetPath>
> <filtering>false</filtering>
> </resource>
> </resources>
> this does not work any longer, because the target path is ignored and the wrong path is checked.
> the patch attached solves the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-876) maven-sling-plugin ignores targetPath on
resource path checking
Posted by "Stefan Seifert (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Seifert closed SLING-876.
--------------------------------
works as intended - thanks for applying and enhancing.
> maven-sling-plugin ignores targetPath on resource path checking
> ---------------------------------------------------------------
>
> Key: SLING-876
> URL: https://issues.apache.org/jira/browse/SLING-876
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins
> Affects Versions: Maven Sling Plugin 2.0.2, Maven Sling Plugin 2.0.4
> Reporter: Stefan Seifert
> Fix For: Maven Sling Plugin 2.0.4
>
> Attachments: targetpath-patch.patch
>
>
> the sling plugins configures and checks initial content path mappings in method AbstractBundleInstallMojo.configure.
> this does work fine with maven default mapping.
> but if the project pom defines a special resource mapping with target path like this:
> <resources>
> <!-- copy webapp resources to SLING-INF/content/apps/${project.name} -->
> <resource>
> <directory>src/main/webapp</directory>
> <targetPath>SLING-INF/content/apps/${project.name}</targetPath>
> <filtering>false</filtering>
> </resource>
> </resources>
> this does not work any longer, because the target path is ignored and the wrong path is checked.
> the patch attached solves the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-876) maven-sling-plugin ignores targetPath
on resource path checking
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-876.
------------------------------------
Resolution: Fixed
Hi Stefan,
in revision 759467 I've committed a slightly modified patch which checks for a trailing "/" after the target path. Can you please cross check and then close this bug?
Thanks
> maven-sling-plugin ignores targetPath on resource path checking
> ---------------------------------------------------------------
>
> Key: SLING-876
> URL: https://issues.apache.org/jira/browse/SLING-876
> Project: Sling
> Issue Type: Bug
> Components: Maven Plugins
> Affects Versions: Maven Sling Plugin 2.0.2, Maven Sling Plugin 2.0.4
> Reporter: Stefan Seifert
> Fix For: Maven Sling Plugin 2.0.4
>
> Attachments: targetpath-patch.patch
>
>
> the sling plugins configures and checks initial content path mappings in method AbstractBundleInstallMojo.configure.
> this does work fine with maven default mapping.
> but if the project pom defines a special resource mapping with target path like this:
> <resources>
> <!-- copy webapp resources to SLING-INF/content/apps/${project.name} -->
> <resource>
> <directory>src/main/webapp</directory>
> <targetPath>SLING-INF/content/apps/${project.name}</targetPath>
> <filtering>false</filtering>
> </resource>
> </resources>
> this does not work any longer, because the target path is ignored and the wrong path is checked.
> the patch attached solves the problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.