[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3950: Fix the batch metadata in-consistent issue on open batch session failure

[GitBox <gi...@apache.org>]

turboFei commented on code in PR #3950:
URL: https://github.com/apache/incubator-kyuubi/pull/3950#discussion_r1043430452


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSessionImpl.scala:
##########
@@ -113,6 +113,11 @@ class KyuubiBatchSessionImpl(
       ms.incCount(MetricRegistry.name(CONN_OPEN, user))
     }
 
+    // have to add batchJobSubmissionOp into session opHandleSet here, to update the batch metadata
+    // on openSession failure(may be open session for recovery), otherwise, the batch metadata state
+    // might lose control.
+    opHandleSet.add(batchJobSubmissionOp.getHandle)

Review Comment:
   it might fail before `runOperation(batchJobSubmissionOp)` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org