[GitHub] [arrow] wjones127 commented on a diff in pull request #13851: ARROW-14999: [C++] Don't check field name in ListType Equals()

[GitBox <gi...@apache.org>]

wjones127 commented on code in PR #13851:
URL: https://github.com/apache/arrow/pull/13851#discussion_r1008418347


##########
cpp/src/arrow/type.cc:
##########
@@ -2093,17 +2101,33 @@ std::string DictionaryType::ComputeFingerprint() const {
 }
 
 std::string ListType::ComputeFingerprint() const {
-  const auto& child_fingerprint = children_[0]->fingerprint();
+  const auto& child_fingerprint = value_type()->fingerprint();
   if (!child_fingerprint.empty()) {
-    return TypeIdFingerprint(*this) + "{" + child_fingerprint + "}";
+    std::stringstream ss;
+    ss << TypeIdFingerprint(*this);
+    if (value_field()->nullable()) {
+      ss << 'n';
+    } else {
+      ss << 'N';
+    }

Review Comment:
   nullability of internal field is now part of the fingerprint.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org