You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2020/07/18 03:17:56 UTC
[shardingsphere-elasticjob] branch master updated: Revise #1106
(#1122)
This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob.git
The following commit(s) were added to refs/heads/master by this push:
new 8530ee6 Revise #1106 (#1122)
8530ee6 is described below
commit 8530ee631daefd30d68249487f3bb17157169bc7
Author: Liang Zhang <te...@163.com>
AuthorDate: Sat Jul 18 11:17:48 2020 +0800
Revise #1106 (#1122)
* Rename JobClassNameProviderFactory.DEFAULT_STRATEGY to DEFAULT_PROVIDER
* Revise javadoc
---
.../elasticjob/lite/internal/setup/JobClassNameProviderFactory.java | 4 ++--
.../elasticjob/lite/internal/setup/SimpleJobClassNameProvider.java | 2 +-
.../lite/spring/setup/SpringProxyJobClassNameProvider.java | 5 +++--
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/JobClassNameProviderFactory.java b/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/JobClassNameProviderFactory.java
index 8f5c440..6bd3d1c 100644
--- a/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/JobClassNameProviderFactory.java
+++ b/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/JobClassNameProviderFactory.java
@@ -32,7 +32,7 @@ public final class JobClassNameProviderFactory {
private static final List<JobClassNameProvider> PROVIDERS = new LinkedList<>();
- private static final JobClassNameProvider DEFAULT_STRATEGY = new SimpleJobClassNameProvider();
+ private static final JobClassNameProvider DEFAULT_PROVIDER = new SimpleJobClassNameProvider();
static {
for (JobClassNameProvider each : ServiceLoader.load(JobClassNameProvider.class)) {
@@ -46,6 +46,6 @@ public final class JobClassNameProviderFactory {
* @return job class name provider
*/
public static JobClassNameProvider getProvider() {
- return PROVIDERS.isEmpty() ? DEFAULT_STRATEGY : PROVIDERS.get(0);
+ return PROVIDERS.isEmpty() ? DEFAULT_PROVIDER : PROVIDERS.get(0);
}
}
diff --git a/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/SimpleJobClassNameProvider.java b/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/SimpleJobClassNameProvider.java
index 928018a..4117be6 100644
--- a/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/SimpleJobClassNameProvider.java
+++ b/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/SimpleJobClassNameProvider.java
@@ -20,7 +20,7 @@ package org.apache.shardingsphere.elasticjob.lite.internal.setup;
import org.apache.shardingsphere.elasticjob.api.ElasticJob;
/**
- * Simple provider for get job class name.
+ * Simple job class name provider.
*/
public final class SimpleJobClassNameProvider implements JobClassNameProvider {
diff --git a/elasticjob-lite/elasticjob-lite-spring/src/main/java/org/apache/shardingsphere/elasticjob/lite/spring/setup/SpringProxyJobClassNameProvider.java b/elasticjob-lite/elasticjob-lite-spring/src/main/java/org/apache/shardingsphere/elasticjob/lite/spring/setup/SpringProxyJobClassNameProvider.java
index 8307912..12d089f 100644
--- a/elasticjob-lite/elasticjob-lite-spring/src/main/java/org/apache/shardingsphere/elasticjob/lite/spring/setup/SpringProxyJobClassNameProvider.java
+++ b/elasticjob-lite/elasticjob-lite-spring/src/main/java/org/apache/shardingsphere/elasticjob/lite/spring/setup/SpringProxyJobClassNameProvider.java
@@ -23,13 +23,14 @@ import org.apache.shardingsphere.elasticjob.lite.spring.job.util.AopTargetUtils;
import org.springframework.aop.support.AopUtils;
/**
- * Provider for get job class name.
+ * Spring job class name provider.
+ *
* <p>
* Consider the proxy object that generated by cglib or jdk dynamic proxy.
* </p>
*/
public final class SpringProxyJobClassNameProvider implements JobClassNameProvider {
-
+
@Override
public String getJobClassName(final ElasticJob elasticJob) {
return AopUtils.isAopProxy(elasticJob) ? AopTargetUtils.getTarget(elasticJob).getClass().getName() : elasticJob.getClass().getName();