[jira] [Commented] (THRIFT-2775) static assert fails in src/thrift/internal/ctfe.d

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14165539#comment-14165539 ] 

Jens Geyer commented on THRIFT-2775:
------------------------------------

Thanks for the patch. The big question is, however, what is the intention of that test? Is it ok to patch it that way, or should the function being tested be modified? 

> static assert fails in src/thrift/internal/ctfe.d
> -------------------------------------------------
>
>                 Key: THRIFT-2775
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2775
>             Project: Thrift
>          Issue Type: Bug
>          Components: D - Library
>    Affects Versions: 0.9.2
>         Environment: openSUSE 13.1 (i586)  
> DMD Compiler v2.066.0 
> german locale
>            Reporter: Jens Geyer
>         Attachments: THRIFT-2775_ctfe_assert_fail.patch
>
>
> make check in d/lib fails with 
> {code}
> src/thrift/internal/ctfe.d(94): Error: static assert  (ctfeToString(3.1415) == "3.1415") is false
> {code}
> because ctfeToString(3.1415) evaluates to "3.14149999999999"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)