You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "cambyzju (via GitHub)" <gi...@apache.org> on 2024/03/05 11:22:56 UTC

[PR] [fix](cast) fix wrong result while cast string to float (#31781) [doris]

cambyzju opened a new pull request, #31813:
URL: https://github.com/apache/doris/pull/31813

   Issue Number: close #31518
   
   cherry-pick #31781 to 2.0
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cast) fix wrong result while cast string to float (#31781) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31813:
URL: https://github.com/apache/doris/pull/31813#issuecomment-1978614298

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 31.38 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 548647768f5ec420227a707496f0cd10e1df93fd, data reload: false
   
   query1	0.03	0.03	0.02
   query2	0.07	0.02	0.02
   query3	0.25	0.04	0.05
   query4	1.79	0.07	0.07
   query5	0.53	0.53	0.52
   query6	1.34	0.61	0.65
   query7	0.01	0.01	0.01
   query8	0.04	0.02	0.02
   query9	0.52	0.48	0.48
   query10	0.54	0.53	0.55
   query11	0.12	0.08	0.08
   query12	0.11	0.09	0.09
   query13	0.62	0.60	0.61
   query14	0.79	0.80	0.77
   query15	0.78	0.75	0.77
   query16	0.37	0.37	0.37
   query17	1.01	1.00	1.02
   query18	0.22	0.26	0.25
   query19	1.91	1.88	1.85
   query20	0.01	0.01	0.01
   query21	15.45	0.59	0.56
   query22	2.05	2.20	1.78
   query23	16.96	1.04	0.92
   query24	4.65	1.66	1.44
   query25	0.29	0.14	0.05
   query26	0.62	0.17	0.17
   query27	0.04	0.04	0.03
   query28	7.81	0.76	0.73
   query29	12.60	2.29	2.32
   query30	0.59	0.52	0.53
   query31	2.81	0.38	0.37
   query32	3.36	0.49	0.50
   query33	3.11	3.05	3.11
   query34	15.24	4.81	4.79
   query35	4.90	4.86	4.86
   query36	1.04	1.00	1.02
   query37	0.06	0.04	0.05
   query38	0.04	0.03	0.02
   query39	0.02	0.01	0.01
   query40	0.16	0.14	0.14
   query41	0.07	0.02	0.01
   query42	0.02	0.02	0.01
   query43	0.02	0.02	0.01
   Total cold run time: 102.97 s
   Total hot run time: 31.38 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cast) fix wrong result while cast string to float (#31781) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31813:
URL: https://github.com/apache/doris/pull/31813#issuecomment-1978537651

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cast) fix wrong result while cast string to float (#31781) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31813:
URL: https://github.com/apache/doris/pull/31813#issuecomment-1978603366

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 202538 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 548647768f5ec420227a707496f0cd10e1df93fd, data reload: false
   
   query1	919	391	376	376
   query2	6513	2292	2292	2292
   query3	6912	202	206	202
   query4	20914	17965	17984	17965
   query5	19738	6466	6513	6466
   query6	302	219	238	219
   query7	4153	293	290	290
   query8	258	232	248	232
   query9	3148	2679	2630	2630
   query10	424	268	266	266
   query11	11349	10678	10689	10678
   query12	119	77	72	72
   query13	5590	645	634	634
   query14	17807	13589	14058	13589
   query15	358	234	237	234
   query16	6451	275	263	263
   query17	1771	1650	891	891
   query18	2340	413	403	403
   query19	203	146	153	146
   query20	81	81	78	78
   query21	192	103	98	98
   query22	5824	5142	5075	5075
   query23	32357	31939	31815	31815
   query24	6873	6468	6460	6460
   query25	528	429	407	407
   query26	487	165	158	158
   query27	1733	295	292	292
   query28	6030	2225	2201	2201
   query29	2950	2849	2744	2744
   query30	242	165	159	159
   query31	880	720	738	720
   query32	64	58	68	58
   query33	400	238	255	238
   query34	834	473	483	473
   query35	1150	962	928	928
   query36	1446	1330	1345	1330
   query37	91	64	62	62
   query38	3052	2905	2864	2864
   query39	1377	1337	1324	1324
   query40	199	96	97	96
   query41	36	32	33	32
   query42	90	86	87	86
   query43	639	616	572	572
   query44	1120	723	717	717
   query45	240	231	227	227
   query46	1235	974	1007	974
   query47	1943	1744	2016	1744
   query48	962	668	666	666
   query49	606	378	360	360
   query50	866	631	629	629
   query51	4743	4647	4580	4580
   query52	87	72	94	72
   query53	443	326	326	326
   query54	2662	2464	2453	2453
   query55	90	77	78	77
   query56	212	209	202	202
   query57	1177	1053	1189	1053
   query58	206	210	209	209
   query59	3394	3259	3119	3119
   query60	209	211	197	197
   query61	86	86	86	86
   query62	740	480	490	480
   query63	463	330	337	330
   query64	2427	1478	1471	1471
   query65	3610	3544	3570	3544
   query66	747	380	366	366
   query67	16535	15563	17597	15563
   query68	7984	636	678	636
   query69	579	352	342	342
   query70	1769	1869	1571	1571
   query71	383	292	304	292
   query72	6452	3479	3440	3440
   query73	742	331	330	330
   query74	6292	5889	5836	5836
   query75	4499	3725	3694	3694
   query76	4696	1152	1193	1152
   query77	545	244	254	244
   query78	12804	11900	11814	11814
   query79	8075	638	647	638
   query80	2133	396	400	396
   query81	533	231	233	231
   query82	1521	100	95	95
   query83	184	136	131	131
   query84	263	69	69	69
   query85	1313	290	276	276
   query86	425	373	344	344
   query87	3242	2995	3008	2995
   query88	4985	2332	2323	2323
   query89	348	272	293	272
   query90	1798	207	200	200
   query91	157	119	119	119
   query92	58	52	51	51
   query93	4698	557	540	540
   query94	893	207	206	206
   query95	1111	1062	1076	1062
   query96	645	327	324	324
   query97	6592	6384	6304	6304
   query98	187	172	181	172
   query99	2941	909	876	876
   Total cold run time: 310474 ms
   Total hot run time: 202538 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cast) fix wrong result while cast string to float (#31781) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31813:
URL: https://github.com/apache/doris/pull/31813#issuecomment-1978581904

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 49995 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 548647768f5ec420227a707496f0cd10e1df93fd, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17587	4401	4367	4367
   q2	2075	151	147	147
   q3	10546	1942	1934	1934
   q4	10329	1231	1331	1231
   q5	8415	3934	3975	3934
   q6	228	124	125	124
   q7	2042	1602	1623	1602
   q8	9270	2715	2723	2715
   q9	11118	10601	10542	10542
   q10	8649	3479	3515	3479
   q11	421	244	246	244
   q12	472	294	300	294
   q13	18354	3975	3995	3975
   q14	344	333	334	333
   q15	499	451	458	451
   q16	682	593	587	587
   q17	1118	938	957	938
   q18	7258	6875	6814	6814
   q19	1655	1517	1484	1484
   q20	537	308	293	293
   q21	4434	4141	4106	4106
   q22	509	405	401	401
   Total cold run time: 116542 ms
   Total hot run time: 49995 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4335	4330	4300	4300
   q2	320	225	219	219
   q3	4174	4127	4103	4103
   q4	2742	2746	2734	2734
   q5	7326	7217	7187	7187
   q6	234	121	121	121
   q7	3185	2876	2824	2824
   q8	4342	4485	4452	4452
   q9	17615	17302	17435	17302
   q10	4238	4228	4265	4228
   q11	758	718	682	682
   q12	1021	862	832	832
   q13	7468	3719	3755	3719
   q14	451	433	422	422
   q15	499	461	467	461
   q16	753	703	706	703
   q17	3924	3824	3862	3824
   q18	8703	8744	8836	8744
   q19	1709	1701	1689	1689
   q20	2390	2188	2122	2122
   q21	8558	8385	8522	8385
   q22	1044	982	946	946
   Total cold run time: 85789 ms
   Total hot run time: 79999 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cast) fix wrong result while cast string to float (#31781) [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31813:
URL: https://github.com/apache/doris/pull/31813#issuecomment-1978622136

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 548647768f5ec420227a707496f0cd10e1df93fd with default session variables
   Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
   Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       21.0 seconds inserted 10000000 Rows, about 476K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cast) fix wrong result while cast string to float (#31781) [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #31813:
URL: https://github.com/apache/doris/pull/31813


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](cast) fix wrong result while cast string to float (#31781) [doris]

Posted by "cambyzju (via GitHub)" <gi...@apache.org>.
cambyzju commented on PR #31813:
URL: https://github.com/apache/doris/pull/31813#issuecomment-1978538424

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org