[jira] Commented: (SOLR-416) need to audit all methods that might be using default Locale

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543924 ] 

Hoss Man commented on SOLR-416:
-------------------------------

FWIW: 'grep -r "toUpper\|toLower" java webapp' shows 32 places where toUpper or toLower are used ... that's probably where we should start trying to fix things ... there may be other equally heinous Locale aware comparisons being done that don't involve these methods.




> need to audit all methods that might be using default Locale
> ------------------------------------------------------------
>
>                 Key: SOLR-416
>                 URL: https://issues.apache.org/jira/browse/SOLR-416
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>
> As discussed on the mailing list, there are places in Solr where java methods that rely on the default locale are used to copare input with "constants" ... the specific use case that prompted this bug being string comparison after calling "toUpperCase()" ... this won't do what it should in some Locales...
> http://www.nabble.com/Invalid-value-%27explicit%27-for-echoParams-parameter-tf4837914.html
> we should audit the code as much as possible and try to replace these use cases in a way that will work for everyone....

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.