[GitHub] sijie commented on a change in pull request #1937: [bk-gc] Fix GC thread gets blocked

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1937: [bk-gc] Fix GC thread gets blocked
URL: https://github.com/apache/bookkeeper/pull/1937#discussion_r254512414
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java
 ##########
 @@ -103,7 +103,8 @@ private synchronized void preload() throws IOException {
 
                 try {
                     zkActiveLedgers = ledgerListToSet(
-                            ZkUtils.getChildrenInSingleNode(zk, ledgerRootPath), ledgerRootPath);
+                            ZkUtils.getChildrenInSingleNode(zk, ledgerRootPath, ZkUtils.OP_TIME_OUT_SEC),
 
 Review comment:
   +1 to what @athanatos suggested. I would like to see a setting configurable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services