You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2026/08/15 11:43:31 UTC
[PR] config cleanup [cloudstack]
DaanHoogland opened a new pull request, #13884:
URL: https://github.com/apache/cloudstack/pull/13884
### Description
This PR tries to get rid of the Config enum or the old mechanism to define configuration items, which is long overdue. The change should be transparent, but is huge so good regression testing is required. And merg early in the release cycle is recommended.
Commits are being done in batches for review convenience. They could have been done in separate PRs but in the end the changes are rather trivial.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
Fixes: #10752
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] Build/CI
- [ ] Test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5550911656
<b>[SF] Trillian test result (tid-16906)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 61344 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16906-kvm-ol8.zip
Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#discussion_r3917368696
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java:
##########
@@ -398,7 +396,7 @@ public void copyAsync(DataObject srcdata, DataObject destData, AsyncCompletionCa
(srcdata.getType() == DataObjectType.SNAPSHOT && destData.getType() == DataObjectType.SNAPSHOT) ||
(srcdata.getType() == DataObjectType.VOLUME && destData.getType() == DataObjectType.VOLUME)) {
- int nMaxExecutionMinutes = NumbersUtil.parseInt(configDao.getValue(Config.SecStorageCmdExecutionTimeMax.key()), 30);
+ int nMaxExecutionMinutes = AgentManager.SecStorageCmdExecutionTimeMax.value();
Review Comment:
`AgentManager` is referenced here but the file no longer imports it (it removed the old `Config` import). This will not compile unless `AgentManager` is imported or the reference is fully qualified.
##########
usage/src/main/java/com/cloud/usage/UsageManagerImpl.java:
##########
@@ -229,16 +230,16 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
throw new CloudRuntimeException("Unhandled configuration exception", e);
}
- String execTime = configs.get("usage.stats.job.exec.time");
- String aggregationRange = configs.get("usage.stats.job.aggregation.range");
- String execTimeZone = configs.get("usage.execution.timezone");
- String aggregationTimeZone = configs.get("usage.aggregation.timezone");
- String sanityCheckInterval = configs.get("usage.sanity.check.interval");
+ String execTime = UsageService.UsageStatsJobExecTime.value();
+ Integer aggregationRange = UsageService.UsageStatsJobAggregationRange.value();
+ String execTimeZone = UsageService.UsageExecutionTimezone.value();
+ String aggregationTimeZone = UsageService.UsageAggregationTimezone.value();
+ Integer sanityCheckInterval = UsageService.UsageSanityCheckInterval.value();
Review Comment:
`configure()` still builds/merges the `configs` map (including `params` overrides) but the usage-job settings are now read via `ConfigKey.value()`, which ignores the merged `configs`/`params`. This changes behavior vs. the previous implementation and makes overrides passed via `params` ineffective. Consider reading from `configs` first (falling back to the `ConfigKey` default/global value) so `mergeConfigs(configs, params)` remains meaningful for these settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5385404609
<b>[SF] Trillian Build Failed (tid-16808)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#discussion_r3790460092
##########
server/src/main/java/com/cloud/server/ManagementServer.java:
##########
@@ -31,6 +36,166 @@
*/
public interface ManagementServer extends ManagementService, PluggableService {
+ ConfigKey<String> customCsIdentifier = new ConfigKey<>("Advanced", String.class, "custom.cs.identifier",
+ UUID.randomUUID().toString().split("-")[0].substring(4), "Custom identifier for the cloudstack installation", true, ConfigKey.Scope.Global);
+
+ ConfigKey<Boolean> exposeCloudStackVersionInApiXmlResponse = new ConfigKey<>("Advanced", Boolean.class, "expose.cloudstack.version.api.xml.response", "true",
+ "Indicates whether ACS version should appear in the root element of an API XML response.", true, ConfigKey.Scope.Global);
+
+ ConfigKey<String> ElasticLoadBalancerEnabled = new ConfigKey<>("Advanced", String.class, "network.loadbalancer.basiczone.elb.enabled", "false",
+ "Whether the load balancing service is enabled for basic zones", true);
+
+ ConfigKey<String> ElasticLoadBalancerNetwork = new ConfigKey<>("Advanced", String.class, "network.loadbalancer.basiczone.elb.network", "guest",
+ "Whether the elastic load balancing service public ips are taken from the public or guest network", true);
+
+ ConfigKey<Boolean> ApiLimitEnabled = new ConfigKey<>("Advanced", Boolean.class, "api.throttling.enabled", "false", "Enable/disable Api rate limit", true);
+
+ ConfigKey<Integer> ApiLimitInterval = new ConfigKey<>("Advanced", Integer.class, "api.throttling.interval", "1", "Time interval (in seconds) to reset API count", true);
+
+ ConfigKey<Integer> ApiLimitMax = new ConfigKey<>("Advanced", Integer.class, "api.throttling.max", "25", "Max allowed number of APIs within fixed interval", true);
+
+ ConfigKey<String> OvmPublicNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm.public.network.device", null,
+ "Specify the public bridge on host for public network", true);
+
+ ConfigKey<String> OvmPrivateNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm.private.network.device", null,
+ "Specify the private bridge on host for private network", true);
+
+ ConfigKey<String> OvmGuestNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm.guest.network.device", null,
+ "Specify the private bridge on host for private network", true);
+
+ ConfigKey<String> Ovm3PublicNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm3.public.network.device", null,
+ "Specify the public bridge on host for public network", true);
+
+ ConfigKey<String> Ovm3PrivateNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm3.private.network.device", null,
+ "Specify the private bridge on host for private network", true);
+
+ ConfigKey<String> Ovm3GuestNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm3.guest.network.device", null,
+ "Specify the guest bridge on host for guest network", true);
+
+ ConfigKey<String> Ovm3StorageNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm3.storage.network.device", null,
+ "Specify the storage bridge on host for storage network", true);
+
+ ConfigKey<String> KvmPublicNetwork = new ConfigKey<>("Hidden", String.class,
+ "kvm.public.network.device", null,
+ "Specify the public bridge on host for public network", true);
+
+ ConfigKey<String> KvmPrivateNetwork = new ConfigKey<>("Hidden", String.class,
+ "kvm.private.network.device", null,
+ "Specify the private bridge on host for private network", true);
+
+ ConfigKey<String> KvmGuestNetwork = new ConfigKey<>("Hidden", String.class,
+ "kvm.guest.network.device", null,
+ "Specify the private bridge on host for private network", true);
+
+ ConfigKey<Boolean> PublishActionEvent = new ConfigKey<>("Advanced", Boolean.class, "publish.action.events", "true",
+ "enable or disable publishing of action events on the event bus", true);
+
+ ConfigKey<Boolean> PublishAlertEvent = new ConfigKey<>("Advanced", Boolean.class, "publish.alert.events", "true",
+ "enable or disable publishing of alert events on the event bus", true);
+
+ ConfigKey<Boolean> PublishResourceStateEvent = new ConfigKey<>("Advanced", Boolean.class, "publish.resource.state.events", "true",
+ "enable or disable publishing of alert events on the event bus", true);
+
+ ConfigKey<Boolean> PublishUsageEvent = new ConfigKey<>("Advanced", Boolean.class, "publish.usage.events", "true",
+ "enable or disable publishing of usage events on the event bus", true);
+
+ ConfigKey<Integer> EventPurgeInterval = new ConfigKey<>("Advanced", Integer.class, "event.purge.interval", "86400",
+ "The interval (in seconds) to wait before running the event purge thread", true);
+
+ ConfigKey<Integer> LinkLocalIpNums = new ConfigKey<>("Advanced", Integer.class, "linkLocalIp.nums", "10",
+ "The number of link local ip that needed by domR(in power of 2)", true);
+
+ ConfigKey<String> HypervisorList = new ConfigKey<>("Advanced", String.class, "hypervisor.list",
+ HypervisorType.KVM + "," + HypervisorType.VMware + "," + HypervisorType.XenServer + "," + HypervisorType.Hyperv + "," +
+ HypervisorType.BareMetal + "," + HypervisorType.Ovm + "," + HypervisorType.LXC + "," + HypervisorType.Ovm3 + "," + HypervisorType.External,
+ "The list of hypervisors that this deployment will use.", true, ConfigKey.Kind.CSV, null);
+
+ ConfigKey<String> ManagementNetwork = new ConfigKey<>("Advanced", String.class, "management.network.cidr", null,
+ "The cidr of management server network", true);
+
+ ConfigKey<Integer> EventPurgeDelay = new ConfigKey<>("Advanced", Integer.class, "event.purge.delay", "15",
+ "Events older than specified number days will be purged. Set this value to 0 to never delete events", true);
+
+ ConfigKey<Integer> AlertPurgeInterval = new ConfigKey<>("Advanced", Integer.class, "alert.purge.interval", "86400",
+ "The interval (in seconds) to wait before running the alert purge thread", true);
+
+ ConfigKey<Integer> AlertPurgeDelay = new ConfigKey<>("Advanced", Integer.class, "alert.purge.delay", "0",
+ "Alerts older than specified number days will be purged. Set this value to 0 to never delete alerts", true);
+
+ ConfigKey<String> ControlCidr = new ConfigKey<>("Advanced", String.class, "control.cidr", "169.254.0.0/16",
Review Comment:
## SonarCloud / IP addresses should not be hardcoded
<!--SONAR_ISSUE_KEY:AaAHquINRdE24u2TNGQM-->Make sure using this hardcoded IP address is safe here. <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHquINRdE24u2TNGQM&open=AaAHquINRdE24u2TNGQM&pullRequest=13884">SonarQube Cloud</a></p>
[Show more details](https://github.com/apache/cloudstack/security/code-scanning/201)
##########
server/src/main/java/com/cloud/server/ManagementServer.java:
##########
@@ -31,6 +36,166 @@
*/
public interface ManagementServer extends ManagementService, PluggableService {
+ ConfigKey<String> customCsIdentifier = new ConfigKey<>("Advanced", String.class, "custom.cs.identifier",
+ UUID.randomUUID().toString().split("-")[0].substring(4), "Custom identifier for the cloudstack installation", true, ConfigKey.Scope.Global);
+
+ ConfigKey<Boolean> exposeCloudStackVersionInApiXmlResponse = new ConfigKey<>("Advanced", Boolean.class, "expose.cloudstack.version.api.xml.response", "true",
+ "Indicates whether ACS version should appear in the root element of an API XML response.", true, ConfigKey.Scope.Global);
+
+ ConfigKey<String> ElasticLoadBalancerEnabled = new ConfigKey<>("Advanced", String.class, "network.loadbalancer.basiczone.elb.enabled", "false",
+ "Whether the load balancing service is enabled for basic zones", true);
+
+ ConfigKey<String> ElasticLoadBalancerNetwork = new ConfigKey<>("Advanced", String.class, "network.loadbalancer.basiczone.elb.network", "guest",
+ "Whether the elastic load balancing service public ips are taken from the public or guest network", true);
+
+ ConfigKey<Boolean> ApiLimitEnabled = new ConfigKey<>("Advanced", Boolean.class, "api.throttling.enabled", "false", "Enable/disable Api rate limit", true);
+
+ ConfigKey<Integer> ApiLimitInterval = new ConfigKey<>("Advanced", Integer.class, "api.throttling.interval", "1", "Time interval (in seconds) to reset API count", true);
+
+ ConfigKey<Integer> ApiLimitMax = new ConfigKey<>("Advanced", Integer.class, "api.throttling.max", "25", "Max allowed number of APIs within fixed interval", true);
+
+ ConfigKey<String> OvmPublicNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm.public.network.device", null,
+ "Specify the public bridge on host for public network", true);
+
+ ConfigKey<String> OvmPrivateNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm.private.network.device", null,
+ "Specify the private bridge on host for private network", true);
+
+ ConfigKey<String> OvmGuestNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm.guest.network.device", null,
+ "Specify the private bridge on host for private network", true);
+
+ ConfigKey<String> Ovm3PublicNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm3.public.network.device", null,
+ "Specify the public bridge on host for public network", true);
+
+ ConfigKey<String> Ovm3PrivateNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm3.private.network.device", null,
+ "Specify the private bridge on host for private network", true);
+
+ ConfigKey<String> Ovm3GuestNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm3.guest.network.device", null,
+ "Specify the guest bridge on host for guest network", true);
+
+ ConfigKey<String> Ovm3StorageNetwork = new ConfigKey<>("Hidden", String.class,
+ "ovm3.storage.network.device", null,
+ "Specify the storage bridge on host for storage network", true);
+
+ ConfigKey<String> KvmPublicNetwork = new ConfigKey<>("Hidden", String.class,
+ "kvm.public.network.device", null,
+ "Specify the public bridge on host for public network", true);
+
+ ConfigKey<String> KvmPrivateNetwork = new ConfigKey<>("Hidden", String.class,
+ "kvm.private.network.device", null,
+ "Specify the private bridge on host for private network", true);
+
+ ConfigKey<String> KvmGuestNetwork = new ConfigKey<>("Hidden", String.class,
+ "kvm.guest.network.device", null,
+ "Specify the private bridge on host for private network", true);
+
+ ConfigKey<Boolean> PublishActionEvent = new ConfigKey<>("Advanced", Boolean.class, "publish.action.events", "true",
+ "enable or disable publishing of action events on the event bus", true);
+
+ ConfigKey<Boolean> PublishAlertEvent = new ConfigKey<>("Advanced", Boolean.class, "publish.alert.events", "true",
+ "enable or disable publishing of alert events on the event bus", true);
+
+ ConfigKey<Boolean> PublishResourceStateEvent = new ConfigKey<>("Advanced", Boolean.class, "publish.resource.state.events", "true",
+ "enable or disable publishing of alert events on the event bus", true);
+
+ ConfigKey<Boolean> PublishUsageEvent = new ConfigKey<>("Advanced", Boolean.class, "publish.usage.events", "true",
+ "enable or disable publishing of usage events on the event bus", true);
+
+ ConfigKey<Integer> EventPurgeInterval = new ConfigKey<>("Advanced", Integer.class, "event.purge.interval", "86400",
+ "The interval (in seconds) to wait before running the event purge thread", true);
+
+ ConfigKey<Integer> LinkLocalIpNums = new ConfigKey<>("Advanced", Integer.class, "linkLocalIp.nums", "10",
+ "The number of link local ip that needed by domR(in power of 2)", true);
+
+ ConfigKey<String> HypervisorList = new ConfigKey<>("Advanced", String.class, "hypervisor.list",
+ HypervisorType.KVM + "," + HypervisorType.VMware + "," + HypervisorType.XenServer + "," + HypervisorType.Hyperv + "," +
+ HypervisorType.BareMetal + "," + HypervisorType.Ovm + "," + HypervisorType.LXC + "," + HypervisorType.Ovm3 + "," + HypervisorType.External,
+ "The list of hypervisors that this deployment will use.", true, ConfigKey.Kind.CSV, null);
+
+ ConfigKey<String> ManagementNetwork = new ConfigKey<>("Advanced", String.class, "management.network.cidr", null,
+ "The cidr of management server network", true);
+
+ ConfigKey<Integer> EventPurgeDelay = new ConfigKey<>("Advanced", Integer.class, "event.purge.delay", "15",
+ "Events older than specified number days will be purged. Set this value to 0 to never delete events", true);
+
+ ConfigKey<Integer> AlertPurgeInterval = new ConfigKey<>("Advanced", Integer.class, "alert.purge.interval", "86400",
+ "The interval (in seconds) to wait before running the alert purge thread", true);
+
+ ConfigKey<Integer> AlertPurgeDelay = new ConfigKey<>("Advanced", Integer.class, "alert.purge.delay", "0",
+ "Alerts older than specified number days will be purged. Set this value to 0 to never delete alerts", true);
+
+ ConfigKey<String> ControlCidr = new ConfigKey<>("Advanced", String.class, "control.cidr", "169.254.0.0/16",
+ "Changes the cidr for the control network traffic. Defaults to using link local. Must be unique within pods", true);
+
+ ConfigKey<String> ControlGateway = new ConfigKey<>("Advanced", String.class, "control.gateway", "169.254.0.1",
Review Comment:
## SonarCloud / IP addresses should not be hardcoded
<!--SONAR_ISSUE_KEY:AaAHquINRdE24u2TNGQN-->Make sure using this hardcoded IP address is safe here. <p>See more on <a href="https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaAHquINRdE24u2TNGQN&open=AaAHquINRdE24u2TNGQN&pullRequest=13884">SonarQube Cloud</a></p>
[Show more details](https://github.com/apache/cloudstack/security/code-scanning/202)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5304650971
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [24.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) (required ≥ B)
<!-- sqra:qg_revision=5869fe3468e35c95a04247855eb958b0111b24aab9bd866861f05018f1f77e0e -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5302097955
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/13884?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 3.41%. Comparing base ([`1ceb1d0`](https://app.codecov.io/gh/apache/cloudstack/commit/1ceb1d0925593f2a95eb782df238dd2efd66e396?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`806c364`](https://app.codecov.io/gh/apache/cloudstack/commit/806c364061ec9d29f6236ffeec7f704c6d2b94b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 3 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #13884 +/- ##
======================================
Coverage 3.41% 3.41%
======================================
Files 487 487
Lines 41867 41867
Branches 7912 7912
======================================
Hits 1429 1429
Misses 40238 40238
Partials 200 200
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/13884/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/13884/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `3.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cloudstack/pull/13884?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5505772481
<b>[SF] Trillian test result (tid-16866)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 62652 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16866-kvm-ol8.zip
Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5537927836
<b>[SF] Trillian test result (tid-16896)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 1558 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16896-kvm-ol8.zip
Smoke tests completed. 0 look OK, 0 have errors, 156 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_2fa | `Skipped` | --- | test_2fa.py
all_test_account_access | `Skipped` | --- | test_account_access.py
all_test_accounts | `Skipped` | --- | test_accounts.py
all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
all_test_annotations | `Skipped` | --- | test_annotations.py
all_test_async_job | `Skipped` | --- | test_async_job.py
all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
all_test_backup_recovery_kboss | `Skipped` | --- | test_backup_recovery_kboss.py
all_test_backup_recovery_nas | `Skipped` | --- | test_backup_recovery_nas.py
all_test_backup_recovery_veeam | `Skipped` | --- | test_backup_recovery_veeam.py
all_test_bucket | `Skipped` | --- | test_bucket.py
all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
all_test_cluster_drs | `Skipped` | --- | test_cluster_drs.py
all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
all_test_create_network | `Skipped` | --- | test_create_network.py
all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
all_test_deploy_vms_in_parallel | `Skipped` | --- | test_deploy_vms_in_parallel.py
all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | test_deploy_vms_with_varied_deploymentplanners.py
all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
all_test_direct_download | `Skipped` | --- | test_direct_download.py
all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
all_test_dns_framework_powerdns | `Skipped` | --- | test_dns_framework_powerdns.py
all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
all_test_events_resource | `Skipped` | --- | test_events_resource.py
all_test_extension_custom_action_lifecycle | `Skipped` | --- | test_extension_custom_action_lifecycle.py
all_test_extension_custom | `Skipped` | --- | test_extension_custom.py
all_test_extension_lifecycle | `Skipped` | --- | test_extension_lifecycle.py
all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
all_test_global_acls | `Skipped` | --- | test_global_acls.py
all_test_global_settings | `Skipped` | --- | test_global_settings.py
all_test_guest_os | `Skipped` | --- | test_guest_os.py
all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
all_test_host_control_state | `Skipped` | --- | test_host_control_state.py
all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
all_test_host_ping | `Skipped` | --- | test_host_ping.py
all_test_host_tags | `Skipped` | --- | test_host_tags.py
all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
all_test_image_store_object_migration | `Skipped` | --- | test_image_store_object_migration.py
all_test_import_unmanage_volumes | `Skipped` | --- | test_import_unmanage_volumes.py
all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
all_test_ipv4_routing | `Skipped` | --- | test_ipv4_routing.py
all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
all_test_iso | `Skipped` | --- | test_iso.py
all_test_kms_lifecycle | `Skipped` | --- | test_kms_lifecycle.py
all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
all_test_list_accounts | `Skipped` | --- | test_list_accounts.py
all_test_list_disk_offerings | `Skipped` | --- | test_list_disk_offerings.py
all_test_list_domains | `Skipped` | --- | test_list_domains.py
all_test_list_hosts | `Skipped` | --- | test_list_hosts.py
all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
all_test_list_service_offerings | `Skipped` | --- | test_list_service_offerings.py
all_test_list_storage_pools | `Skipped` | --- | test_list_storage_pools.py
all_test_list_volumes | `Skipped` | --- | test_list_volumes.py
all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
all_test_login | `Skipped` | --- | test_login.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_migration | `Skipped` | --- | test_migration.py
all_test_ms_maintenance_and_safe_shutdown | `Skipped` | --- | test_ms_maintenance_and_safe_shutdown.py
all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
all_test_network_acl | `Skipped` | --- | test_network_acl.py
all_test_network_extension_namespace | `Skipped` | --- | test_network_extension_namespace.py
all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
all_test_network | `Skipped` | --- | test_network.py
all_test_network_traffic_type_api | `Skipped` | --- | test_network_traffic_type_api.py
all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
all_test_nic | `Skipped` | --- | test_nic.py
all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
all_test_nonstrict_affinity_group | `Skipped` | --- | test_nonstrict_affinity_group.py
all_test_object_stores | `Skipped` | --- | test_object_stores.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
all_test_password_server | `Skipped` | --- | test_password_server.py
all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
all_test_primary_storage_scope | `Skipped` | --- | test_primary_storage_scope.py
all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
all_test_private_roles | `Skipped` | --- | test_private_roles.py
all_test_projects | `Skipped` | --- | test_projects.py
all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
all_test_purge_expunged_vms | `Skipped` | --- | test_purge_expunged_vms.py
all_test_pvlan | `Skipped` | --- | test_pvlan.py
all_test_quarantined_ips | `Skipped` | --- | test_quarantined_ips.py
all_test_regions | `Skipped` | --- | test_regions.py
all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
all_test_resource_names | `Skipped` | --- | test_resource_names.py
all_test_restore_vm | `Skipped` | --- | test_restore_vm.py
all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
all_test_router_dns | `Skipped` | --- | test_router_dns.py
all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
all_test_routers | `Skipped` | --- | test_routers.py
all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
all_test_sharedfs_lifecycle | `Skipped` | --- | test_sharedfs_lifecycle.py
all_test_snapshots | `Skipped` | --- | test_snapshots.py
all_test_ssl_offloading | `Skipped` | --- | test_ssl_offloading.py
all_test_ssvm | `Skipped` | --- | test_ssvm.py
all_test_staticroles | `Skipped` | --- | test_staticroles.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_systemvm_userdata | `Skipped` | --- | test_systemvm_userdata.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_usage | `Skipped` | --- | test_usage.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_lifecycle_unmanage_kvm_import | `Skipped` | --- | test_vm_lifecycle_unmanage_kvm_import.py
all_test_vm_lifecycle_with_snapshot_or_volume | `Skipped` | --- | test_vm_lifecycle_with_snapshot_or_volume.py
all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_vm_strict_host_tags | `Skipped` | --- | test_vm_strict_host_tags.py
all_test_vnf_templates | `Skipped` | --- | test_vnf_templates.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_conserve_mode | `Skipped` | --- | test_vpc_conserve_mode.py
all_test_vpc_firewall_rules | `Skipped` | --- | test_vpc_firewall_rules.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6384788378
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#discussion_r4324813063
##########
engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java:
##########
@@ -138,6 +138,23 @@ public interface NetworkOrchestrationService {
ConfigKey<Integer> VmNetworkThrottlingRate = new ConfigKey<Integer>("Network", Integer.class, "vm.network.throttling.rate", "200",
"Default data transfer rate in megabits per second allowed in User vm's default network.", true, ConfigKey.Scope.Zone);
+ ConfigKey<String> NetworkLBHaproxyStatsVisbility = new ConfigKey<>("Network", String.class,
+ "network.loadbalancer.haproxy.stats.visibility", "global",
+ "Load Balancer(haproxy) stats visibility, the value can be one of the following six parameters : global,guest-network,link-local,disabled,all,default",
+ true, ConfigKey.Kind.Select, "global,guest-network,link-local,disabled,all,default");
+
+ ConfigKey<String> NetworkLBHaproxyStatsUri = new ConfigKey<>("Network", String.class,
+ "network.loadbalancer.haproxy.stats.uri", "/admin?stats",
+ "Load Balancer(haproxy) uri.", true);
+
+ ConfigKey<String> NetworkLBHaproxyStatsAuth = new ConfigKey<>("Secure", String.class,
+ "network.loadbalancer.haproxy.stats.auth", "admin1:AdMiN123",
+ "Load Balancer(haproxy) authentication string in the format username:password", true);
+
+ ConfigKey<String> NetworkLBHaproxyStatsPort = new ConfigKey<>("Network", String.class,
+ "network.loadbalancer.haproxy.stats.port", "8081",
+ "Load Balancer(haproxy) stats port number.", true);
Review Comment:
The HAProxy stats port is modeled as a `String` but is consumed numerically elsewhere (e.g., parsed via `Integer.parseInt(...)`). Defining it as `ConfigKey<Integer>` would provide type-safety and earlier validation (and remove repeated parsing). If you must keep it as a string for backward compatibility, consider at least adding validation at the boundary where it’s used to ensure the value is numeric and within a valid port range.
##########
engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/ObjectStoreDaoImpl.java:
##########
@@ -26,21 +26,21 @@
import com.cloud.utils.db.TransactionStatus;
import org.apache.cloudstack.api.response.ObjectStoreResponse;
-import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.framework.config.ConfigKey;
import org.springframework.stereotype.Component;
-import javax.inject.Inject;
import javax.naming.ConfigurationException;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
@Component
public class ObjectStoreDaoImpl extends GenericDaoBase<ObjectStoreVO, Long> implements ObjectStoreDao {
+ // Registered/owned by ManagementServer; declared here too so this lower-layer module can read it without depending on the server module.
+ private static final ConfigKey<Integer> DetailBatchQuerySize = new ConfigKey<>("Advanced", Integer.class, "detail.batch.query.size", "2000",
+ "Default entity detail batch query size for listing", true);
Review Comment:
This PR introduces multiple local duplicated `ConfigKey` declarations for the same underlying setting (`detail.batch.query.size`) across different modules/DAOs. That duplication increases the risk of drift (defaults/descriptions/category diverging). Consider centralizing this `ConfigKey` into a shared API/components module accessible from these layers, or introducing a single shared constants class for cross-module config keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5529851982
<b>[SF] Trillian Build Failed (tid-16893)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5530926734
<b>[SF] Trillian test result (tid-16895)</b>
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 1540 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16895-xcpng82.zip
Smoke tests completed. 0 look OK, 0 have errors, 156 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_2fa | `Skipped` | --- | test_2fa.py
all_test_account_access | `Skipped` | --- | test_account_access.py
all_test_accounts | `Skipped` | --- | test_accounts.py
all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
all_test_annotations | `Skipped` | --- | test_annotations.py
all_test_async_job | `Skipped` | --- | test_async_job.py
all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
all_test_backup_recovery_kboss | `Skipped` | --- | test_backup_recovery_kboss.py
all_test_backup_recovery_nas | `Skipped` | --- | test_backup_recovery_nas.py
all_test_backup_recovery_veeam | `Skipped` | --- | test_backup_recovery_veeam.py
all_test_bucket | `Skipped` | --- | test_bucket.py
all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
all_test_cluster_drs | `Skipped` | --- | test_cluster_drs.py
all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
all_test_create_network | `Skipped` | --- | test_create_network.py
all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
all_test_deploy_vms_in_parallel | `Skipped` | --- | test_deploy_vms_in_parallel.py
all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | test_deploy_vms_with_varied_deploymentplanners.py
all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
all_test_direct_download | `Skipped` | --- | test_direct_download.py
all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
all_test_dns_framework_powerdns | `Skipped` | --- | test_dns_framework_powerdns.py
all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
all_test_events_resource | `Skipped` | --- | test_events_resource.py
all_test_extension_custom_action_lifecycle | `Skipped` | --- | test_extension_custom_action_lifecycle.py
all_test_extension_custom | `Skipped` | --- | test_extension_custom.py
all_test_extension_lifecycle | `Skipped` | --- | test_extension_lifecycle.py
all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
all_test_global_acls | `Skipped` | --- | test_global_acls.py
all_test_global_settings | `Skipped` | --- | test_global_settings.py
all_test_guest_os | `Skipped` | --- | test_guest_os.py
all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
all_test_host_control_state | `Skipped` | --- | test_host_control_state.py
all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
all_test_host_ping | `Skipped` | --- | test_host_ping.py
all_test_host_tags | `Skipped` | --- | test_host_tags.py
all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
all_test_image_store_object_migration | `Skipped` | --- | test_image_store_object_migration.py
all_test_import_unmanage_volumes | `Skipped` | --- | test_import_unmanage_volumes.py
all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
all_test_ipv4_routing | `Skipped` | --- | test_ipv4_routing.py
all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
all_test_iso | `Skipped` | --- | test_iso.py
all_test_kms_lifecycle | `Skipped` | --- | test_kms_lifecycle.py
all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
all_test_list_accounts | `Skipped` | --- | test_list_accounts.py
all_test_list_disk_offerings | `Skipped` | --- | test_list_disk_offerings.py
all_test_list_domains | `Skipped` | --- | test_list_domains.py
all_test_list_hosts | `Skipped` | --- | test_list_hosts.py
all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
all_test_list_service_offerings | `Skipped` | --- | test_list_service_offerings.py
all_test_list_storage_pools | `Skipped` | --- | test_list_storage_pools.py
all_test_list_volumes | `Skipped` | --- | test_list_volumes.py
all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
all_test_login | `Skipped` | --- | test_login.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_migration | `Skipped` | --- | test_migration.py
all_test_ms_maintenance_and_safe_shutdown | `Skipped` | --- | test_ms_maintenance_and_safe_shutdown.py
all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
all_test_network_acl | `Skipped` | --- | test_network_acl.py
all_test_network_extension_namespace | `Skipped` | --- | test_network_extension_namespace.py
all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
all_test_network | `Skipped` | --- | test_network.py
all_test_network_traffic_type_api | `Skipped` | --- | test_network_traffic_type_api.py
all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
all_test_nic | `Skipped` | --- | test_nic.py
all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
all_test_nonstrict_affinity_group | `Skipped` | --- | test_nonstrict_affinity_group.py
all_test_object_stores | `Skipped` | --- | test_object_stores.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
all_test_password_server | `Skipped` | --- | test_password_server.py
all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
all_test_primary_storage_scope | `Skipped` | --- | test_primary_storage_scope.py
all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
all_test_private_roles | `Skipped` | --- | test_private_roles.py
all_test_projects | `Skipped` | --- | test_projects.py
all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
all_test_purge_expunged_vms | `Skipped` | --- | test_purge_expunged_vms.py
all_test_pvlan | `Skipped` | --- | test_pvlan.py
all_test_quarantined_ips | `Skipped` | --- | test_quarantined_ips.py
all_test_regions | `Skipped` | --- | test_regions.py
all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
all_test_resource_names | `Skipped` | --- | test_resource_names.py
all_test_restore_vm | `Skipped` | --- | test_restore_vm.py
all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
all_test_router_dns | `Skipped` | --- | test_router_dns.py
all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
all_test_routers | `Skipped` | --- | test_routers.py
all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
all_test_sharedfs_lifecycle | `Skipped` | --- | test_sharedfs_lifecycle.py
all_test_snapshots | `Skipped` | --- | test_snapshots.py
all_test_ssl_offloading | `Skipped` | --- | test_ssl_offloading.py
all_test_ssvm | `Skipped` | --- | test_ssvm.py
all_test_staticroles | `Skipped` | --- | test_staticroles.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_systemvm_userdata | `Skipped` | --- | test_systemvm_userdata.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_usage | `Skipped` | --- | test_usage.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_lifecycle_unmanage_kvm_import | `Skipped` | --- | test_vm_lifecycle_unmanage_kvm_import.py
all_test_vm_lifecycle_with_snapshot_or_volume | `Skipped` | --- | test_vm_lifecycle_with_snapshot_or_volume.py
all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_vm_strict_host_tags | `Skipped` | --- | test_vm_strict_host_tags.py
all_test_vnf_templates | `Skipped` | --- | test_vnf_templates.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_conserve_mode | `Skipped` | --- | test_vpc_conserve_mode.py
all_test_vpc_firewall_rules | `Skipped` | --- | test_vpc_firewall_rules.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5537455127
<b>[SF] Trillian Build Failed (tid-16897)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5538950958
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5304177976
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [24.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) (required ≥ B)
<!-- sqra:qg_revision=86cc6f521607b44a67527d9f858d4f9a1805b35ad0f8d91be650d32bc737c4fd -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6335700633
@nvazquez , as discussed I am busy splitting this PR with the help of AI. I will close this one as soon as I am satisfied the cascade of PRs, that I'll be creating cover everything. I will keep this open and mark as draft for testing purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6417044483
> [SF] Trillian test result (tid-17252) Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8 Total time taken: 61896 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t17252-vmware-70u3.zip Smoke tests completed. 157 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:
>
> Test Result Time (s) Test File
wow, nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6416901196
<b>[SF] Trillian test result (tid-17252)</b>
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 61896 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t17252-vmware-70u3.zip
Smoke tests completed. 157 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5505958466
@nvazquez @vladimirpetrov , this is the one I spoke about that needs to go in early in the cycle. cc @weizhouapache @winterhazel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5324857728
<b>[SF] Trillian Build Failed (tid-16773)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5318128830
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "rp- (via GitHub)" <gi...@apache.org>.
rp- commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5616371386
I checked the Linstor changes and they look fine to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5554243320
<b>[SF] Trillian test result (tid-16909)</b>
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 98256 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16909-xcpng82.zip
Smoke tests completed. 144 look OK, 10 have errors, 2 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_events_resource | `Error` | 238.21 | test_events_resource.py
test_12_deploy_vm_with_root_disk_encryption | `Error` | 15.91 | test_kms_lifecycle.py
test_09_vpc_source_nat_ip_update | `Error` | 27.58 | test_network_extension_namespace.py
test_01_deployVMInSharedNetwork | `Error` | 439.08 | test_network.py
test_01_non_strict_host_anti_affinity | `Error` | 218.80 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 71.55 | test_nonstrict_affinity_group.py
test_02_list_snapshots_with_removed_data_store | `Error` | 11.91 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 11.92 | test_snapshots.py
test_01_vpn_usage | `Error` | 1.12 | test_usage.py
test_11_destroy_vm_and_volumes | `Error` | 25.38 | test_vm_life_cycle.py
test_change_service_offering_for_vm_with_snapshots | `Failure` | 1023.79 | test_vm_snapshots.py
test_01_migrate_vm_strict_tags_success | `Error` | 56.90 | test_vm_strict_host_tags.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#discussion_r3926885033
##########
plugins/network-elements/elastic-loadbalancer/src/main/java/com/cloud/network/lb/ElasticLoadBalancerManager.java:
##########
@@ -31,6 +32,18 @@ public interface ElasticLoadBalancerManager {
public static final int DEFAULT_ELB_VM_RAMSIZE = 128; // 512 MB
public static final int DEFAULT_ELB_VM_CPU_MHZ = 256; // 500 MHz
+ ConfigKey<Integer> ElasticLoadBalancerVmMemory = new ConfigKey<>("Advanced", Integer.class, "network.loadbalancer.basiczone.elb.vm.ram.size", "512",
+ "Memory in MB for the elastic load balancer vm", true);
Review Comment:
ElasticLoadBalancerVmMemory is introduced with a default of 512MB, but the existing DB schema migration that adds this config key inserts a default of 128 (see schema-228to229.sql). This mismatch changes the effective default depending on whether the configuration row exists and makes upgrades/new installs inconsistent.
##########
plugins/storage/image/default/src/main/java/org/apache/cloudstack/storage/datastore/driver/CloudStackImageStoreDriverImpl.java:
##########
@@ -130,12 +130,8 @@ private String generateCopyUrl(String ipAddress, String fileName, String filePat
String hostname = ipAddress;
String scheme = "http";
- boolean _sslCopy = false;
- String sslCfg = _configDao.getValue(Config.SecStorageEncryptCopy.toString());
+ boolean _sslCopy = SecondaryStorageVmManager.SecStorageEncryptCopy.value();
String _ssvmUrlDomain = _configDao.getValue("secstorage.ssl.cert.domain");
Review Comment:
generateCopyUrl() now uses SecondaryStorageVmManager.SecStorageEncryptCopy.value(), but still fetches the cert domain via the raw string key "secstorage.ssl.cert.domain". Since SecStorageSecureCopyCert was added as a ConfigKey, using it here keeps configuration access consistent and avoids typos / divergent defaults.
##########
engine/storage/cache/src/main/java/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java:
##########
@@ -159,13 +162,23 @@ public void setRunLevel(int level) {
@Override
public boolean configure(String name, Map<String, Object> params) throws ConfigurationException {
- cacheReplacementEnabled = Boolean.parseBoolean(configDao.getValue(Config.StorageCacheReplacementEnabled.key()));
- cacheReplaceMentInterval = NumbersUtil.parseInt(configDao.getValue(Config.StorageCacheReplacementInterval.key()), 86400);
- workers = NumbersUtil.parseInt(configDao.getValue(Config.ExpungeWorkers.key()), 10);
+ cacheReplacementEnabled = StorageCacheReplacementEnabled.value();
+ cacheReplaceMentInterval = StorageCacheReplacementInterval.value();
+ workers = NumbersUtil.parseInt(configDao.getValue(StorageManager.ExpungeWorkers.key()), 10);
Review Comment:
workers is still being derived via configDao.getValue(..., 10), which hardcodes a fallback of 10 even though ExpungeWorkers now exists as a ConfigKey with its own default. This can unintentionally spawn 10 cache-replacement threads when the config is absent/uninitialized and also bypasses the new ConfigKey access pattern used above.
##########
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManager.java:
##########
@@ -64,6 +64,9 @@ public interface VirtualNetworkApplianceManager extends Manager, VirtualNetworkA
ConfigKey<String> RouterTemplateOvm3 = new ConfigKey<>(String.class, RouterTemplateOvm3CK, "Advanced", "SystemVM Template (Ovm3)",
"Name of the default router template on Ovm3.", true, ConfigKey.Scope.Zone, null);
+ ConfigKey<Integer> RouterRamSize = new ConfigKey<>("Hidden", Integer.class, "router.ram.size", "512",
+ "Default RAM for router VM (in MB).", true);
Review Comment:
RouterRamSize ConfigKey default is set to 512MB, but existing schema/data migrations set router.ram.size to 256 (e.g. Upgrade442to450 updates it to 256). Keeping 512 here changes the effective default when the configuration row is missing/reset and is inconsistent with current behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6336281664
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [23.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13884&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) (required ≥ B)
<!-- sqra:qg_revision=8bcd3aa690eccc9dab87783c700c3726abf622c9044de3fd6e5405aaefcf9d7e -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6176329241
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5528725458
@DaanHoogland a [SL] Trillian-Jenkins matrix job (ol8 mgmt + kvm-ol8, ubuntu22 mgmt + kvm-ubuntu22, ol8 mgmt + vmware-70u3, ol9 mgmt + xcpng82) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5523855165
<b>[SF] Trillian test result (tid-16883)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 1710 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16883-kvm-ol8.zip
Smoke tests completed. 0 look OK, 0 have errors, 156 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_2fa | `Skipped` | --- | test_2fa.py
all_test_account_access | `Skipped` | --- | test_account_access.py
all_test_accounts | `Skipped` | --- | test_accounts.py
all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
all_test_annotations | `Skipped` | --- | test_annotations.py
all_test_async_job | `Skipped` | --- | test_async_job.py
all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
all_test_backup_recovery_kboss | `Skipped` | --- | test_backup_recovery_kboss.py
all_test_backup_recovery_nas | `Skipped` | --- | test_backup_recovery_nas.py
all_test_backup_recovery_veeam | `Skipped` | --- | test_backup_recovery_veeam.py
all_test_bucket | `Skipped` | --- | test_bucket.py
all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
all_test_cluster_drs | `Skipped` | --- | test_cluster_drs.py
all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
all_test_create_network | `Skipped` | --- | test_create_network.py
all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
all_test_deploy_vms_in_parallel | `Skipped` | --- | test_deploy_vms_in_parallel.py
all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | test_deploy_vms_with_varied_deploymentplanners.py
all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
all_test_direct_download | `Skipped` | --- | test_direct_download.py
all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
all_test_dns_framework_powerdns | `Skipped` | --- | test_dns_framework_powerdns.py
all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
all_test_events_resource | `Skipped` | --- | test_events_resource.py
all_test_extension_custom_action_lifecycle | `Skipped` | --- | test_extension_custom_action_lifecycle.py
all_test_extension_custom | `Skipped` | --- | test_extension_custom.py
all_test_extension_lifecycle | `Skipped` | --- | test_extension_lifecycle.py
all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
all_test_global_acls | `Skipped` | --- | test_global_acls.py
all_test_global_settings | `Skipped` | --- | test_global_settings.py
all_test_guest_os | `Skipped` | --- | test_guest_os.py
all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
all_test_host_control_state | `Skipped` | --- | test_host_control_state.py
all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
all_test_host_ping | `Skipped` | --- | test_host_ping.py
all_test_host_tags | `Skipped` | --- | test_host_tags.py
all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
all_test_image_store_object_migration | `Skipped` | --- | test_image_store_object_migration.py
all_test_import_unmanage_volumes | `Skipped` | --- | test_import_unmanage_volumes.py
all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
all_test_ipv4_routing | `Skipped` | --- | test_ipv4_routing.py
all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
all_test_iso | `Skipped` | --- | test_iso.py
all_test_kms_lifecycle | `Skipped` | --- | test_kms_lifecycle.py
all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
all_test_list_accounts | `Skipped` | --- | test_list_accounts.py
all_test_list_disk_offerings | `Skipped` | --- | test_list_disk_offerings.py
all_test_list_domains | `Skipped` | --- | test_list_domains.py
all_test_list_hosts | `Skipped` | --- | test_list_hosts.py
all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
all_test_list_service_offerings | `Skipped` | --- | test_list_service_offerings.py
all_test_list_storage_pools | `Skipped` | --- | test_list_storage_pools.py
all_test_list_volumes | `Skipped` | --- | test_list_volumes.py
all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
all_test_login | `Skipped` | --- | test_login.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_migration | `Skipped` | --- | test_migration.py
all_test_ms_maintenance_and_safe_shutdown | `Skipped` | --- | test_ms_maintenance_and_safe_shutdown.py
all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
all_test_network_acl | `Skipped` | --- | test_network_acl.py
all_test_network_extension_namespace | `Skipped` | --- | test_network_extension_namespace.py
all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
all_test_network | `Skipped` | --- | test_network.py
all_test_network_traffic_type_api | `Skipped` | --- | test_network_traffic_type_api.py
all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
all_test_nic | `Skipped` | --- | test_nic.py
all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
all_test_nonstrict_affinity_group | `Skipped` | --- | test_nonstrict_affinity_group.py
all_test_object_stores | `Skipped` | --- | test_object_stores.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
all_test_password_server | `Skipped` | --- | test_password_server.py
all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
all_test_primary_storage_scope | `Skipped` | --- | test_primary_storage_scope.py
all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
all_test_private_roles | `Skipped` | --- | test_private_roles.py
all_test_projects | `Skipped` | --- | test_projects.py
all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
all_test_purge_expunged_vms | `Skipped` | --- | test_purge_expunged_vms.py
all_test_pvlan | `Skipped` | --- | test_pvlan.py
all_test_quarantined_ips | `Skipped` | --- | test_quarantined_ips.py
all_test_regions | `Skipped` | --- | test_regions.py
all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
all_test_resource_names | `Skipped` | --- | test_resource_names.py
all_test_restore_vm | `Skipped` | --- | test_restore_vm.py
all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
all_test_router_dns | `Skipped` | --- | test_router_dns.py
all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
all_test_routers | `Skipped` | --- | test_routers.py
all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
all_test_sharedfs_lifecycle | `Skipped` | --- | test_sharedfs_lifecycle.py
all_test_snapshots | `Skipped` | --- | test_snapshots.py
all_test_ssl_offloading | `Skipped` | --- | test_ssl_offloading.py
all_test_ssvm | `Skipped` | --- | test_ssvm.py
all_test_staticroles | `Skipped` | --- | test_staticroles.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_systemvm_userdata | `Skipped` | --- | test_systemvm_userdata.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_usage | `Skipped` | --- | test_usage.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_lifecycle_unmanage_kvm_import | `Skipped` | --- | test_vm_lifecycle_unmanage_kvm_import.py
all_test_vm_lifecycle_with_snapshot_or_volume | `Skipped` | --- | test_vm_lifecycle_with_snapshot_or_volume.py
all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_vm_strict_host_tags | `Skipped` | --- | test_vm_strict_host_tags.py
all_test_vnf_templates | `Skipped` | --- | test_vnf_templates.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_conserve_mode | `Skipped` | --- | test_vpc_conserve_mode.py
all_test_vpc_firewall_rules | `Skipped` | --- | test_vpc_firewall_rules.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5530140379
<b>[SF] Trillian test result (tid-16891)</b>
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 1467 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16891-kvm-ubuntu22.zip
Smoke tests completed. 0 look OK, 0 have errors, 156 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_2fa | `Skipped` | --- | test_2fa.py
all_test_account_access | `Skipped` | --- | test_account_access.py
all_test_accounts | `Skipped` | --- | test_accounts.py
all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
all_test_annotations | `Skipped` | --- | test_annotations.py
all_test_async_job | `Skipped` | --- | test_async_job.py
all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
all_test_backup_recovery_kboss | `Skipped` | --- | test_backup_recovery_kboss.py
all_test_backup_recovery_nas | `Skipped` | --- | test_backup_recovery_nas.py
all_test_backup_recovery_veeam | `Skipped` | --- | test_backup_recovery_veeam.py
all_test_bucket | `Skipped` | --- | test_bucket.py
all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
all_test_cluster_drs | `Skipped` | --- | test_cluster_drs.py
all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
all_test_create_network | `Skipped` | --- | test_create_network.py
all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
all_test_deploy_vms_in_parallel | `Skipped` | --- | test_deploy_vms_in_parallel.py
all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | test_deploy_vms_with_varied_deploymentplanners.py
all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
all_test_direct_download | `Skipped` | --- | test_direct_download.py
all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
all_test_dns_framework_powerdns | `Skipped` | --- | test_dns_framework_powerdns.py
all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
all_test_events_resource | `Skipped` | --- | test_events_resource.py
all_test_extension_custom_action_lifecycle | `Skipped` | --- | test_extension_custom_action_lifecycle.py
all_test_extension_custom | `Skipped` | --- | test_extension_custom.py
all_test_extension_lifecycle | `Skipped` | --- | test_extension_lifecycle.py
all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
all_test_global_acls | `Skipped` | --- | test_global_acls.py
all_test_global_settings | `Skipped` | --- | test_global_settings.py
all_test_guest_os | `Skipped` | --- | test_guest_os.py
all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
all_test_host_control_state | `Skipped` | --- | test_host_control_state.py
all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
all_test_host_ping | `Skipped` | --- | test_host_ping.py
all_test_host_tags | `Skipped` | --- | test_host_tags.py
all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
all_test_image_store_object_migration | `Skipped` | --- | test_image_store_object_migration.py
all_test_import_unmanage_volumes | `Skipped` | --- | test_import_unmanage_volumes.py
all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
all_test_ipv4_routing | `Skipped` | --- | test_ipv4_routing.py
all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
all_test_iso | `Skipped` | --- | test_iso.py
all_test_kms_lifecycle | `Skipped` | --- | test_kms_lifecycle.py
all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
all_test_list_accounts | `Skipped` | --- | test_list_accounts.py
all_test_list_disk_offerings | `Skipped` | --- | test_list_disk_offerings.py
all_test_list_domains | `Skipped` | --- | test_list_domains.py
all_test_list_hosts | `Skipped` | --- | test_list_hosts.py
all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
all_test_list_service_offerings | `Skipped` | --- | test_list_service_offerings.py
all_test_list_storage_pools | `Skipped` | --- | test_list_storage_pools.py
all_test_list_volumes | `Skipped` | --- | test_list_volumes.py
all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
all_test_login | `Skipped` | --- | test_login.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_migration | `Skipped` | --- | test_migration.py
all_test_ms_maintenance_and_safe_shutdown | `Skipped` | --- | test_ms_maintenance_and_safe_shutdown.py
all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
all_test_network_acl | `Skipped` | --- | test_network_acl.py
all_test_network_extension_namespace | `Skipped` | --- | test_network_extension_namespace.py
all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
all_test_network | `Skipped` | --- | test_network.py
all_test_network_traffic_type_api | `Skipped` | --- | test_network_traffic_type_api.py
all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
all_test_nic | `Skipped` | --- | test_nic.py
all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
all_test_nonstrict_affinity_group | `Skipped` | --- | test_nonstrict_affinity_group.py
all_test_object_stores | `Skipped` | --- | test_object_stores.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
all_test_password_server | `Skipped` | --- | test_password_server.py
all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
all_test_primary_storage_scope | `Skipped` | --- | test_primary_storage_scope.py
all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
all_test_private_roles | `Skipped` | --- | test_private_roles.py
all_test_projects | `Skipped` | --- | test_projects.py
all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
all_test_purge_expunged_vms | `Skipped` | --- | test_purge_expunged_vms.py
all_test_pvlan | `Skipped` | --- | test_pvlan.py
all_test_quarantined_ips | `Skipped` | --- | test_quarantined_ips.py
all_test_regions | `Skipped` | --- | test_regions.py
all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
all_test_resource_names | `Skipped` | --- | test_resource_names.py
all_test_restore_vm | `Skipped` | --- | test_restore_vm.py
all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
all_test_router_dns | `Skipped` | --- | test_router_dns.py
all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
all_test_routers | `Skipped` | --- | test_routers.py
all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
all_test_sharedfs_lifecycle | `Skipped` | --- | test_sharedfs_lifecycle.py
all_test_snapshots | `Skipped` | --- | test_snapshots.py
all_test_ssl_offloading | `Skipped` | --- | test_ssl_offloading.py
all_test_ssvm | `Skipped` | --- | test_ssvm.py
all_test_staticroles | `Skipped` | --- | test_staticroles.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_systemvm_userdata | `Skipped` | --- | test_systemvm_userdata.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_usage | `Skipped` | --- | test_usage.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_lifecycle_unmanage_kvm_import | `Skipped` | --- | test_vm_lifecycle_unmanage_kvm_import.py
all_test_vm_lifecycle_with_snapshot_or_volume | `Skipped` | --- | test_vm_lifecycle_with_snapshot_or_volume.py
all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_vm_strict_host_tags | `Skipped` | --- | test_vm_strict_host_tags.py
all_test_vnf_templates | `Skipped` | --- | test_vnf_templates.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_conserve_mode | `Skipped` | --- | test_vpc_conserve_mode.py
all_test_vpc_firewall_rules | `Skipped` | --- | test_vpc_firewall_rules.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5538981446
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5550769598
<b>[SF] Trillian test result (tid-16907)</b>
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 60550 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16907-kvm-ubuntu22.zip
Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5812990972
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6361778421
This PR has been split into smaller PRs:
**Foundation** (merge first)
- #14467 declare and register ConfigKeys for all remaining Config enum entries
**Parallel** (based on the foundation; can be reviewed and merged in any order)
- #14468 use ConfigKeys for account, domain, project and SSO settings
- #14469 use ConfigKeys for remote access VPN and VPC settings
- #14470 use ConfigKeys for snapshot, VM snapshot and usage settings
- #14471 use ConfigKeys for event bus settings
- #14472 use ConfigKeys for UCS settings and remaining getValue() literals
**Stacked** (merge in this order, starting after the foundation)
- #14473 core-1: alert, storage, guest network and hidden settings
- #14474 core-2: ManagementServer, agent, secondary storage and router settings
- #14475 core-3: network, stats collector, storage, user VM and account manager settings
- #14476 core-4: deployment planning, ELB, API rate limit, LB and firewall settings
- #14477 core-5: assorted management server, VMware, XenServer and baremetal settings
**Last**: removing the dead `Config` enum entries will be opened once all of the above are merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6419593870
<b>[SF] Trillian test result (tid-17250)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 68517 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t17250-kvm-ol8.zip
Smoke tests completed. 156 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_redundant_vpc_site2site_vpn | `Failure` | 423.60 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5327773290
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5527480104
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5574163122
<b>[SF] Trillian test result (tid-16908)</b>
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 264596 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16908-vmware-70u3.zip
Smoke tests completed. 142 look OK, 14 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestClusterDRS>:setup | `Error` | 0.00 | test_cluster_drs.py
test_12_deploy_vm_with_root_disk_encryption | `Error` | 15.37 | test_kms_lifecycle.py
test_01_vpn_usage | `Error` | 1.15 | test_usage.py
test_01_deploy_vm_on_specific_host | `Error` | 3607.10 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 4.70 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 5.19 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 4.80 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 4.84 | test_vm_deployment_planner.py
test_02_offline_migrate_VM_with_two_data_disks | `Error` | 3646.29 | test_vm_life_cycle.py
test_03_live_migrate_VM_with_two_data_disks | `Error` | 1842.01 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 1826.27 | test_vm_life_cycle.py
test_09_expunge_vm | `Failure` | 428.07 | test_vm_life_cycle.py
test_01_unmanage_vm_cycle | `Error` | 1921.93 | test_vm_lifecycle_unmanage_import.py
ContextSuite context=TestUnmanageVM>:teardown | `Error` | 1922.13 | test_vm_lifecycle_unmanage_import.py
test_01_migrate_vm_strict_tags_success | `Error` | 1.83 | test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure | `Error` | 1.94 | test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success | `Error` | 1.69 | test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure | `Error` | 2.36 | test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success | `Error` | 1.85 | test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure | `Error` | 3.35 | test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 1.64 | test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 2.67 | test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 1.62 | test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 1.64 | test_vm_strict_host_tags.py
test_05_deploy_vm_on_specific_host_with_strict_tags_failure | `Failure` | 1.67 | test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure | `Failure` | 3.29 | test_vm_strict_host_tags.py
test_04_deploy_vnf_appliance | `Error` | 2046.34 | test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown | `Error` | 1882.97 | test_vnf_templates.py
test_13_migrate_volume_and_change_offering | `Error` | 2412.41 | test_volumes.py
ContextSuite context=TestVolumes>:teardown | `Error` | 1826.56 | test_volumes.py
ContextSuite context=TestVPCConserveModeRules>:setup | `Error` | 0.00 | test_vpc_conserve_mode.py
test_01_verify_ipv6_vpc | `Error` | 3607.67 | test_vpc_ipv6.py
test_01_verify_ipv6_vpc | `Error` | 3607.91 | test_vpc_ipv6.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 3629.64 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Error` | 3726.19 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 3629.36 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 3727.49 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 3725.53 | test_vpc_redundant.py
test_01_VPC_nics_after_destroy | `Failure` | 5766.29 | test_vpc_router_nics.py
test_02_VPC_default_routes | `Error` | 3628.07 | test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 1817.94 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | `Error` | 1818.08 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Failure` | 3609.68 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 3609.97 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | `Error` | 1951.31 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Failure` | 3611.40 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 3611.91 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5523761921
<b>[SF] Trillian test result (tid-16884)</b>
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 1662 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16884-kvm-ubuntu22.zip
Smoke tests completed. 0 look OK, 0 have errors, 156 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_2fa | `Skipped` | --- | test_2fa.py
all_test_account_access | `Skipped` | --- | test_account_access.py
all_test_accounts | `Skipped` | --- | test_accounts.py
all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
all_test_annotations | `Skipped` | --- | test_annotations.py
all_test_async_job | `Skipped` | --- | test_async_job.py
all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
all_test_backup_recovery_kboss | `Skipped` | --- | test_backup_recovery_kboss.py
all_test_backup_recovery_nas | `Skipped` | --- | test_backup_recovery_nas.py
all_test_backup_recovery_veeam | `Skipped` | --- | test_backup_recovery_veeam.py
all_test_bucket | `Skipped` | --- | test_bucket.py
all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
all_test_cluster_drs | `Skipped` | --- | test_cluster_drs.py
all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
all_test_create_network | `Skipped` | --- | test_create_network.py
all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
all_test_deploy_vms_in_parallel | `Skipped` | --- | test_deploy_vms_in_parallel.py
all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | test_deploy_vms_with_varied_deploymentplanners.py
all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
all_test_direct_download | `Skipped` | --- | test_direct_download.py
all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
all_test_dns_framework_powerdns | `Skipped` | --- | test_dns_framework_powerdns.py
all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
all_test_events_resource | `Skipped` | --- | test_events_resource.py
all_test_extension_custom_action_lifecycle | `Skipped` | --- | test_extension_custom_action_lifecycle.py
all_test_extension_custom | `Skipped` | --- | test_extension_custom.py
all_test_extension_lifecycle | `Skipped` | --- | test_extension_lifecycle.py
all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
all_test_global_acls | `Skipped` | --- | test_global_acls.py
all_test_global_settings | `Skipped` | --- | test_global_settings.py
all_test_guest_os | `Skipped` | --- | test_guest_os.py
all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
all_test_host_control_state | `Skipped` | --- | test_host_control_state.py
all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
all_test_host_ping | `Skipped` | --- | test_host_ping.py
all_test_host_tags | `Skipped` | --- | test_host_tags.py
all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
all_test_image_store_object_migration | `Skipped` | --- | test_image_store_object_migration.py
all_test_import_unmanage_volumes | `Skipped` | --- | test_import_unmanage_volumes.py
all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
all_test_ipv4_routing | `Skipped` | --- | test_ipv4_routing.py
all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
all_test_iso | `Skipped` | --- | test_iso.py
all_test_kms_lifecycle | `Skipped` | --- | test_kms_lifecycle.py
all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
all_test_list_accounts | `Skipped` | --- | test_list_accounts.py
all_test_list_disk_offerings | `Skipped` | --- | test_list_disk_offerings.py
all_test_list_domains | `Skipped` | --- | test_list_domains.py
all_test_list_hosts | `Skipped` | --- | test_list_hosts.py
all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
all_test_list_service_offerings | `Skipped` | --- | test_list_service_offerings.py
all_test_list_storage_pools | `Skipped` | --- | test_list_storage_pools.py
all_test_list_volumes | `Skipped` | --- | test_list_volumes.py
all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
all_test_login | `Skipped` | --- | test_login.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_migration | `Skipped` | --- | test_migration.py
all_test_ms_maintenance_and_safe_shutdown | `Skipped` | --- | test_ms_maintenance_and_safe_shutdown.py
all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
all_test_network_acl | `Skipped` | --- | test_network_acl.py
all_test_network_extension_namespace | `Skipped` | --- | test_network_extension_namespace.py
all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
all_test_network | `Skipped` | --- | test_network.py
all_test_network_traffic_type_api | `Skipped` | --- | test_network_traffic_type_api.py
all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
all_test_nic | `Skipped` | --- | test_nic.py
all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
all_test_nonstrict_affinity_group | `Skipped` | --- | test_nonstrict_affinity_group.py
all_test_object_stores | `Skipped` | --- | test_object_stores.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
all_test_password_server | `Skipped` | --- | test_password_server.py
all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
all_test_primary_storage_scope | `Skipped` | --- | test_primary_storage_scope.py
all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
all_test_private_roles | `Skipped` | --- | test_private_roles.py
all_test_projects | `Skipped` | --- | test_projects.py
all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
all_test_purge_expunged_vms | `Skipped` | --- | test_purge_expunged_vms.py
all_test_pvlan | `Skipped` | --- | test_pvlan.py
all_test_quarantined_ips | `Skipped` | --- | test_quarantined_ips.py
all_test_regions | `Skipped` | --- | test_regions.py
all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
all_test_resource_names | `Skipped` | --- | test_resource_names.py
all_test_restore_vm | `Skipped` | --- | test_restore_vm.py
all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
all_test_router_dns | `Skipped` | --- | test_router_dns.py
all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
all_test_routers | `Skipped` | --- | test_routers.py
all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
all_test_sharedfs_lifecycle | `Skipped` | --- | test_sharedfs_lifecycle.py
all_test_snapshots | `Skipped` | --- | test_snapshots.py
all_test_ssl_offloading | `Skipped` | --- | test_ssl_offloading.py
all_test_ssvm | `Skipped` | --- | test_ssvm.py
all_test_staticroles | `Skipped` | --- | test_staticroles.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_systemvm_userdata | `Skipped` | --- | test_systemvm_userdata.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_usage | `Skipped` | --- | test_usage.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_lifecycle_unmanage_kvm_import | `Skipped` | --- | test_vm_lifecycle_unmanage_kvm_import.py
all_test_vm_lifecycle_with_snapshot_or_volume | `Skipped` | --- | test_vm_lifecycle_with_snapshot_or_volume.py
all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_vm_strict_host_tags | `Skipped` | --- | test_vm_strict_host_tags.py
all_test_vnf_templates | `Skipped` | --- | test_vnf_templates.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_conserve_mode | `Skipped` | --- | test_vpc_conserve_mode.py
all_test_vpc_firewall_rules | `Skipped` | --- | test_vpc_firewall_rules.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5537597244
<b>[SF] Trillian Build Failed (tid-16898)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5302290917
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [25.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) (required ≥ B)
<!-- sqra:qg_revision=2e74ac7961f7418e706635ad5327706cfd1deb4170aea1de38e9963dbd6dfb38 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5308876376
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [24.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) (required ≥ B)
<!-- sqra:qg_revision=a2f7449bf64b8c3aff89480d9626acbdd8fc4ad82fc3004cd0e0f2e26965c677 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5381980883
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [26.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) (required ≥ B)
<!-- sqra:qg_revision=2e101675a25b0c591aa7cbf76de3bc2865df521c5dbf8f2c5088a75112615dca -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6335005629
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5302292127
<!-- coverage-grade-bot -->
## 🔴 Test Coverage Grade: `D` — Marginal
| Metric | Value |
|--------|-------|
| Line coverage | **24.50%** |
| Branch coverage | **18.67%** |
### Grade Scale
| Grade | Line Coverage | Meaning |
|-------|--------------|---------|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
> Branch coverage is shown as a secondary signal. Grade is determined by **line coverage**.
> [View full Actions run](https://github.com/apache/cloudstack/actions/runs/31882775860)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5307083126
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [24.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) (required ≥ B)
<!-- sqra:qg_revision=fca24bd0f0b83b0d9d4cc078bf387453de42b6ba2eba00cad4690959ce760373 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5318068523
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5316199363
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [26.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) (required ≥ B)
<!-- sqra:qg_revision=2e101675a25b0c591aa7cbf76de3bc2865df521c5dbf8f2c5088a75112615dca -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5528697074
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5522420826
@DaanHoogland a [SL] Trillian-Jenkins matrix job (ol8 mgmt + kvm-ol8, ubuntu22 mgmt + kvm-ubuntu22, ol8 mgmt + vmware-70u3, ol9 mgmt + xcpng82) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5522394453
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5524170534
<b>[SF] Trillian test result (tid-16885)</b>
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 1580 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16885-vmware-70u3.zip
Smoke tests completed. 0 look OK, 0 have errors, 156 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_2fa | `Skipped` | --- | test_2fa.py
all_test_account_access | `Skipped` | --- | test_account_access.py
all_test_accounts | `Skipped` | --- | test_accounts.py
all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
all_test_annotations | `Skipped` | --- | test_annotations.py
all_test_async_job | `Skipped` | --- | test_async_job.py
all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
all_test_backup_recovery_kboss | `Skipped` | --- | test_backup_recovery_kboss.py
all_test_backup_recovery_nas | `Skipped` | --- | test_backup_recovery_nas.py
all_test_backup_recovery_veeam | `Skipped` | --- | test_backup_recovery_veeam.py
all_test_bucket | `Skipped` | --- | test_bucket.py
all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
all_test_cluster_drs | `Skipped` | --- | test_cluster_drs.py
all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
all_test_create_network | `Skipped` | --- | test_create_network.py
all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
all_test_deploy_vms_in_parallel | `Skipped` | --- | test_deploy_vms_in_parallel.py
all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | test_deploy_vms_with_varied_deploymentplanners.py
all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
all_test_direct_download | `Skipped` | --- | test_direct_download.py
all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
all_test_dns_framework_powerdns | `Skipped` | --- | test_dns_framework_powerdns.py
all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
all_test_events_resource | `Skipped` | --- | test_events_resource.py
all_test_extension_custom_action_lifecycle | `Skipped` | --- | test_extension_custom_action_lifecycle.py
all_test_extension_custom | `Skipped` | --- | test_extension_custom.py
all_test_extension_lifecycle | `Skipped` | --- | test_extension_lifecycle.py
all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
all_test_global_acls | `Skipped` | --- | test_global_acls.py
all_test_global_settings | `Skipped` | --- | test_global_settings.py
all_test_guest_os | `Skipped` | --- | test_guest_os.py
all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
all_test_host_control_state | `Skipped` | --- | test_host_control_state.py
all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
all_test_host_ping | `Skipped` | --- | test_host_ping.py
all_test_host_tags | `Skipped` | --- | test_host_tags.py
all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
all_test_image_store_object_migration | `Skipped` | --- | test_image_store_object_migration.py
all_test_import_unmanage_volumes | `Skipped` | --- | test_import_unmanage_volumes.py
all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
all_test_ipv4_routing | `Skipped` | --- | test_ipv4_routing.py
all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
all_test_iso | `Skipped` | --- | test_iso.py
all_test_kms_lifecycle | `Skipped` | --- | test_kms_lifecycle.py
all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
all_test_list_accounts | `Skipped` | --- | test_list_accounts.py
all_test_list_disk_offerings | `Skipped` | --- | test_list_disk_offerings.py
all_test_list_domains | `Skipped` | --- | test_list_domains.py
all_test_list_hosts | `Skipped` | --- | test_list_hosts.py
all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
all_test_list_service_offerings | `Skipped` | --- | test_list_service_offerings.py
all_test_list_storage_pools | `Skipped` | --- | test_list_storage_pools.py
all_test_list_volumes | `Skipped` | --- | test_list_volumes.py
all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
all_test_login | `Skipped` | --- | test_login.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_migration | `Skipped` | --- | test_migration.py
all_test_ms_maintenance_and_safe_shutdown | `Skipped` | --- | test_ms_maintenance_and_safe_shutdown.py
all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
all_test_network_acl | `Skipped` | --- | test_network_acl.py
all_test_network_extension_namespace | `Skipped` | --- | test_network_extension_namespace.py
all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
all_test_network | `Skipped` | --- | test_network.py
all_test_network_traffic_type_api | `Skipped` | --- | test_network_traffic_type_api.py
all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
all_test_nic | `Skipped` | --- | test_nic.py
all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
all_test_nonstrict_affinity_group | `Skipped` | --- | test_nonstrict_affinity_group.py
all_test_object_stores | `Skipped` | --- | test_object_stores.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
all_test_password_server | `Skipped` | --- | test_password_server.py
all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
all_test_primary_storage_scope | `Skipped` | --- | test_primary_storage_scope.py
all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
all_test_private_roles | `Skipped` | --- | test_private_roles.py
all_test_projects | `Skipped` | --- | test_projects.py
all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
all_test_purge_expunged_vms | `Skipped` | --- | test_purge_expunged_vms.py
all_test_pvlan | `Skipped` | --- | test_pvlan.py
all_test_quarantined_ips | `Skipped` | --- | test_quarantined_ips.py
all_test_regions | `Skipped` | --- | test_regions.py
all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
all_test_resource_names | `Skipped` | --- | test_resource_names.py
all_test_restore_vm | `Skipped` | --- | test_restore_vm.py
all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
all_test_router_dns | `Skipped` | --- | test_router_dns.py
all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
all_test_routers | `Skipped` | --- | test_routers.py
all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
all_test_sharedfs_lifecycle | `Skipped` | --- | test_sharedfs_lifecycle.py
all_test_snapshots | `Skipped` | --- | test_snapshots.py
all_test_ssl_offloading | `Skipped` | --- | test_ssl_offloading.py
all_test_ssvm | `Skipped` | --- | test_ssvm.py
all_test_staticroles | `Skipped` | --- | test_staticroles.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_systemvm_userdata | `Skipped` | --- | test_systemvm_userdata.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_usage | `Skipped` | --- | test_usage.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_lifecycle_unmanage_kvm_import | `Skipped` | --- | test_vm_lifecycle_unmanage_kvm_import.py
all_test_vm_lifecycle_with_snapshot_or_volume | `Skipped` | --- | test_vm_lifecycle_with_snapshot_or_volume.py
all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_vm_strict_host_tags | `Skipped` | --- | test_vm_strict_host_tags.py
all_test_vnf_templates | `Skipped` | --- | test_vnf_templates.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_conserve_mode | `Skipped` | --- | test_vpc_conserve_mode.py
all_test_vpc_firewall_rules | `Skipped` | --- | test_vpc_firewall_rules.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#discussion_r4345588797
##########
engine/schema/src/test/java/com/cloud/storage/dao/StoragePoolTagsDaoImplTest.java:
##########
Review Comment:
`configDepot` is changed from a mocked `ConfigurationDao` to a plain `ConfigDepotImpl` field, but it isn't initialized/mocked before use. As written, `ConfigKey.init(configDepot)` and `when(configDepot.getConfigStringValue(...))` will run with `configDepot == null` and fail with an NPE. Make `configDepot` a Mockito mock (e.g., annotate it with `@Mock`, or assign `Mockito.mock(ConfigDepotImpl.class)` in `setup()` before calling `ConfigKey.init(...)`).
##########
engine/components-api/src/main/java/com/cloud/network/security/SecurityGroupManager.java:
##########
@@ -33,6 +35,23 @@ public interface SecurityGroupManager {
public static final int TIME_BETWEEN_CLEANUPS = 60;
public static final int WORKER_THREAD_COUNT = 10;
+ ConfigKey<Integer> SecurityGroupWorkCleanupInterval = new ConfigKey<>("Network", Integer.class,
+ "network.securitygroups.work.cleanup.interval", "120",
+ "Time interval (seconds) in which finished work is cleaned up from the work table", true);
+
+ ConfigKey<Integer> SecurityGroupWorkerThreads = new ConfigKey<>("Network", Integer.class,
+ "network.securitygroups.workers.pool.size", "50",
Review Comment:
The defaults introduced in the new `ConfigKey`s appear to change behavior vs the prior implementation defaults. In `SecurityGroupManagerImpl`, the old code fell back to `TIME_BETWEEN_CLEANUPS` (60s) and `WORKER_THREAD_COUNT` (10) when config was unset; after this PR it becomes 120s and 50 threads. If the PR intends to be transparent, update these `ConfigKey` default values to match the previous fallbacks (or document/justify the intentional behavioral change).
##########
engine/components-api/src/main/java/com/cloud/network/NetworkStateListener.java:
##########
@@ -38,15 +36,16 @@
public class NetworkStateListener implements StateListener<State, Event, Network> {
- @Inject
- private ConfigurationDao _configDao;
+ // Registered/owned by com.cloud.server.ManagementServer#PublishResourceStateEvent; declared here too so this
+ // module can read it without a reverse dependency on the server module.
+ private static final ConfigKey<Boolean> PublishResourceStateEvent = new ConfigKey<>("Advanced", Boolean.class, "publish.resource.state.events", "true",
+ "enable or disable publishing of alert events on the event bus", true);
Review Comment:
The description for `publish.resource.state.events` says it controls publishing of 'alert events', but this listener publishes *resource state* events. Update the description text to accurately reflect what is being published (resource/network state events) to avoid confusing operators.
##########
engine/schema/src/test/java/com/cloud/storage/dao/StoragePoolTagsDaoImplTest.java:
##########
Review Comment:
`configDepot` is changed from a mocked `ConfigurationDao` to a plain `ConfigDepotImpl` field, but it isn't initialized/mocked before use. As written, `ConfigKey.init(configDepot)` and `when(configDepot.getConfigStringValue(...))` will run with `configDepot == null` and fail with an NPE. Make `configDepot` a Mockito mock (e.g., annotate it with `@Mock`, or assign `Mockito.mock(ConfigDepotImpl.class)` in `setup()` before calling `ConfigKey.init(...)`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6401953015
@DaanHoogland a [SL] Trillian-Jenkins matrix job (ol8 mgmt + kvm-ol8, ubuntu24 mgmt + kvm-ubuntu24, ol8 mgmt + vmware-70u3, ol9 mgmt + xcpng82) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5528383326
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [26.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13884&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) (required ≥ B)
<!-- sqra:qg_revision=2e101675a25b0c591aa7cbf76de3bc2865df521c5dbf8f2c5088a75112615dca -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#discussion_r3957179710
##########
engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java:
##########
@@ -138,6 +138,23 @@ public interface NetworkOrchestrationService {
ConfigKey<Integer> VmNetworkThrottlingRate = new ConfigKey<Integer>("Network", Integer.class, "vm.network.throttling.rate", "200",
"Default data transfer rate in megabits per second allowed in User vm's default network.", true, ConfigKey.Scope.Zone);
+ ConfigKey<String> NetworkLBHaproxyStatsVisbility = new ConfigKey<>("Network", String.class,
+ "network.loadbalancer.haproxy.stats.visibility", "global",
+ "Load Balancer(haproxy) stats visibility, the value can be one of the following six parameters : global,guest-network,link-local,disabled,all,default",
+ true, ConfigKey.Kind.Select, "global,guest-network,link-local,disabled,all,default");
+
+ ConfigKey<String> NetworkLBHaproxyStatsUri = new ConfigKey<>("Network", String.class,
+ "network.loadbalancer.haproxy.stats.uri", "/admin?stats",
+ "Load Balancer(haproxy) uri.", true);
+
+ ConfigKey<String> NetworkLBHaproxyStatsAuth = new ConfigKey<>("Secure", String.class,
+ "network.loadbalancer.haproxy.stats.auth", "admin1:AdMiN123",
+ "Load Balancer(haproxy) authentication string in the format username:password", true);
Review Comment:
The default value hard-codes credentials (\"admin1:AdMiN123\") for HAProxy stats auth. This is an insecure default and risks exposing a known username/password in deployments that don’t override it. Set the default to null/empty and require explicit configuration (or generate a random secret at first startup) while keeping the key marked as Secure.
##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotServiceImpl.java:
##########
@@ -188,12 +188,8 @@ public RevertSnapshotContext(AsyncCompletionCallback<T> callback, SnapshotInfo s
private String generateCopyUrlBase(String hostname, String dir) {
String scheme = "http";
- boolean _sslCopy = false;
- String sslCfg = _configDao.getValue(Config.SecStorageEncryptCopy.toString());
+ boolean _sslCopy = SecondaryStorageVmManager.SecStorageEncryptCopy.value();
String _ssvmUrlDomain = _configDao.getValue("secstorage.ssl.cert.domain");
Review Comment:
This method partially migrated to typed config (`SecStorageEncryptCopy.value()`) but still reads the SSL cert domain via a raw string key. Since this PR is standardizing config handling, prefer `SecondaryStorageVmManager.SecStorageSecureCopyCert.value()` (as done elsewhere) to keep configuration access consistent and centralized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5527451526
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5528099247
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5315232136
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [25.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) (required ≥ B)
<!-- sqra:qg_revision=18a2ad584b29aa9e61149ca46807b81c094d8869582474214dd0d43ffeb6e807 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5515246357
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [26.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13884&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) (required ≥ B)
<!-- sqra:qg_revision=2e101675a25b0c591aa7cbf76de3bc2865df521c5dbf8f2c5088a75112615dca -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5370949558
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6385436127
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6401940737
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#discussion_r4324660413
##########
api/src/main/java/com/cloud/storage/VolumeApiService.java:
##########
@@ -61,6 +61,18 @@ public interface VolumeApiService {
true,
ConfigKey.Scope.Zone);
+ ConfigKey<Integer> CopyVolumeWait = new ConfigKey<>("Storage", Integer.class, "copy.volume.wait", "10800",
+ "In second, timeout for copy volume command", true);
+
+ ConfigKey<Integer> CreateVolumeFromSnapshotWait = new ConfigKey<>("Storage", Integer.class, "create.volume.from.snapshot.wait", "10800",
+ "In second, timeout for creating volume from snapshot", true);
Review Comment:
The description text should use the plural form for units. Consider changing 'In second' to 'In seconds' for clarity.
##########
engine/schema/src/main/java/org/apache/cloudstack/storage/datastore/db/ObjectStoreDaoImpl.java:
##########
Review Comment:
This introduces yet another local `ConfigKey` definition for `detail.batch.query.size` (similar local definitions also exist in other DAO classes). Duplicating the same key in multiple places increases the risk of metadata drift (category/description/scope/defaults diverging). A more maintainable approach is to define this key once in a shared, dependency-safe module (e.g., engine/components-api or engine/api) and reference it everywhere.
##########
engine/components-api/src/main/java/com/cloud/network/NetworkStateListener.java:
##########
Review Comment:
The description for `publish.resource.state.events` is inaccurate: it refers to 'alert events', but this listener publishes *resource state* events. Please update the `ConfigKey` description to match what is actually being published.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6417408654
<b>[SF] Trillian test result (tid-17251)</b>
Environment: kvm-ubuntu24 (x2), zone: Advanced Networking with Mgmt server u24
Total time taken: 63344 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t17251-kvm-ubuntu24.zip
Smoke tests completed. 156 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_hostha_enable_ha_when_host_disabled | `Error` | 3.78 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.86 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6478202036
<b>[SF] Trillian test result (tid-17286)</b>
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 117480 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t17286-xcpng82.zip
Smoke tests completed. 125 look OK, 32 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_readiness_cache_invalidated_on_out_of_band_restart | `Error` | 157.04 | test_instance_boot_group.py
test_02_upgrade_kubernetes_cluster | `Failure` | 1035.65 | test_kubernetes_clusters.py
test_list_system_vms_metrics_history | `Failure` | 0.76 | test_metrics_api.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
test_09_project_suspend | `Error` | 1.14 | test_projects.py
test_10_project_activation | `Error` | 1.11 | test_projects.py
test_deploy_vm_with_registered_userdata | `Error` | 6.85 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` | 6.54 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append | `Error` | 7.11 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny | `Error` | 6.75 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params | `Error` | 6.80 | test_register_userdata.py
test_link_and_unlink_userdata_to_template | `Error` | 7.09 | test_register_userdata.py
test_user_userdata_crud | `Error` | 8.93 | test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
test_02_create_volume | `Error` | 4.37 | test_resource_names.py
test_03_register_template | `Error` | 1.15 | test_resource_names.py
ContextSuite context=TestRestoreVM>:setup | `Error` | 0.00 | test_restore_vm.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
test_01_list_sec_storage_vm | `Failure` | 0.05 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.06 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.06 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.05 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.06 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.06 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.06 | test_ssvm.py
test_09_reboot_ssvm_forced | `Failure` | 0.05 | test_ssvm.py
test_10_reboot_cpvm_forced | `Failure` | 0.05 | test_ssvm.py
test_11_destroy_ssvm | `Failure` | 0.06 | test_ssvm.py
test_12_destroy_cpvm | `Error` | 2.48 | test_ssvm.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.24 | test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.22 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.44 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py
test_01_sys_vm_start | `Failure` | 0.12 | test_secondary_storage.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.34 | test_service_offerings.py
test_04_extract_template | `Failure` | 4.24 | test_templates.py
ContextSuite context=TestSetSourceNatIp>:setup | `Error` | 0.00 | test_set_sourcenat.py
test_01_import_storage_policies | `Error` | 0.00 | test_storage_policy.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup | `Error` | 0.00 | test_snapshots.py
ContextSuite context=TestSslOffloading>:setup | `Error` | 0.00 | test_ssl_offloading.py
test_1_userdata_on_ssvm | `Failure` | 925.00 | test_systemvm_userdata.py
test_2_userdata_on_cpvm | `Failure` | 923.07 | test_systemvm_userdata.py
test_3_userdata_on_vr | `Failure` | 198.47 | test_systemvm_userdata.py
test_01_deploy_vm_on_specific_host | `Error` | 0.15 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 601.41 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 597.90 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 0.17 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 599.23 | test_vm_deployment_planner.py
test_08_migrate_vm | `Error` | 0.08 | test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success | `Error` | 0.34 | test_vm_strict_host_tags.py
test_02_migrate_vm_strict_tags_failure | `Error` | 0.46 | test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success | `Error` | 0.28 | test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure | `Error` | 0.28 | test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success | `Error` | 0.36 | test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure | `Error` | 0.33 | test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags | `Error` | 0.32 | test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags | `Error` | 2.73 | test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success | `Error` | 0.28 | test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success | `Error` | 6.01 | test_vm_strict_host_tags.py
test_05_deploy_vm_on_specific_host_with_strict_tags_failure | `Failure` | 0.35 | test_vm_strict_host_tags.py
test_06_download_detached_volume | `Failure` | 206.30 | test_volumes.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1748.69 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5358887094
<b>[SF] Trillian Build Failed (tid-16787)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5530704166
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [26.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13884&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) (required ≥ B)
<!-- sqra:qg_revision=2e101675a25b0c591aa7cbf76de3bc2865df521c5dbf8f2c5088a75112615dca -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#discussion_r3925838794
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -4576,7 +4575,7 @@ public Long getDiskIopsReadRate(final ServiceOffering offering, final DiskOfferi
if ((diskOffering != null) && (diskOffering.getIopsReadRate() != null) && (diskOffering.getIopsReadRate() > 0)) {
return diskOffering.getIopsReadRate();
} else {
- Long iopsReadRate = Long.parseLong(_configDao.getValue(Config.VmDiskThrottlingIopsReadRate.key()));
+ Long iopsReadRate = Long.parseLong(_configDao.getValue(VmDiskThrottlingIopsReadRate.key()));
if ((iopsReadRate > 0) && ((offering == null) || (!offering.isSystemUse()))) {
return iopsReadRate;
Review Comment:
`Long.parseLong(_configDao.getValue(...))` can throw NPE/NumberFormatException when the config key is missing/unset (e.g., before DB upgrade inserts the new row), and it also bypasses the typed `ConfigKey` default. Prefer using the `ConfigKey` typed accessor for iops throttling to ensure a safe default.
This issue also appears on line 4590 of the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5583906970
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5583883425
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5539489010
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5542687107
@DaanHoogland a [SL] Trillian-Jenkins matrix job (ol8 mgmt + kvm-ol8, ubuntu22 mgmt + kvm-ubuntu22, ol8 mgmt + vmware-70u3, ol9 mgmt + xcpng82) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5542661460
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5339492669
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5325239808
<b>[SF] Trillian Build Failed (tid-16774)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#discussion_r3911817989
##########
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java:
##########
@@ -172,6 +172,22 @@ public interface StorageManager extends StorageService {
ConfigKey<Integer> MaxDataMigrationWaitTime = new ConfigKey<>("Advanced", Integer.class, "max.data.migration.wait.time", "15",
"Maximum wait time (in minutes) for a data migration task before spawning a new SSVM", false, ConfigKey.Scope.Global);
+
+ ConfigKey<Integer> VmDiskThrottlingIopsReadRate = new ConfigKey<>("Advanced", Integer.class, "vm.disk.throttling.iops_read_rate", "0",
+ "Default disk I/O read rate in requests per second allowed in User vm's disk.", true);
+
+ ConfigKey<Integer> VmDiskThrottlingIopsWriteRate = new ConfigKey<>("Advanced", Integer.class, "vm.disk.throttling.iops_write_rate", "0",
+ "Default disk I/O writerate in requests per second allowed in User vm's disk.", true);
+
+ ConfigKey<Integer> VmDiskThrottlingBytesReadRate = new ConfigKey<>("Advanced", Integer.class, "vm.disk.throttling.bytes_read_rate", "0",
+ "Default disk I/O read rate in bytes per second allowed in User vm's disk.", true);
+
+ ConfigKey<Integer> VmDiskThrottlingBytesWriteRate = new ConfigKey<>("Advanced", Integer.class, "vm.disk.throttling.bytes_write_rate", "0",
+ "Default disk I/O writerate in bytes per second allowed in User vm's disk.", true);
Review Comment:
VmDiskThrottlingBytesReadRate/WriteRate are defined as Integer, but these values represent bytes-per-second and can exceed 32-bit ranges on modern systems (and call sites treat them as long). Using ConfigKey<Long> avoids truncation/validation issues for higher throughput limits.
##########
plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/manager/BaremetalManager.java:
##########
@@ -21,11 +21,30 @@
import com.cloud.utils.component.Manager;
import com.cloud.utils.component.PluggableService;
import org.apache.cloudstack.api.BaremetalProvisionDoneNotificationCmd;
+import org.apache.cloudstack.framework.config.ConfigKey;
public interface BaremetalManager extends Manager, PluggableService {
public static final String EchoSecurityGroupAgent = "EchoSecurityGroupAgent";
public static final String ExternalBaremetalSystemUrl = "ExternalBaremetalSystemUrl";
public static final String DO_PXE = "doPxe";
+ ConfigKey<String> BaremetalInternalStorageServer = new ConfigKey<>("Advanced", String.class, "baremetal.internal.storage.server.ip", null,
+ "the ip address of server that stores kickstart file, kernel, initrd, ISO for advanced networking baremetal provisioning", true);
+
+ ConfigKey<Integer> BaremetalProvisionDoneNotificationTimeout = new ConfigKey<>("Advanced", Integer.class, "baremetal.provision.done.notification.timeout", "1800",
+ "the max time to wait before treating a baremetal provision as failure if no provision done notification is not received, in secs", true);
+
+ ConfigKey<String> ExternalBaremetalResourceClassName = new ConfigKey<>("Advanced", String.class, "external.baremetal.resource.classname", null,
+ "class name for handling external baremetal resource", true);
+
+ ConfigKey<Boolean> EnableBaremetalSecurityGroupAgentEcho = new ConfigKey<>("Advanced", Boolean.class, "enable.baremetal.securitygroup.agent.echo", "false",
+ "After starting provision process, periodcially echo security agent installed in the template. Treat provisioning as success only if echo successfully", true);
+
+ ConfigKey<String> BaremetalIpmiLanInterface = new ConfigKey<>("Advanced", String.class, "baremetal.ipmi.lan.interface", "default",
+ "option specified in -I option of impitool. candidates are: open/bmc/lipmi/lan/lanplus/free/imb, see ipmitool man page for details. default value 'default' means using default option of ipmitool", true);
+
+ ConfigKey<String> BaremetalIpmiRetryTimes = new ConfigKey<>("Advanced", String.class, "baremetal.ipmi.fail.retry", "5",
+ "ipmi interface will be temporary out of order after power operations(e.g. cycle, on), it leads following commands fail immediately. The value specifies retry times before accounting it as real failure", true);
Review Comment:
BaremetalIpmiRetryTimes is used as an integer retry count but is declared as ConfigKey<String>. Using ConfigKey<Integer> would provide type safety and avoid manual parsing at call sites (and allow consistent validation).
##########
server/src/main/java/com/cloud/network/ExternalLoadBalancerDeviceManager.java:
##########
@@ -36,6 +38,9 @@ public interface ExternalLoadBalancerDeviceManager extends Manager {
public static final int DEFAULT_LOAD_BALANCER_CAPACITY = 50;
+ ConfigKey<String> DefaultExternalLoadBalancerCapacity = new ConfigKey<>("Advanced", String.class, "external.lb.default.capacity", "50",
+ "default number of networks permitted per external load balancer device", true);
Review Comment:
DefaultExternalLoadBalancerCapacity represents a numeric capacity but is declared as ConfigKey<String>, which weakens type validation and forces call sites to parse/handle invalid values at runtime. Prefer a numeric ConfigKey type (e.g., Integer/Long) and update usages to consume the typed value directly.
##########
server/src/main/java/com/cloud/network/ExternalFirewallDeviceManager.java:
##########
@@ -34,14 +36,16 @@
public interface ExternalFirewallDeviceManager extends Manager {
+ ConfigKey<String> DefaultExternalFirewallCapacity = new ConfigKey<>("Advanced", String.class, "external.firewall.default.capacity", "50",
+ "default number of networks permitted per external load firewall device", true);
Review Comment:
DefaultExternalFirewallCapacity is a numeric capacity but is declared as ConfigKey<String>, which bypasses ConfigKey's numeric typing/validation and pushes parsing errors to runtime. Prefer a numeric ConfigKey type (e.g., Integer/Long) and adjust call sites accordingly.
##########
plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/manager/BaremetalManager.java:
##########
@@ -21,11 +21,30 @@
import com.cloud.utils.component.Manager;
import com.cloud.utils.component.PluggableService;
import org.apache.cloudstack.api.BaremetalProvisionDoneNotificationCmd;
+import org.apache.cloudstack.framework.config.ConfigKey;
public interface BaremetalManager extends Manager, PluggableService {
public static final String EchoSecurityGroupAgent = "EchoSecurityGroupAgent";
public static final String ExternalBaremetalSystemUrl = "ExternalBaremetalSystemUrl";
public static final String DO_PXE = "doPxe";
+ ConfigKey<String> BaremetalInternalStorageServer = new ConfigKey<>("Advanced", String.class, "baremetal.internal.storage.server.ip", null,
+ "the ip address of server that stores kickstart file, kernel, initrd, ISO for advanced networking baremetal provisioning", true);
+
+ ConfigKey<Integer> BaremetalProvisionDoneNotificationTimeout = new ConfigKey<>("Advanced", Integer.class, "baremetal.provision.done.notification.timeout", "1800",
+ "the max time to wait before treating a baremetal provision as failure if no provision done notification is not received, in secs", true);
+
+ ConfigKey<String> ExternalBaremetalResourceClassName = new ConfigKey<>("Advanced", String.class, "external.baremetal.resource.classname", null,
+ "class name for handling external baremetal resource", true);
+
+ ConfigKey<Boolean> EnableBaremetalSecurityGroupAgentEcho = new ConfigKey<>("Advanced", Boolean.class, "enable.baremetal.securitygroup.agent.echo", "false",
+ "After starting provision process, periodcially echo security agent installed in the template. Treat provisioning as success only if echo successfully", true);
+
+ ConfigKey<String> BaremetalIpmiLanInterface = new ConfigKey<>("Advanced", String.class, "baremetal.ipmi.lan.interface", "default",
+ "option specified in -I option of impitool. candidates are: open/bmc/lipmi/lan/lanplus/free/imb, see ipmitool man page for details. default value 'default' means using default option of ipmitool", true);
Review Comment:
Typo in config description: "impitool" should be "ipmitool".
##########
server/src/main/java/com/cloud/storage/secondary/SecondaryStorageVmManager.java:
##########
@@ -50,6 +50,41 @@ public interface SecondaryStorageVmManager extends Manager {
true, ConfigKey.Scope.Zone, null, "User Data for SSVMs",
null, ConfigKey.GROUP_SYSTEM_VMS, ConfigKey.SUBGROUP_SEC_STORAGE_VM);
+ ConfigKey<Boolean> UseSecondaryStorageVm = new ConfigKey<>("Hidden", Boolean.class, "secondary.storage.vm", "false",
+ "Deploys a VM per zone to manage secondary storage if true, otherwise secondary storage is mounted on management server", true);
+
+ ConfigKey<String> MountParent = new ConfigKey<>("Advanced", String.class, "mount.parent", "/var/cloudstack/mnt",
+ "The mount point on the Management Server for Secondary Storage.", true);
+
+ ConfigKey<Boolean> SystemVMAutoReserveCapacity = new ConfigKey<>("Advanced", Boolean.class, "system.vm.auto.reserve.capacity", "true",
+ "Indicates whether or not to automatically reserver system VM standby capacity.", true);
Review Comment:
Typo in config description: "reserver" should be "reserve".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5514348593
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5514343091
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6290257953
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 19628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6384809898
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5303348735
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [23.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) (required ≥ B)
<!-- sqra:qg_revision=c0a7a310b6ae7e9fc4f9475317a9107ee03c911c6f86ce75626f753831bfe31b -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5308233287
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [24.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) (required ≥ B)
<!-- sqra:qg_revision=a2f7449bf64b8c3aff89480d9626acbdd8fc4ad82fc3004cd0e0f2e26965c677 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5325246443
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [26.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) (required ≥ B)
<!-- sqra:qg_revision=2e101675a25b0c591aa7cbf76de3bc2865df521c5dbf8f2c5088a75112615dca -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5491560450
<b>[SF] Trillian Build Failed (tid-16861)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5530258341
<b>[SF] Trillian test result (tid-16892)</b>
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 1514 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16892-vmware-70u3.zip
Smoke tests completed. 0 look OK, 0 have errors, 156 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_2fa | `Skipped` | --- | test_2fa.py
all_test_account_access | `Skipped` | --- | test_account_access.py
all_test_accounts | `Skipped` | --- | test_accounts.py
all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
all_test_annotations | `Skipped` | --- | test_annotations.py
all_test_async_job | `Skipped` | --- | test_async_job.py
all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
all_test_backup_recovery_kboss | `Skipped` | --- | test_backup_recovery_kboss.py
all_test_backup_recovery_nas | `Skipped` | --- | test_backup_recovery_nas.py
all_test_backup_recovery_veeam | `Skipped` | --- | test_backup_recovery_veeam.py
all_test_bucket | `Skipped` | --- | test_bucket.py
all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
all_test_cluster_drs | `Skipped` | --- | test_cluster_drs.py
all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
all_test_create_network | `Skipped` | --- | test_create_network.py
all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
all_test_deploy_vms_in_parallel | `Skipped` | --- | test_deploy_vms_in_parallel.py
all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | test_deploy_vms_with_varied_deploymentplanners.py
all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
all_test_direct_download | `Skipped` | --- | test_direct_download.py
all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
all_test_dns_framework_powerdns | `Skipped` | --- | test_dns_framework_powerdns.py
all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
all_test_events_resource | `Skipped` | --- | test_events_resource.py
all_test_extension_custom_action_lifecycle | `Skipped` | --- | test_extension_custom_action_lifecycle.py
all_test_extension_custom | `Skipped` | --- | test_extension_custom.py
all_test_extension_lifecycle | `Skipped` | --- | test_extension_lifecycle.py
all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
all_test_global_acls | `Skipped` | --- | test_global_acls.py
all_test_global_settings | `Skipped` | --- | test_global_settings.py
all_test_guest_os | `Skipped` | --- | test_guest_os.py
all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
all_test_host_control_state | `Skipped` | --- | test_host_control_state.py
all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
all_test_host_ping | `Skipped` | --- | test_host_ping.py
all_test_host_tags | `Skipped` | --- | test_host_tags.py
all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
all_test_image_store_object_migration | `Skipped` | --- | test_image_store_object_migration.py
all_test_import_unmanage_volumes | `Skipped` | --- | test_import_unmanage_volumes.py
all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
all_test_ipv4_routing | `Skipped` | --- | test_ipv4_routing.py
all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
all_test_iso | `Skipped` | --- | test_iso.py
all_test_kms_lifecycle | `Skipped` | --- | test_kms_lifecycle.py
all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
all_test_list_accounts | `Skipped` | --- | test_list_accounts.py
all_test_list_disk_offerings | `Skipped` | --- | test_list_disk_offerings.py
all_test_list_domains | `Skipped` | --- | test_list_domains.py
all_test_list_hosts | `Skipped` | --- | test_list_hosts.py
all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
all_test_list_service_offerings | `Skipped` | --- | test_list_service_offerings.py
all_test_list_storage_pools | `Skipped` | --- | test_list_storage_pools.py
all_test_list_volumes | `Skipped` | --- | test_list_volumes.py
all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
all_test_login | `Skipped` | --- | test_login.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_migration | `Skipped` | --- | test_migration.py
all_test_ms_maintenance_and_safe_shutdown | `Skipped` | --- | test_ms_maintenance_and_safe_shutdown.py
all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
all_test_network_acl | `Skipped` | --- | test_network_acl.py
all_test_network_extension_namespace | `Skipped` | --- | test_network_extension_namespace.py
all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
all_test_network | `Skipped` | --- | test_network.py
all_test_network_traffic_type_api | `Skipped` | --- | test_network_traffic_type_api.py
all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
all_test_nic | `Skipped` | --- | test_nic.py
all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
all_test_nonstrict_affinity_group | `Skipped` | --- | test_nonstrict_affinity_group.py
all_test_object_stores | `Skipped` | --- | test_object_stores.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
all_test_password_server | `Skipped` | --- | test_password_server.py
all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
all_test_primary_storage_scope | `Skipped` | --- | test_primary_storage_scope.py
all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
all_test_private_roles | `Skipped` | --- | test_private_roles.py
all_test_projects | `Skipped` | --- | test_projects.py
all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
all_test_purge_expunged_vms | `Skipped` | --- | test_purge_expunged_vms.py
all_test_pvlan | `Skipped` | --- | test_pvlan.py
all_test_quarantined_ips | `Skipped` | --- | test_quarantined_ips.py
all_test_regions | `Skipped` | --- | test_regions.py
all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
all_test_resource_names | `Skipped` | --- | test_resource_names.py
all_test_restore_vm | `Skipped` | --- | test_restore_vm.py
all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
all_test_router_dns | `Skipped` | --- | test_router_dns.py
all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
all_test_routers | `Skipped` | --- | test_routers.py
all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
all_test_sharedfs_lifecycle | `Skipped` | --- | test_sharedfs_lifecycle.py
all_test_snapshots | `Skipped` | --- | test_snapshots.py
all_test_ssl_offloading | `Skipped` | --- | test_ssl_offloading.py
all_test_ssvm | `Skipped` | --- | test_ssvm.py
all_test_staticroles | `Skipped` | --- | test_staticroles.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_systemvm_userdata | `Skipped` | --- | test_systemvm_userdata.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_usage | `Skipped` | --- | test_usage.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_lifecycle_unmanage_kvm_import | `Skipped` | --- | test_vm_lifecycle_unmanage_kvm_import.py
all_test_vm_lifecycle_with_snapshot_or_volume | `Skipped` | --- | test_vm_lifecycle_with_snapshot_or_volume.py
all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_vm_strict_host_tags | `Skipped` | --- | test_vm_strict_host_tags.py
all_test_vnf_templates | `Skipped` | --- | test_vnf_templates.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_conserve_mode | `Skipped` | --- | test_vpc_conserve_mode.py
all_test_vpc_firewall_rules | `Skipped` | --- | test_vpc_firewall_rules.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5530313863
<b>[SF] Trillian test result (tid-16890)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 1610 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t16890-kvm-ol8.zip
Smoke tests completed. 0 look OK, 0 have errors, 156 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
all_test_2fa | `Skipped` | --- | test_2fa.py
all_test_account_access | `Skipped` | --- | test_account_access.py
all_test_accounts | `Skipped` | --- | test_accounts.py
all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
all_test_annotations | `Skipped` | --- | test_annotations.py
all_test_async_job | `Skipped` | --- | test_async_job.py
all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
all_test_backup_recovery_kboss | `Skipped` | --- | test_backup_recovery_kboss.py
all_test_backup_recovery_nas | `Skipped` | --- | test_backup_recovery_nas.py
all_test_backup_recovery_veeam | `Skipped` | --- | test_backup_recovery_veeam.py
all_test_bucket | `Skipped` | --- | test_bucket.py
all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
all_test_cluster_drs | `Skipped` | --- | test_cluster_drs.py
all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
all_test_create_network | `Skipped` | --- | test_create_network.py
all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
all_test_deploy_vms_in_parallel | `Skipped` | --- | test_deploy_vms_in_parallel.py
all_test_deploy_vms_with_varied_deploymentplanners | `Skipped` | --- | test_deploy_vms_with_varied_deploymentplanners.py
all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
all_test_direct_download | `Skipped` | --- | test_direct_download.py
all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
all_test_dns_framework_powerdns | `Skipped` | --- | test_dns_framework_powerdns.py
all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
all_test_events_resource | `Skipped` | --- | test_events_resource.py
all_test_extension_custom_action_lifecycle | `Skipped` | --- | test_extension_custom_action_lifecycle.py
all_test_extension_custom | `Skipped` | --- | test_extension_custom.py
all_test_extension_lifecycle | `Skipped` | --- | test_extension_lifecycle.py
all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
all_test_global_acls | `Skipped` | --- | test_global_acls.py
all_test_global_settings | `Skipped` | --- | test_global_settings.py
all_test_guest_os | `Skipped` | --- | test_guest_os.py
all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
all_test_host_control_state | `Skipped` | --- | test_host_control_state.py
all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
all_test_host_ping | `Skipped` | --- | test_host_ping.py
all_test_host_tags | `Skipped` | --- | test_host_tags.py
all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
all_test_image_store_object_migration | `Skipped` | --- | test_image_store_object_migration.py
all_test_import_unmanage_volumes | `Skipped` | --- | test_import_unmanage_volumes.py
all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
all_test_ipv4_routing | `Skipped` | --- | test_ipv4_routing.py
all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
all_test_iso | `Skipped` | --- | test_iso.py
all_test_kms_lifecycle | `Skipped` | --- | test_kms_lifecycle.py
all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
all_test_list_accounts | `Skipped` | --- | test_list_accounts.py
all_test_list_disk_offerings | `Skipped` | --- | test_list_disk_offerings.py
all_test_list_domains | `Skipped` | --- | test_list_domains.py
all_test_list_hosts | `Skipped` | --- | test_list_hosts.py
all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
all_test_list_service_offerings | `Skipped` | --- | test_list_service_offerings.py
all_test_list_storage_pools | `Skipped` | --- | test_list_storage_pools.py
all_test_list_volumes | `Skipped` | --- | test_list_volumes.py
all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
all_test_login | `Skipped` | --- | test_login.py
all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
all_test_migration | `Skipped` | --- | test_migration.py
all_test_ms_maintenance_and_safe_shutdown | `Skipped` | --- | test_ms_maintenance_and_safe_shutdown.py
all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
all_test_network_acl | `Skipped` | --- | test_network_acl.py
all_test_network_extension_namespace | `Skipped` | --- | test_network_extension_namespace.py
all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
all_test_network | `Skipped` | --- | test_network.py
all_test_network_traffic_type_api | `Skipped` | --- | test_network_traffic_type_api.py
all_test_nic_adapter_type | `Skipped` | --- | test_nic_adapter_type.py
all_test_nic | `Skipped` | --- | test_nic.py
all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
all_test_nonstrict_affinity_group | `Skipped` | --- | test_nonstrict_affinity_group.py
all_test_object_stores | `Skipped` | --- | test_object_stores.py
all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
all_test_password_server | `Skipped` | --- | test_password_server.py
all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
all_test_primary_storage_scope | `Skipped` | --- | test_primary_storage_scope.py
all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
all_test_private_roles | `Skipped` | --- | test_private_roles.py
all_test_projects | `Skipped` | --- | test_projects.py
all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
all_test_purge_expunged_vms | `Skipped` | --- | test_purge_expunged_vms.py
all_test_pvlan | `Skipped` | --- | test_pvlan.py
all_test_quarantined_ips | `Skipped` | --- | test_quarantined_ips.py
all_test_regions | `Skipped` | --- | test_regions.py
all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
all_test_resource_names | `Skipped` | --- | test_resource_names.py
all_test_restore_vm | `Skipped` | --- | test_restore_vm.py
all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
all_test_router_dns | `Skipped` | --- | test_router_dns.py
all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
all_test_routers | `Skipped` | --- | test_routers.py
all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
all_test_sharedfs_lifecycle | `Skipped` | --- | test_sharedfs_lifecycle.py
all_test_snapshots | `Skipped` | --- | test_snapshots.py
all_test_ssl_offloading | `Skipped` | --- | test_ssl_offloading.py
all_test_ssvm | `Skipped` | --- | test_ssvm.py
all_test_staticroles | `Skipped` | --- | test_staticroles.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_systemvm_userdata | `Skipped` | --- | test_systemvm_userdata.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_usage | `Skipped` | --- | test_usage.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_lifecycle_unmanage_kvm_import | `Skipped` | --- | test_vm_lifecycle_unmanage_kvm_import.py
all_test_vm_lifecycle_with_snapshot_or_volume | `Skipped` | --- | test_vm_lifecycle_with_snapshot_or_volume.py
all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_vm_strict_host_tags | `Skipped` | --- | test_vm_strict_host_tags.py
all_test_vnf_templates | `Skipped` | --- | test_vnf_templates.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_conserve_mode | `Skipped` | --- | test_vpc_conserve_mode.py
all_test_vpc_firewall_rules | `Skipped` | --- | test_vpc_firewall_rules.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5514907343
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5508089280
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5584760543
## [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884) **Quality Gate failed**
Failed conditions
 [26.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=13884&metric=new_coverage&view=list) (required ≥ 40%)
 [C Reliability Rating on New Code](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=13884&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) (required ≥ B)
<!-- sqra:qg_revision=2e101675a25b0c591aa7cbf76de3bc2865df521c5dbf8f2c5088a75112615dca -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=13884)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-5584492423
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6290048041
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6290027115
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6336499688
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6335027267
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#discussion_r4345737139
##########
engine/schema/src/test/java/com/cloud/storage/dao/StoragePoolTagsDaoImplTest.java:
##########
@@ -47,7 +49,7 @@
public class StoragePoolTagsDaoImplTest extends TestCase {
@Mock
- ConfigurationDao _configDao;
+ ConfigDepotImpl configDepot;
Review Comment:
`configDepot` is no longer annotated as a Mockito mock in the diff (it’s declared as a field but not guaranteed to be initialized). As written, `ConfigKey.init(configDepot)` and `when(configDepot.getConfigStringValue(...))` will throw a `NullPointerException` if `configDepot` is null. Make `configDepot` an actual Mockito mock (e.g., annotate it properly and ensure Mockito initialization runs, or instantiate it via `Mockito.mock(ConfigDepotImpl.class)` in `setup()`).
##########
engine/schema/src/test/java/com/cloud/storage/dao/StoragePoolTagsDaoImplTest.java:
##########
@@ -70,19 +72,25 @@ public class StoragePoolTagsDaoImplTest extends TestCase {
@Before
public void setup() {
- when(_configDao.getValue(batchSizeConfigurationKey)).thenReturn(batchSizeValue);
+ ConfigKey.init(configDepot);
+ when(configDepot.getConfigStringValue(batchSizeConfigurationKey, ConfigKey.Scope.Global, null)).thenReturn(batchSizeValue);
Review Comment:
`configDepot` is no longer annotated as a Mockito mock in the diff (it’s declared as a field but not guaranteed to be initialized). As written, `ConfigKey.init(configDepot)` and `when(configDepot.getConfigStringValue(...))` will throw a `NullPointerException` if `configDepot` is null. Make `configDepot` an actual Mockito mock (e.g., annotate it properly and ensure Mockito initialization runs, or instantiate it via `Mockito.mock(ConfigDepotImpl.class)` in `setup()`).
##########
engine/components-api/src/main/java/com/cloud/network/NetworkStateListener.java:
##########
@@ -38,15 +36,16 @@
public class NetworkStateListener implements StateListener<State, Event, Network> {
- @Inject
- private ConfigurationDao _configDao;
+ // Registered/owned by com.cloud.server.ManagementServer#PublishResourceStateEvent; declared here too so this
+ // module can read it without a reverse dependency on the server module.
+ private static final ConfigKey<Boolean> PublishResourceStateEvent = new ConfigKey<>("Advanced", Boolean.class, "publish.resource.state.events", "true",
+ "enable or disable publishing of alert events on the event bus", true);
Review Comment:
The `PublishResourceStateEvent` description says it controls publishing of \"alert events\", but this listener publishes *resource state* events. Update the description to match the behavior to avoid confusing operators and future maintainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] config cleanup [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #13884:
URL: https://github.com/apache/cloudstack/pull/13884#issuecomment-6433925150
<b>[SF] Trillian test result (tid-17253)</b>
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 117760 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13884-t17253-xcpng82.zip
Smoke tests completed. 79 look OK, 24 have errors, 54 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestIpv4Routing>:setup | `Error` | 0.00 | test_ipv4_routing.py
test_01_create_iso_with_checksum_sha1 | `Error` | 66.52 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 66.51 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 66.55 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 66.61 | test_iso.py
test_01_create_iso | `Failure` | 1515.65 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3030.50 | test_iso.py
test_04_readiness_cache_invalidated_on_out_of_band_restart | `Error` | 152.34 | test_instance_boot_group.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle | `Error` | 0.01 | test_kubernetes_clusters.py
test_12_test_deploy_cluster_different_offerings_per_node_type | `Failure` | 0.00 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 1802.38 | test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
ContextSuite context=TestListVolumes>:setup | `Error` | 0.00 | test_list_volumes.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
ContextSuite context=TestAdapterTypeForNic>:setup | `Error` | 0.00 | test_nic_adapter_type.py
ContextSuite context=TestMetrics>:setup | `Error` | 0.00 | test_metrics_api.py
test_nic_secondaryip_add_remove | `Error` | 1515.43 | test_multipleips_per_nic.py
test_delete_account | `Error` | 1514.59 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 1.17 | test_network.py
test_deploy_vm_l2network | `Error` | 1.17 | test_network.py
test_l2network_restart | `Error` | 2.26 | test_network.py
ContextSuite context=TestPortForwarding>:setup | `Error` | 3.44 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 5.20 | test_network.py
test_reboot_router | `Failure` | 0.06 | test_network.py
test_releaseIP | `Error` | 2.66 | test_network.py
test_releaseIP_using_IP | `Error` | 2.74 | test_network.py
ContextSuite context=TestRouterRules>:setup | `Error` | 2.81 | test_network.py
test_01_deployVMInSharedNetwork | `Failure` | 3694.40 | test_network.py
test_03_destroySharedNetwork | `Failure` | 1.09 | test_network.py
ContextSuite context=TestSharedNetwork>:teardown | `Error` | 2.21 | test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup | `Error` | 1516.96 | test_network.py
ContextSuite context=TestNestedVirtualization>:setup | `Error` | 0.00 | test_nested_virtualization.py
test_01_nic | `Error` | 1514.67 | test_nic.py
ContextSuite context=TestNetworkACL>:setup | `Error` | 0.00 | test_network_acl.py
ContextSuite context=TestIpv6Network>:setup | `Error` | 0.00 | test_network_ipv6.py
ContextSuite context=TestNetworkPermissions>:setup | `Error` | 0.00 | test_network_permissions.py
ContextSuite context=TestNonStrictAffinityGroups>:setup | `Error` | 0.00 | test_nonstrict_affinity_group.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Error` | 0.09 | test_persistent_network.py
ContextSuite context=TestPortForwardingRules>:setup | `Error` | 0.00 | test_portforwardingrules.py
test_01_add_primary_storage_disabled_host | `Error` | 1516.07 | test_primary_storage.py
test_01_primary_storage_iscsi | `Error` | 307.41 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.23 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.39 | test_primary_storage.py
ContextSuite context=TestPrivateGwACL>:setup | `Error` | 0.00 | test_privategw_acl.py
ContextSuite context=TestProjectSuspendActivate>:setup | `Error` | 1520.96 | test_projects.py
all_test_purge_expunged_vms | `Skipped` | --- | test_purge_expunged_vms.py
all_test_pvlan | `Skipped` | --- | test_pvlan.py
all_test_quarantined_ips | `Skipped` | --- | test_quarantined_ips.py
all_test_regions | `Skipped` | --- | test_regions.py
all_test_register_userdata | `Skipped` | --- | test_register_userdata.py
all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
all_test_resource_names | `Skipped` | --- | test_resource_names.py
all_test_restore_vm | `Skipped` | --- | test_restore_vm.py
all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
all_test_router_dns | `Skipped` | --- | test_router_dns.py
all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
all_test_routers_network_ops | `Skipped` | --- | test_routers_network_ops.py
all_test_routers | `Skipped` | --- | test_routers.py
all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
all_test_set_sourcenat | `Skipped` | --- | test_set_sourcenat.py
all_test_sharedfs_lifecycle | `Skipped` | --- | test_sharedfs_lifecycle.py
all_test_snapshots | `Skipped` | --- | test_snapshots.py
all_test_ssl_offloading | `Skipped` | --- | test_ssl_offloading.py
all_test_ssvm | `Skipped` | --- | test_ssvm.py
all_test_staticroles | `Skipped` | --- | test_staticroles.py
all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
all_test_systemvm_userdata | `Skipped` | --- | test_systemvm_userdata.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
all_test_usage_events | `Skipped` | --- | test_usage_events.py
all_test_usage | `Skipped` | --- | test_usage.py
all_test_vm_autoscaling | `Skipped` | --- | test_vm_autoscaling.py
all_test_vm_deployment_planner | `Skipped` | --- | test_vm_deployment_planner.py
all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
all_test_vm_lifecycle_unmanage_kvm_import | `Skipped` | --- | test_vm_lifecycle_unmanage_kvm_import.py
all_test_vm_lifecycle_with_snapshot_or_volume | `Skipped` | --- | test_vm_lifecycle_with_snapshot_or_volume.py
all_test_vm_schedule | `Skipped` | --- | test_vm_schedule.py
all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
all_test_vm_strict_host_tags | `Skipped` | --- | test_vm_strict_host_tags.py
all_test_vnf_templates | `Skipped` | --- | test_vnf_templates.py
all_test_volumes | `Skipped` | --- | test_volumes.py
all_test_vpc_conserve_mode | `Skipped` | --- | test_vpc_conserve_mode.py
all_test_vpc_firewall_rules | `Skipped` | --- | test_vpc_firewall_rules.py
all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
all_test_webhook_delivery | `Skipped` | --- | test_webhook_delivery.py
all_test_webhook_lifecycle | `Skipped` | --- | test_webhook_lifecycle.py
all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org