You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Udo Kohlmeyer <uk...@gmail.com> on 2016/11/30 17:20:03 UTC
Review Request 54209: GEODE-1931: CI Failure:
LocatorUDPSecurityDUnitTest.testStartTwoLocators
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54209/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
Repository: geode
Description
-------
Refactored the LocatorDUnitTest and LocatorUDPSecurityDUnitTest to best match our new practices with Lambdas and Awaitility blocks rather than Wait.pause + WaitCriterion
Diffs
-----
geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java 128f970
geode-core/src/test/java/org/apache/geode/distributed/LocatorUDPSecurityDUnitTest.java 3246f85
Diff: https://reviews.apache.org/r/54209/diff/
Testing
-------
Precheckin - completed
Thanks,
Udo Kohlmeyer
Re: Review Request 54209: GEODE-1931: CI Failure:
LocatorUDPSecurityDUnitTest.testStartTwoLocators
Posted by Udo Kohlmeyer <uk...@gmail.com>.
> On Nov. 30, 2016, 6:49 p.m., Bruce Schuchardt wrote:
> > I don't see anything wrong here - lots of improvements. Was there anything that you corrected in the test other than getting rid of pauses and WaitCriteria? How about running the test a few hundred times before checking it in?
Correct. Lots of small improvements. I ran the test over 100 times without any failure.
- Udo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54209/#review157432
-----------------------------------------------------------
On Nov. 30, 2016, 5:20 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54209/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 5:20 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Refactored the LocatorDUnitTest and LocatorUDPSecurityDUnitTest to best match our new practices with Lambdas and Awaitility blocks rather than Wait.pause + WaitCriterion
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java 128f970
> geode-core/src/test/java/org/apache/geode/distributed/LocatorUDPSecurityDUnitTest.java 3246f85
>
> Diff: https://reviews.apache.org/r/54209/diff/
>
>
> Testing
> -------
>
> Precheckin - completed
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>
Re: Review Request 54209: GEODE-1931: CI Failure:
LocatorUDPSecurityDUnitTest.testStartTwoLocators
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54209/#review157432
-----------------------------------------------------------
Ship it!
I don't see anything wrong here - lots of improvements. Was there anything that you corrected in the test other than getting rid of pauses and WaitCriteria? How about running the test a few hundred times before checking it in?
- Bruce Schuchardt
On Nov. 30, 2016, 5:20 p.m., Udo Kohlmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54209/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 5:20 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Hitesh Khamesra.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Refactored the LocatorDUnitTest and LocatorUDPSecurityDUnitTest to best match our new practices with Lambdas and Awaitility blocks rather than Wait.pause + WaitCriterion
>
>
> Diffs
> -----
>
> geode-core/src/test/java/org/apache/geode/distributed/LocatorDUnitTest.java 128f970
> geode-core/src/test/java/org/apache/geode/distributed/LocatorUDPSecurityDUnitTest.java 3246f85
>
> Diff: https://reviews.apache.org/r/54209/diff/
>
>
> Testing
> -------
>
> Precheckin - completed
>
>
> Thanks,
>
> Udo Kohlmeyer
>
>