You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2016/05/31 07:16:51 UTC

[1/4] camel git commit: Fixed potential NPE

Repository: camel
Updated Branches:
  refs/heads/camel-2.17.x 1e179aae1 -> f276b5fbe
  refs/heads/master ab4f85bf3 -> 2aab2fb23


Fixed potential NPE


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/d3ad0f08
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/d3ad0f08
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/d3ad0f08

Branch: refs/heads/master
Commit: d3ad0f080a6d9fce8822347b90eb8cdc26220421
Parents: ab4f85b
Author: Claus Ibsen <da...@apache.org>
Authored: Tue May 31 08:07:30 2016 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Tue May 31 08:07:30 2016 +0200

----------------------------------------------------------------------
 .../apache/camel/component/bean/ConstantBeanHolder.java   | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/d3ad0f08/camel-core/src/main/java/org/apache/camel/component/bean/ConstantBeanHolder.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/component/bean/ConstantBeanHolder.java b/camel-core/src/main/java/org/apache/camel/component/bean/ConstantBeanHolder.java
index d2cbe1c..1965d2b 100644
--- a/camel-core/src/main/java/org/apache/camel/component/bean/ConstantBeanHolder.java
+++ b/camel-core/src/main/java/org/apache/camel/component/bean/ConstantBeanHolder.java
@@ -40,11 +40,17 @@ public class ConstantBeanHolder implements BeanHolder {
     }
 
     public ConstantBeanHolder(Object bean, CamelContext context) {
-        this(bean, new BeanInfo(context, bean.getClass()));
+        ObjectHelper.notNull(bean, "bean");
+
+        this.bean = bean;
+        this.beanInfo = new BeanInfo(context, bean.getClass());
     }
 
     public ConstantBeanHolder(Object bean, CamelContext context, ParameterMappingStrategy parameterMappingStrategy) {
-        this(bean, new BeanInfo(context, bean.getClass(), parameterMappingStrategy));
+        ObjectHelper.notNull(bean, "bean");
+
+        this.bean = bean;
+        this.beanInfo = new BeanInfo(context, bean.getClass(), parameterMappingStrategy);
     }
 
     @Override


[2/4] camel git commit: CAMEL-10001: Add support for using any property placeholders on load balancers

Posted by da...@apache.org.
CAMEL-10001: Add support for using any property placeholders on load balancers


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/2aab2fb2
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/2aab2fb2
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/2aab2fb2

Branch: refs/heads/master
Commit: 2aab2fb23570771c2019551029c65109373cb5df
Parents: d3ad0f0
Author: Claus Ibsen <da...@apache.org>
Authored: Tue May 31 08:14:00 2016 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Tue May 31 08:14:00 2016 +0200

----------------------------------------------------------------------
 .../camel/model/LoadBalancerDefinition.java     | 18 +++++++++++++++-
 .../camel/model/config/ResequencerConfig.java   | 22 +++++++++++++++++++-
 2 files changed, 38 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/2aab2fb2/camel-core/src/main/java/org/apache/camel/model/LoadBalancerDefinition.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/model/LoadBalancerDefinition.java b/camel-core/src/main/java/org/apache/camel/model/LoadBalancerDefinition.java
index 4d4a37c..a219f9e 100644
--- a/camel-core/src/main/java/org/apache/camel/model/LoadBalancerDefinition.java
+++ b/camel-core/src/main/java/org/apache/camel/model/LoadBalancerDefinition.java
@@ -16,10 +16,13 @@
  */
 package org.apache.camel.model;
 
+import java.util.Map;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlAnyAttribute;
 import javax.xml.bind.annotation.XmlTransient;
 import javax.xml.bind.annotation.XmlType;
+import javax.xml.namespace.QName;
 
 import org.apache.camel.processor.loadbalancer.LoadBalancer;
 import org.apache.camel.spi.Metadata;
@@ -33,11 +36,14 @@ import org.apache.camel.util.ObjectHelper;
 @Metadata(label = "eip,routing")
 @XmlType(name = "loadBalancer")
 @XmlAccessorType(XmlAccessType.FIELD)
-public class LoadBalancerDefinition extends IdentifiedType {
+public class LoadBalancerDefinition extends IdentifiedType implements OtherAttributesAware {
     @XmlTransient
     private LoadBalancer loadBalancer;
     @XmlTransient
     private String loadBalancerTypeName;
+    // use xs:any to support optional property placeholders
+    @XmlAnyAttribute
+    private Map<QName, Object> otherAttributes;
 
     public LoadBalancerDefinition() {
     }
@@ -82,6 +88,16 @@ public class LoadBalancerDefinition extends IdentifiedType {
         this.loadBalancer = loadBalancer;
     }
 
+    @Override
+    public Map<QName, Object> getOtherAttributes() {
+        return otherAttributes;
+    }
+
+    @Override
+    public void setOtherAttributes(Map<QName, Object> otherAttributes) {
+        this.otherAttributes = otherAttributes;
+    }
+
     /**
      * Factory method to create the load balancer from the loadBalancerTypeName
      */

http://git-wip-us.apache.org/repos/asf/camel/blob/2aab2fb2/camel-core/src/main/java/org/apache/camel/model/config/ResequencerConfig.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/model/config/ResequencerConfig.java b/camel-core/src/main/java/org/apache/camel/model/config/ResequencerConfig.java
index 5e55445..624eafa 100644
--- a/camel-core/src/main/java/org/apache/camel/model/config/ResequencerConfig.java
+++ b/camel-core/src/main/java/org/apache/camel/model/config/ResequencerConfig.java
@@ -16,11 +16,31 @@
  */
 package org.apache.camel.model.config;
 
+import java.util.Map;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlAnyAttribute;
 import javax.xml.bind.annotation.XmlType;
+import javax.xml.namespace.QName;
+
+import org.apache.camel.model.OtherAttributesAware;
 
 @XmlType(name = "resequencerConfig")
 @XmlAccessorType(XmlAccessType.FIELD)
-public abstract class ResequencerConfig {
+public abstract class ResequencerConfig implements OtherAttributesAware {
+
+    // use xs:any to support optional property placeholders
+    @XmlAnyAttribute
+    private Map<QName, Object> otherAttributes;
+
+    @Override
+    public Map<QName, Object> getOtherAttributes() {
+        return otherAttributes;
+    }
+
+    @Override
+    public void setOtherAttributes(Map<QName, Object> otherAttributes) {
+        this.otherAttributes = otherAttributes;
+    }
+
 }


[3/4] camel git commit: Fixed potential NPE

Posted by da...@apache.org.
Fixed potential NPE


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/d0186a41
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/d0186a41
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/d0186a41

Branch: refs/heads/camel-2.17.x
Commit: d0186a417588abfcd8f1707b2befd62e00dbf715
Parents: 1e179aa
Author: Claus Ibsen <da...@apache.org>
Authored: Tue May 31 08:07:30 2016 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Tue May 31 09:16:19 2016 +0200

----------------------------------------------------------------------
 .../apache/camel/component/bean/ConstantBeanHolder.java   | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/d0186a41/camel-core/src/main/java/org/apache/camel/component/bean/ConstantBeanHolder.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/component/bean/ConstantBeanHolder.java b/camel-core/src/main/java/org/apache/camel/component/bean/ConstantBeanHolder.java
index d2cbe1c..1965d2b 100644
--- a/camel-core/src/main/java/org/apache/camel/component/bean/ConstantBeanHolder.java
+++ b/camel-core/src/main/java/org/apache/camel/component/bean/ConstantBeanHolder.java
@@ -40,11 +40,17 @@ public class ConstantBeanHolder implements BeanHolder {
     }
 
     public ConstantBeanHolder(Object bean, CamelContext context) {
-        this(bean, new BeanInfo(context, bean.getClass()));
+        ObjectHelper.notNull(bean, "bean");
+
+        this.bean = bean;
+        this.beanInfo = new BeanInfo(context, bean.getClass());
     }
 
     public ConstantBeanHolder(Object bean, CamelContext context, ParameterMappingStrategy parameterMappingStrategy) {
-        this(bean, new BeanInfo(context, bean.getClass(), parameterMappingStrategy));
+        ObjectHelper.notNull(bean, "bean");
+
+        this.bean = bean;
+        this.beanInfo = new BeanInfo(context, bean.getClass(), parameterMappingStrategy);
     }
 
     @Override


[4/4] camel git commit: CAMEL-10001: Add support for using any property placeholders on load balancers

Posted by da...@apache.org.
CAMEL-10001: Add support for using any property placeholders on load balancers


Project: http://git-wip-us.apache.org/repos/asf/camel/repo
Commit: http://git-wip-us.apache.org/repos/asf/camel/commit/f276b5fb
Tree: http://git-wip-us.apache.org/repos/asf/camel/tree/f276b5fb
Diff: http://git-wip-us.apache.org/repos/asf/camel/diff/f276b5fb

Branch: refs/heads/camel-2.17.x
Commit: f276b5fbe1aa1d18fbd3bd3ab17fe42d3961f757
Parents: d0186a4
Author: Claus Ibsen <da...@apache.org>
Authored: Tue May 31 08:14:00 2016 +0200
Committer: Claus Ibsen <da...@apache.org>
Committed: Tue May 31 09:16:30 2016 +0200

----------------------------------------------------------------------
 .../camel/model/LoadBalancerDefinition.java     | 18 +++++++++++++++-
 .../camel/model/config/ResequencerConfig.java   | 22 +++++++++++++++++++-
 2 files changed, 38 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/camel/blob/f276b5fb/camel-core/src/main/java/org/apache/camel/model/LoadBalancerDefinition.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/model/LoadBalancerDefinition.java b/camel-core/src/main/java/org/apache/camel/model/LoadBalancerDefinition.java
index 4d4a37c..a219f9e 100644
--- a/camel-core/src/main/java/org/apache/camel/model/LoadBalancerDefinition.java
+++ b/camel-core/src/main/java/org/apache/camel/model/LoadBalancerDefinition.java
@@ -16,10 +16,13 @@
  */
 package org.apache.camel.model;
 
+import java.util.Map;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlAnyAttribute;
 import javax.xml.bind.annotation.XmlTransient;
 import javax.xml.bind.annotation.XmlType;
+import javax.xml.namespace.QName;
 
 import org.apache.camel.processor.loadbalancer.LoadBalancer;
 import org.apache.camel.spi.Metadata;
@@ -33,11 +36,14 @@ import org.apache.camel.util.ObjectHelper;
 @Metadata(label = "eip,routing")
 @XmlType(name = "loadBalancer")
 @XmlAccessorType(XmlAccessType.FIELD)
-public class LoadBalancerDefinition extends IdentifiedType {
+public class LoadBalancerDefinition extends IdentifiedType implements OtherAttributesAware {
     @XmlTransient
     private LoadBalancer loadBalancer;
     @XmlTransient
     private String loadBalancerTypeName;
+    // use xs:any to support optional property placeholders
+    @XmlAnyAttribute
+    private Map<QName, Object> otherAttributes;
 
     public LoadBalancerDefinition() {
     }
@@ -82,6 +88,16 @@ public class LoadBalancerDefinition extends IdentifiedType {
         this.loadBalancer = loadBalancer;
     }
 
+    @Override
+    public Map<QName, Object> getOtherAttributes() {
+        return otherAttributes;
+    }
+
+    @Override
+    public void setOtherAttributes(Map<QName, Object> otherAttributes) {
+        this.otherAttributes = otherAttributes;
+    }
+
     /**
      * Factory method to create the load balancer from the loadBalancerTypeName
      */

http://git-wip-us.apache.org/repos/asf/camel/blob/f276b5fb/camel-core/src/main/java/org/apache/camel/model/config/ResequencerConfig.java
----------------------------------------------------------------------
diff --git a/camel-core/src/main/java/org/apache/camel/model/config/ResequencerConfig.java b/camel-core/src/main/java/org/apache/camel/model/config/ResequencerConfig.java
index 5e55445..624eafa 100644
--- a/camel-core/src/main/java/org/apache/camel/model/config/ResequencerConfig.java
+++ b/camel-core/src/main/java/org/apache/camel/model/config/ResequencerConfig.java
@@ -16,11 +16,31 @@
  */
 package org.apache.camel.model.config;
 
+import java.util.Map;
 import javax.xml.bind.annotation.XmlAccessType;
 import javax.xml.bind.annotation.XmlAccessorType;
+import javax.xml.bind.annotation.XmlAnyAttribute;
 import javax.xml.bind.annotation.XmlType;
+import javax.xml.namespace.QName;
+
+import org.apache.camel.model.OtherAttributesAware;
 
 @XmlType(name = "resequencerConfig")
 @XmlAccessorType(XmlAccessType.FIELD)
-public abstract class ResequencerConfig {
+public abstract class ResequencerConfig implements OtherAttributesAware {
+
+    // use xs:any to support optional property placeholders
+    @XmlAnyAttribute
+    private Map<QName, Object> otherAttributes;
+
+    @Override
+    public Map<QName, Object> getOtherAttributes() {
+        return otherAttributes;
+    }
+
+    @Override
+    public void setOtherAttributes(Map<QName, Object> otherAttributes) {
+        this.otherAttributes = otherAttributes;
+    }
+
 }