[GitHub] [incubator-superset] etr2460 opened a new pull request #8011: [SQL Lab] Improve perf for filterable table rendering

[GitBox <gi...@apache.org>]

etr2460 opened a new pull request #8011: [SQL Lab] Improve perf for filterable table rendering
URL: https://github.com/apache/incubator-superset/pull/8011
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Uses @kristw's new `getMultipleTextDimensions` to improve perf about 3x for FilterableTable rendering
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Ensure tables in sql lab still render properly
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @kristw @graceguo-supercat @betodealmeida 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org