[GitHub] [hudi] yihua commented on a diff in pull request #6704: [HUDI-4780] improve test setup

[GitBox <gi...@apache.org>]

yihua commented on code in PR #6704:
URL: https://github.com/apache/hudi/pull/6704#discussion_r977876557


##########
hudi-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java:
##########
@@ -124,12 +125,13 @@ public static void tearDownClass() {
 
   @BeforeEach
   public void setUp() throws IOException, InterruptedException {
-    this.fs = MiniClusterUtil.fileSystem;
+    FileSystem fileSystemOriginal = MiniClusterUtil.fileSystem;
 
-    assertTrue(fs.mkdirs(new Path(tempDir.toAbsolutePath().toString())));
+    assertTrue(fileSystemOriginal.mkdirs(new Path(tempDir.toAbsolutePath().toString())));
     this.partitionPath = new Path(tempDir.toAbsolutePath().toString());
     this.basePath = tempDir.getParent().toString();
-    HoodieTestUtils.init(MiniClusterUtil.configuration, basePath, HoodieTableType.MERGE_ON_READ);
+    HoodieTableMetaClient init = HoodieTestUtils.init(MiniClusterUtil.configuration, basePath, HoodieTableType.MERGE_ON_READ);
+    this.fs = init.getFs();

Review Comment:
   Got it.  Could you point out which set of tests fail without your previous fix (#6602) after this PR?  We should add some comments on these tests mentioning that they test the logic around creating new log files based the size configured.   If there are no such test, we should add one.  Let me know if this makes sense.  We can sync up through Hudi Slack.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org