You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Joris Van den Bossche (Jira)" <ji...@apache.org> on 2022/09/23 07:42:00 UTC
[jira] [Updated] (ARROW-17823) [C++] Prefer std::make_shared/std::make_unique over constructor with new
[ https://issues.apache.org/jira/browse/ARROW-17823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joris Van den Bossche updated ARROW-17823:
------------------------------------------
Summary: [C++] Prefer std::make_shared/std::make_unique over constructor with new (was: Prefer std::make_shared/std::make_unique over constructor with new)
> [C++] Prefer std::make_shared/std::make_unique over constructor with new
> ------------------------------------------------------------------------
>
> Key: ARROW-17823
> URL: https://issues.apache.org/jira/browse/ARROW-17823
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Affects Versions: 9.0.0
> Reporter: Jin Shang
> Assignee: Jin Shang
> Priority: Minor
> Labels: pull-request-available
> Fix For: 10.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Advantage: readabilty, exception safety and efficiency(only for shared_ptr).
> Cases that don't apply: When calling a private/protected constructor within class member function, make_shared/unique can't work.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)