You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/26 13:35:23 UTC

[GitHub] [flink] wsry commented on a change in pull request #13239: [FLINK-19021][network] Various cleanups and refactorings of the ResultPartition

wsry commented on a change in pull request #13239:
URL: https://github.com/apache/flink/pull/13239#discussion_r477304810



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java
##########
@@ -120,9 +120,7 @@ protected void emit(T record, int targetChannel) throws IOException, Interrupted
 		serializer.serializeRecord(record);
 
 		// Make sure we don't hold onto the large intermediate serialization buffer for too long

Review comment:
       We may also remove this comment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org