You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/20 21:18:44 UTC

[GitHub] [arrow] codecov-io edited a comment on pull request #8975: ARROW-10990: [Rust] Refactor simd comparison kernels to avoid out of bounds reads

codecov-io edited a comment on pull request #8975:
URL: https://github.com/apache/arrow/pull/8975#issuecomment-748643987


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/8975?src=pr&el=h1) Report
   > Merging [#8975](https://codecov.io/gh/apache/arrow/pull/8975?src=pr&el=desc) (0b18645) into [master](https://codecov.io/gh/apache/arrow/commit/5eb6ce18e110fe6534ab08f158dc0b8a2744e59e?el=desc) (5eb6ce1) will **decrease** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/8975/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/8975?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8975      +/-   ##
   ==========================================
   - Coverage   83.19%   83.17%   -0.02%     
   ==========================================
     Files         199      200       +1     
     Lines       48661    48968     +307     
   ==========================================
   + Hits        40482    40731     +249     
   - Misses       8179     8237      +58     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/8975?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/arrow/src/datatypes.rs](https://codecov.io/gh/apache/arrow/pull/8975/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvZGF0YXR5cGVzLnJz) | `76.45% <ø> (ø)` | |
   | [rust/arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow/pull/8975/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2NvbXBhcmlzb24ucnM=) | `96.44% <100.00%> (+0.15%)` | :arrow_up: |
   | [rust/arrow/src/compute/kernels/sort.rs](https://codecov.io/gh/apache/arrow/pull/8975/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3NvcnQucnM=) | `93.42% <0.00%> (-2.34%)` | :arrow_down: |
   | [rust/arrow/src/compute/util.rs](https://codecov.io/gh/apache/arrow/pull/8975/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS91dGlsLnJz) | `98.93% <0.00%> (-0.44%)` | :arrow_down: |
   | [rust/arrow/src/array/cast.rs](https://codecov.io/gh/apache/arrow/pull/8975/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvY2FzdC5ycw==) | `100.00% <0.00%> (ø)` | |
   | [rust/benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow/pull/8975/diff?src=pr&el=tree#diff-cnVzdC9iZW5jaG1hcmtzL3NyYy9iaW4vdHBjaC5ycw==) | `0.00% <0.00%> (ø)` | |
   | [rust/datafusion/src/physical\_plan/planner.rs](https://codecov.io/gh/apache/arrow/pull/8975/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3BsYW5uZXIucnM=) | `80.45% <0.00%> (ø)` | |
   | [...datafusion/src/optimizer/hash\_build\_probe\_order.rs](https://codecov.io/gh/apache/arrow/pull/8975/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvaGFzaF9idWlsZF9wcm9iZV9vcmRlci5ycw==) | `59.09% <0.00%> (ø)` | |
   | [rust/datafusion/src/execution/context.rs](https://codecov.io/gh/apache/arrow/pull/8975/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9leGVjdXRpb24vY29udGV4dC5ycw==) | `90.00% <0.00%> (+0.01%)` | :arrow_up: |
   | [rust/datafusion/src/physical\_plan/hash\_join.rs](https://codecov.io/gh/apache/arrow/pull/8975/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfam9pbi5ycw==) | `92.77% <0.00%> (+0.06%)` | :arrow_up: |
   | ... and [4 more](https://codecov.io/gh/apache/arrow/pull/8975/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/8975?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/8975?src=pr&el=footer). Last update [5eb6ce1...0b18645](https://codecov.io/gh/apache/arrow/pull/8975?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org