You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Cliff Woolley <cl...@yahoo.com> on 2001/06/18 20:04:53 UTC
[PATCH] duplicated lines in winnt mpm
The recent talk about -DONE_PROCESS and -DNO_DETACH made me want to go
through all the MPM's and verify that they worked like we thought they did
in that regard. I didn't find any problems, but I did find a set of
duplicated lines in mpm_winnt.c. It seems to have happened when there was
a search and replace for getenv("ONE_PROCESS") to
ap_exists_config_define("ONE_PROCESS"). Can anybody see any reason that I
shouldn't commit this?
Index: mpm_winnt.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/mpm/winnt/mpm_winnt.c,v
retrieving revision 1.158
diff -u -d -r1.158 mpm_winnt.c
--- mpm_winnt.c 2001/05/17 12:36:05 1.158
+++ mpm_winnt.c 2001/06/18 18:00:45
@@ -1781,9 +1781,6 @@
if (ap_exists_config_define("ONE_PROCESS"))
one_process = -1;
- if (ap_exists_config_define("ONE_PROCESS"))
- one_process = -1;
-
if (!strcasecmp(signal_arg, "runservice")
&& (osver.dwPlatformId == VER_PLATFORM_WIN32_NT)
&& (service_to_start_success != APR_SUCCESS)) {
--------------------------------------------------------------
Cliff Woolley
cliffwoolley@yahoo.com
Charlottesville, VA
Re: [PATCH] duplicated lines in winnt mpm
Posted by Cliff Woolley <cl...@yahoo.com>.
On 18 Jun 2001, Jeff Trawick wrote:
> > ... Can anybody see any reason that I shouldn't commit this?
>
> . to see how long it takes somebody without commit access to post this
> patch...
>
> . maybe it's faster with the extra code in there...
>
> . I don't see the problem...
Gee, thanks. ;-]
--------------------------------------------------------------
Cliff Woolley
cliffwoolley@yahoo.com
Charlottesville, VA
Re: [PATCH] duplicated lines in winnt mpm
Posted by Jeff Trawick <tr...@attglobal.net>.
Cliff Woolley <cl...@yahoo.com> writes:
> ... Can anybody see any reason that I
> shouldn't commit this?
. to see how long it takes somebody without commit access to post this
patch...
. maybe it's faster with the extra code in there...
. I don't see the problem...
> Index: mpm_winnt.c
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/server/mpm/winnt/mpm_winnt.c,v
> retrieving revision 1.158
> diff -u -d -r1.158 mpm_winnt.c
> --- mpm_winnt.c 2001/05/17 12:36:05 1.158
> +++ mpm_winnt.c 2001/06/18 18:00:45
> @@ -1781,9 +1781,6 @@
> if (ap_exists_config_define("ONE_PROCESS"))
> one_process = -1;
>
> - if (ap_exists_config_define("ONE_PROCESS"))
> - one_process = -1;
> -
> if (!strcasecmp(signal_arg, "runservice")
> && (osver.dwPlatformId == VER_PLATFORM_WIN32_NT)
> && (service_to_start_success != APR_SUCCESS)) {
--
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...