You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2024/09/28 00:28:33 UTC
[PR] read metadata in SimpleQueryableIndex if available to compute segment ordering (druid)
clintropolis opened a new pull request, #17181:
URL: https://github.com/apache/druid/pull/17181
#16700 made `QueryableIndex.getMetadata` be 'lazy', which is kind of nice in some ways since we don't have to hang on to the segment metadata object unless we need it, however changes in #16533, #16849, and #16985 made it so that we read the segment "ordering" every time we make a cursor, which seems pretty unchill with the lazy metadata reading.
This PR makes it so that we precompute the ordering in `SimpleQueryableIndex` constructor so that `getOrdering` is a cheap call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] read metadata in SimpleQueryableIndex if available to compute segment ordering (druid)
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis merged PR #17181:
URL: https://github.com/apache/druid/pull/17181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org