You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jeff-cyft <gi...@git.apache.org> on 2017/02/02 16:54:05 UTC
[GitHub] zeppelin pull request #1969: [ZEPPELIN-1465] Add an option to allow S3 serve...
GitHub user jeff-cyft opened a pull request:
https://github.com/apache/zeppelin/pull/1969
[ZEPPELIN-1465] Add an option to allow S3 server-side encryption
### What is this PR for?
Provide a configuration option that will cause the S3 Notebook repo to request server-side encryption of saved notebooks.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1465
### How should this be tested?
Enable the configuration option, save a notebook in zeppelin, and confirm in the AWS S3 Console that the related file was saved with AES-256 encryption on the server-side. (Properties tab, Detail section)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No.
* Does this needs documentation?
I added mentions of the new option in existing documentation.
Thank you!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeff-cyft/zeppelin s3_sse
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1969.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1969
----
commit 3c657ac64bc2d2b264d27a747a47020b0a42a527
Author: Jeff Plourde <jp...@cyft.io>
Date: 2017-02-02T16:03:49Z
Configuration option to request S3 SSE when notebooks are saved.
commit 26f5264a0694249f6b5880e5de5a476d3cb9beaf
Author: Jeff Plourde <jp...@cyft.io>
Date: 2017-02-02T16:09:57Z
code style - remove tab
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1969: [ZEPPELIN-1465] Add an option to allow S3 server-side ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1969
Thanks @jeff-cyft for the contribution!
LGTM and merge to master if no further discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1969: [ZEPPELIN-1465] Add an option to allow S3 server-side ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1969
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1969: [ZEPPELIN-1465] Add an option to allow S3 serve...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1969
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---