You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/29 23:15:11 UTC

[GitHub] [apisix] XFarooqi opened a new pull request, #8589: docs: fix typo and grammatical error

XFarooqi opened a new pull request, #8589:
URL: https://github.com/apache/apisix/pull/8589

   There was ambiguity in line 170 regarding the statement. Hence I use the “if” statement to make it more understandable. Moreover, in line 273 the “out” was not used appropriately. It should be either used after the “filter” or we should not use it.
   
   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   Talking about changes, only grammatical errors are being updated because they were creating some ambiguity in the documentation. The motivation behind this change is that any user who came to read the documentation should understand at once what this code is doing and what the documentation is saying.
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan merged pull request #8589: docs: fix typo and grammatical error

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged PR #8589:
URL: https://github.com/apache/apisix/pull/8589


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org