You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2026/10/29 05:35:31 UTC
[I] refactor(core): remove the timeline layout 1 branch of rollback completion [hudi-rs]
yihua opened a new issue, #862:
URL: https://github.com/apache/hudi-rs/issues/862
## Summary
Rollback completion in `crates/core/src/write/rollback.rs` has a branch for timeline layout 1 that uses the rollback instant as its own completion time and writes `{rb}_{rb}.rollback`. Layout 1 has no completion times and names a completed rollback `{rb}.rollback`, so Java's layout 1 parser rejects that name. The branch looks unreachable: every write verb that can roll back requires table version 8 or 9, which config validation pairs with layout 2, and the table version 6 append path never rolls back.
## Proposal
Confirm the branch is unreachable, then remove it or turn it into an error, so coverage reflects the live paths and a future layout 1 writer cannot inherit the wrong name.
Raised in the #666 review follow-up list (item 17).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org