You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/04/02 10:36:20 UTC
[GitHub] [incubator-echarts] 100pah opened a new pull request #12371: fix:
axis min/max function return null:
100pah opened a new pull request #12371: fix: axis min/max function return null:
URL: https://github.com/apache/incubator-echarts/pull/12371
The original PR is: #12215
cf5812f6aad64e433c0de89c62bd0d84b7f3f0cf
Fix from that:
(1) The min/max function call should not be called twice (necessary and probably wrong input params).
(2) `fixMin` `fixMax` should cover function return.
(3) Add more test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] 100pah merged pull request #12371: fix: axis
min/max function return null:
Posted by GitBox <gi...@apache.org>.
100pah merged pull request #12371: fix: axis min/max function return null:
URL: https://github.com/apache/incubator-echarts/pull/12371
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12371:
fix: axis min/max function return null:
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12371: fix: axis min/max function return null:
URL: https://github.com/apache/incubator-echarts/pull/12371#issuecomment-607764535
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12371:
fix: axis min/max function return null:
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12371: fix: axis min/max function return null:
URL: https://github.com/apache/incubator-echarts/pull/12371#issuecomment-607849319
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org