You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ustcweizhou <gi...@git.apache.org> on 2017/01/11 08:49:11 UTC
[GitHub] cloudstack pull request #1901: CLOUDSTACK-9405: add details parameter in lis...
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/1901
CLOUDSTACK-9405: add details parameter in listDomains API to reduce the execution time
The resource limitation causes long time while execute listDomains API. The resources are not needed in some cases so that the execution time will be reduced.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ustcweizhou/cloudstack listDomains-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1901.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1901
----
commit 471139eaa71a155add894ac9c1c1277f80264894
Author: Wei Zhou <w....@tech.leaseweb.com>
Date: 2016-11-14T10:57:59Z
CLOUDSTACK-9405: add details parameter in listDomains API to reduce the execution time
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1901: [4.9] CLOUDSTACK-9405: add details parameter ...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1901#discussion_r95948158
--- Diff: api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java ---
@@ -53,6 +59,12 @@
description = "If set to false, list only resources belonging to the command's caller; if set to true - list resources that the caller is authorized to see. Default value is false")
private Boolean listAll;
+ @Parameter(name = ApiConstants.DETAILS,
+ type = CommandType.LIST,
+ collectionType = CommandType.STRING,
+ description = "comma separated list of host details requested, value can be a list of [ all, resource, min]")
--- End diff --
@serg38 currently no difference. However if we want to add more type of details, then it will be useful. for example, we add a new detail type: stats in our branch.
the defition is copied from listhosts API (you can see host details in the decription, I will change it).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1901: [4.9] CLOUDSTACK-9405: add details parameter ...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1901#discussion_r95828294
--- Diff: api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java ---
@@ -53,6 +59,12 @@
description = "If set to false, list only resources belonging to the command's caller; if set to true - list resources that the caller is authorized to see. Default value is false")
private Boolean listAll;
+ @Parameter(name = ApiConstants.DETAILS,
+ type = CommandType.LIST,
+ collectionType = CommandType.STRING,
+ description = "comma separated list of host details requested, value can be a list of [ all, resource, min]")
--- End diff --
Can you clarify what would be permitted values for details parameter? If they are only "min", resource", "all" then we might want to change the name and description of this parameter to reflect true purpose. What is the difference between 'resource' and 'all'?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1901: [4.9] CLOUDSTACK-9405: add details parameter in list...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1901
@serg38 what do you want to validate if it is necessary ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1901: CLOUDSTACK-9405: add details parameter in listDomain...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1901
Thanks @ustcweizhou . We have been planning to address this for a while. Should we create a smoke test to verify validity of the modified listDomain call?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1901: [4.9] CLOUDSTACK-9405: add details parameter in list...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1901
LGTM, @ustcweizhou can you add a marvin test to validate api changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1901: [4.9] CLOUDSTACK-9405: add details parameter in list...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1901
Thanks @ustcweizhou LGTM for code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---