[GitHub] [flink] twalthr commented on a diff in pull request #21056: [FLINK-29379][datastream] Example of using Configuration to store ExecutionConfig fields

[GitBox <gi...@apache.org>]

twalthr commented on code in PR #21056:
URL: https://github.com/apache/flink/pull/21056#discussion_r996751165


##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -746,7 +797,11 @@ public boolean isObjectReuseEnabled() {
     }
 
     public GlobalJobParameters getGlobalJobParameters() {

Review Comment:
   We should solve this differently. `GlobalJobParameters` should be a simple `Map<String, String>`. Maybe we keep those fields in `ExecutionConfig` (not backed by Configuration) and deprecate the corresponding setters and getters and replace them with better long-term API.
   
   Even our examples show how to extend from global job parameters:
   https://github.com/apache/flink/blob/master/flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/TopSpeedWindowing.java#L83
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org