You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "srowen (via GitHub)" <gi...@apache.org> on 2023/03/10 17:09:57 UTC
[GitHub] [spark] srowen commented on a diff in pull request #40278: [SPARK-42670][BUILD] Upgrade maven-surefire-plugin to 3.0.0-M9 & eliminate build warnings
srowen commented on code in PR #40278:
URL: https://github.com/apache/spark/pull/40278#discussion_r1132636160
##########
pom.xml:
##########
@@ -2957,7 +2957,7 @@
<JAVA_HOME>${test.java.home}</JAVA_HOME>
<SPARK_BEELINE_OPTS>-DmyKey=yourValue</SPARK_BEELINE_OPTS>
</environmentVariables>
- <systemProperties>
+ <systemPropertyVariables>
Review Comment:
Does it hurt to make this change now? still works in Maven 3.8 and just prepares for 3.9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org