You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/23 13:59:32 UTC
[GitHub] [incubator-inlong] Greedyu opened a new pull request, #4326: [INLONG-4325][Manager] Fix registration sql function exception
Greedyu opened a new pull request, #4326:
URL: https://github.com/apache/incubator-inlong/pull/4326
Fix registration sql function exception
Fixes #4325
Druid provides a built-in StatFilter for statistical monitoring information. Turning it on and off will not affect its own program. official documentation：
https://github.com/alibaba/druid/wiki/%E9%85%8D%E7%BD%AE_StatFilter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #4326: [INLONG-4325][Manager] Fix registration SQL function exception
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4326:
URL: https://github.com/apache/incubator-inlong/pull/4326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] Greedyu commented on a diff in pull request #4326: [INLONG-4325][Manager] Fix registration sql function exception
Posted by GitBox <gi...@apache.org>.
Greedyu commented on code in PR #4326:
URL: https://github.com/apache/incubator-inlong/pull/4326#discussion_r879998942
##########
inlong-manager/manager-web/src/main/resources/application-test.properties:
##########
@@ -44,7 +44,7 @@ spring.datasource.druid.testOnReturn=false
# Configure filters for monitoring statistics interception, stat:monitoring statistics, log4j:log, wall:defense against SQL injection
spring.datasource.druid.filters=stat,wall
# Open the mergeSql function through the connectProperties property, Slow SQL records
-spring.datasource.druid.connectionProperties=druid.stat.mergeSql=true;druid.stat.slowSqlMillis=5000
+spring.datasource.druid.connectionProperties=druid.stat.mergeSql=false;druid.stat.slowSqlMillis=5000
Review Comment:
Yes, because the WebBaseTest class is based on the BaseTest class, and BaseTest belongs to the manager-test module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4326: [INLONG-4325][Manager] Fix registration sql function exception
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4326:
URL: https://github.com/apache/incubator-inlong/pull/4326#discussion_r879588634
##########
inlong-manager/manager-web/src/main/resources/application-test.properties:
##########
@@ -44,7 +44,7 @@ spring.datasource.druid.testOnReturn=false
# Configure filters for monitoring statistics interception, stat:monitoring statistics, log4j:log, wall:defense against SQL injection
spring.datasource.druid.filters=stat,wall
# Open the mergeSql function through the connectProperties property, Slow SQL records
-spring.datasource.druid.connectionProperties=druid.stat.mergeSql=true;druid.stat.slowSqlMillis=5000
+spring.datasource.druid.connectionProperties=druid.stat.mergeSql=false;druid.stat.slowSqlMillis=5000
Review Comment:
Did it really need to change the config in the manager-web module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] Greedyu commented on a diff in pull request #4326: [INLONG-4325][Manager] Fix registration sql function exception
Posted by GitBox <gi...@apache.org>.
Greedyu commented on code in PR #4326:
URL: https://github.com/apache/incubator-inlong/pull/4326#discussion_r879998942
##########
inlong-manager/manager-web/src/main/resources/application-test.properties:
##########
@@ -44,7 +44,7 @@ spring.datasource.druid.testOnReturn=false
# Configure filters for monitoring statistics interception, stat:monitoring statistics, log4j:log, wall:defense against SQL injection
spring.datasource.druid.filters=stat,wall
# Open the mergeSql function through the connectProperties property, Slow SQL records
-spring.datasource.druid.connectionProperties=druid.stat.mergeSql=true;druid.stat.slowSqlMillis=5000
+spring.datasource.druid.connectionProperties=druid.stat.mergeSql=false;druid.stat.slowSqlMillis=5000
Review Comment:
Yes, because the WebBaseTest class is based on the BaseTest class, and BaseTest belongs to the manager-test module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] Greedyu commented on a diff in pull request #4326: [INLONG-4325][Manager] Fix registration sql function exception
Posted by GitBox <gi...@apache.org>.
Greedyu commented on code in PR #4326:
URL: https://github.com/apache/incubator-inlong/pull/4326#discussion_r880516238
##########
inlong-manager/manager-web/src/main/resources/application-test.properties:
##########
@@ -44,7 +44,7 @@ spring.datasource.druid.testOnReturn=false
# Configure filters for monitoring statistics interception, stat:monitoring statistics, log4j:log, wall:defense against SQL injection
spring.datasource.druid.filters=stat,wall
# Open the mergeSql function through the connectProperties property, Slow SQL records
-spring.datasource.druid.connectionProperties=druid.stat.mergeSql=true;druid.stat.slowSqlMillis=5000
+spring.datasource.druid.connectionProperties=druid.stat.mergeSql=false;druid.stat.slowSqlMillis=5000
Review Comment:
resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org