You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by pgajdos <pg...@suse.cz> on 2019/01/29 10:15:04 UTC
[testsuite] negotiation.t: fails for older versions
Hello,
I propose following patch, as PR39730 was fixed recently.
--- t/modules/negotiation.t.orig 2019-01-29 07:49:18.495899602 +0000
+++ t/modules/negotiation.t 2019-01-29 07:52:38.428960368 +0000
@@ -8,7 +8,11 @@ use Apache::TestUtil;
## mod_negotiation test (see extra.conf.in)
my ($en, $fr, $de, $fu, $bu, $zh) = qw(en fr de fu bu zh-TW);
-my @language = ($en, $fr, $de, $fu, $zh);
+
+my @language = ($en, $fr, $de, $fu);
+if (have_min_apache_version("2.4.38")) {
+ push @language, $zh;
+}
my @ct_tests = (
# [ Accept header, Expected response ]
Petr
Re: [testsuite] negotiation.t: fails for older versions
Posted by Eric Covener <co...@gmail.com>.
Thanks for the patch and reminder, committed in r1855982.
On Thu, Mar 21, 2019 at 5:48 AM pgajdos <pg...@suse.cz> wrote:
>
> On Tue, Jan 29, 2019 at 11:15:04AM +0100, pgajdos wrote:
> > Hello,
> >
> > I propose following patch, as PR39730 was fixed recently.
>
> What do you think about the patch? Should it be amended somehow?
>
> Thanks!
> Petr
--
Eric Covener
covener@gmail.com
Re: [testsuite] negotiation.t: fails for older versions
Posted by pgajdos <pg...@suse.cz>.
On Tue, Jan 29, 2019 at 11:15:04AM +0100, pgajdos wrote:
> Hello,
>
> I propose following patch, as PR39730 was fixed recently.
What do you think about the patch? Should it be amended somehow?
Thanks!
Petr