You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "McCaig, Rhys" <Rh...@comcast.com> on 2018/09/11 07:39:56 UTC

Re: [EXTERNAL] [VOTE] KIP-158: Kafka Connect should allow source connectors to set topic-specific settings for new topics

Looks great Randall 
+1 (non-binding)

> On Sep 9, 2018, at 7:17 PM, Gwen Shapira <gw...@confluent.io> wrote:
> 
> +1
> Useful improvement, thanks Randall.
> 
> 
> On Fri, Sep 7, 2018, 3:28 PM Randall Hauch <rh...@gmail.com> wrote:
> 
>> I believe the feedback on KIP-158 has been addressed. I'd like to start a
>> vote.
>> 
>> KIP:
>> 
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-158%3A+Kafka+Connect+should+allow+source+connectors+to+set+topic-specific+settings+for+new+topics
>> 
>> Discussion Thread:
>> https://www.mail-archive.com/dev@kafka.apache.org/msg73775.html
>> 
>> Thanks!
>> 
>> Randall
>>

Re: [EXTERNAL] [VOTE] KIP-158: Kafka Connect should allow source connectors to set topic-specific settings for new topics

Posted by Ewen Cheslack-Postava <ew...@confluent.io>.
+1 (binding)

My only final comment would be that the topic.creation.enable setting could
potentially be left out. We're still backwards compatible with what we
promised before (or at least compatibility is debatable). You could enforce
not being able to create topics with ACLs anyway, so avoiding the extra
config might be worth the not-quite-perfect compatibility story.

-Ewen

On Tue, Sep 11, 2018 at 7:01 AM Stephane Maarek <
stephane@simplemachines.com.au> wrote:

> +1 (non binding)
>
> On Tue., 11 Sep. 2018, 10:48 am Mickael Maison, <mi...@gmail.com>
> wrote:
>
> > +1 (non-binding)
> > Thanks for the KIP!
> > On Tue, Sep 11, 2018 at 8:40 AM McCaig, Rhys <Rh...@comcast.com>
> > wrote:
> > >
> > > Looks great Randall
> > > +1 (non-binding)
> > >
> > > > On Sep 9, 2018, at 7:17 PM, Gwen Shapira <gw...@confluent.io> wrote:
> > > >
> > > > +1
> > > > Useful improvement, thanks Randall.
> > > >
> > > >
> > > > On Fri, Sep 7, 2018, 3:28 PM Randall Hauch <rh...@gmail.com> wrote:
> > > >
> > > >> I believe the feedback on KIP-158 has been addressed. I'd like to
> > start a
> > > >> vote.
> > > >>
> > > >> KIP:
> > > >>
> > > >>
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-158%3A+Kafka+Connect+should+allow+source+connectors+to+set+topic-specific+settings+for+new+topics
> > > >>
> > > >> Discussion Thread:
> > > >> https://www.mail-archive.com/dev@kafka.apache.org/msg73775.html
> > > >>
> > > >> Thanks!
> > > >>
> > > >> Randall
> > > >>
> > >
> >
>

Re: [EXTERNAL] [VOTE] KIP-158: Kafka Connect should allow source connectors to set topic-specific settings for new topics

Posted by Stephane Maarek <st...@simplemachines.com.au>.
+1 (non binding)

On Tue., 11 Sep. 2018, 10:48 am Mickael Maison, <mi...@gmail.com>
wrote:

> +1 (non-binding)
> Thanks for the KIP!
> On Tue, Sep 11, 2018 at 8:40 AM McCaig, Rhys <Rh...@comcast.com>
> wrote:
> >
> > Looks great Randall
> > +1 (non-binding)
> >
> > > On Sep 9, 2018, at 7:17 PM, Gwen Shapira <gw...@confluent.io> wrote:
> > >
> > > +1
> > > Useful improvement, thanks Randall.
> > >
> > >
> > > On Fri, Sep 7, 2018, 3:28 PM Randall Hauch <rh...@gmail.com> wrote:
> > >
> > >> I believe the feedback on KIP-158 has been addressed. I'd like to
> start a
> > >> vote.
> > >>
> > >> KIP:
> > >>
> > >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-158%3A+Kafka+Connect+should+allow+source+connectors+to+set+topic-specific+settings+for+new+topics
> > >>
> > >> Discussion Thread:
> > >> https://www.mail-archive.com/dev@kafka.apache.org/msg73775.html
> > >>
> > >> Thanks!
> > >>
> > >> Randall
> > >>
> >
>

Re: [EXTERNAL] [VOTE] KIP-158: Kafka Connect should allow source connectors to set topic-specific settings for new topics

Posted by Mickael Maison <mi...@gmail.com>.
+1 (non-binding)
Thanks for the KIP!
On Tue, Sep 11, 2018 at 8:40 AM McCaig, Rhys <Rh...@comcast.com> wrote:
>
> Looks great Randall
> +1 (non-binding)
>
> > On Sep 9, 2018, at 7:17 PM, Gwen Shapira <gw...@confluent.io> wrote:
> >
> > +1
> > Useful improvement, thanks Randall.
> >
> >
> > On Fri, Sep 7, 2018, 3:28 PM Randall Hauch <rh...@gmail.com> wrote:
> >
> >> I believe the feedback on KIP-158 has been addressed. I'd like to start a
> >> vote.
> >>
> >> KIP:
> >>
> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-158%3A+Kafka+Connect+should+allow+source+connectors+to+set+topic-specific+settings+for+new+topics
> >>
> >> Discussion Thread:
> >> https://www.mail-archive.com/dev@kafka.apache.org/msg73775.html
> >>
> >> Thanks!
> >>
> >> Randall
> >>
>